-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update document description to enable departAt and arriveAt in the past #31616
Merged
koyasu221b
merged 3 commits into
main
from
users/huangwill/koyasu221b-maps-Route-description
Nov 26, 2024
Merged
Update document description to enable departAt and arriveAt in the past #31616
koyasu221b
merged 3 commits into
main
from
users/huangwill/koyasu221b-maps-Route-description
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
koyasu221b
requested review from
vicancy and
mario-guerra
and removed request for
a team
November 20, 2024 02:12
koyasu221b
added
the
PublishToCustomers
Acknowledgement the changes will be published to Azure customers.
label
Nov 21, 2024
FarazGIS
reviewed
Nov 24, 2024
specification/maps/data-plane/Route/preview/2023-10-01-preview/route.json
Outdated
Show resolved
Hide resolved
koyasu221b
force-pushed
the
users/huangwill/koyasu221b-maps-Route-description
branch
from
November 26, 2024 02:03
a563b94
to
03af6e4
Compare
gigigoo0
approved these changes
Nov 26, 2024
koyasu221b
deleted the
users/huangwill/koyasu221b-maps-Route-description
branch
November 26, 2024 14:38
mikeharder
pushed a commit
to mikeharder/azure-rest-api-specs
that referenced
this pull request
Nov 27, 2024
…st (Azure#31616) * update departAt and arriveAt * Add suppressions * remove explain date-time format again --------- Co-authored-by: Will Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data-plane
Maps
PublishToCustomers
Acknowledgement the changes will be published to Azure customers.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
Update document to enable departAt and arriveAt in the past
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
Update description for DepartAt and ArriveAt
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.