ComputerVision - collection of fixes #3145
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -326,16 +326,10 @@ | |
| "in": "path", | ||
| "description": "The domain-specific content to recognize.", | ||
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/ServiceLanguage" | ||
| }, | ||
| { | ||
| "$ref": "../../../Common/Parameters.json#/parameters/ImageUrl" | ||
|
|
@@ -663,6 +657,9 @@ | |
| "application/json" | ||
| ], | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/ServiceLanguage" | ||
| }, | ||
| { | ||
| "$ref": "../../../Common/Parameters.json#/parameters/ImageStream" | ||
| } | ||
|
|
@@ -707,6 +704,9 @@ | |
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/ServiceLanguage" | ||
| }, | ||
| { | ||
| "$ref": "../../../Common/Parameters.json#/parameters/ImageStream" | ||
| } | ||
|
|
@@ -895,7 +895,8 @@ | |
| "type": "object", | ||
| "properties": { | ||
| "language": { | ||
| "type": "string", | ||
| "description": "The BCP-47 language code of the text in the image." | ||
|
There was a problem hiding this comment. is this a breaking change in the server side? i.e. returning string instead of complex type? There was a problem hiding this comment. No the server for this type is unchanged for 2+ years. The swagger was just wrong. There was a problem hiding this comment. A bit of background - up to now most of our customers have been using a hand-built .net client SDK. We're bringing the swagger to par so that this will be the official package source moving forward. There was a problem hiding this comment. @cthrash thank you Chris for clarifying. |
||
| }, | ||
| "textAngle": { | ||
| "type": "number", | ||
|
|
@@ -997,7 +998,8 @@ | |
| "properties": { | ||
| "result": { | ||
| "x-ms-client-flatten": true, | ||
| "type": "object", | ||
| "description": "Model-specific response" | ||
| }, | ||
| "requestId": { | ||
| "type": "string", | ||
|
|
@@ -1008,15 +1010,53 @@ | |
| } | ||
| } | ||
| }, | ||
| "CelebrityResults": { | ||
| "type": "object", | ||
| "description": "List of celebrities recognized in the image.", | ||
| "properties": { | ||
| "celebrities": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/CelebritiesModel" | ||
| } | ||
| }, | ||
| "requestId": { | ||
| "type": "string", | ||
| "description": "Id of the REST API request." | ||
| }, | ||
| "metadata": { | ||
| "$ref": "#/definitions/ImageMetadata" | ||
| } | ||
| } | ||
| }, | ||
| "LandmarkResults": { | ||
| "type": "object", | ||
| "description": "List of landmarks recognized in the image.", | ||
| "properties": { | ||
| "landmarks": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object", | ||
| "description": "A landmark recognized in the image", | ||
| "properties": { | ||
| "name": { | ||
| "type": "string", | ||
| "description": "Name of the landmark." | ||
| }, | ||
| "confidence": { | ||
| "type": "number", | ||
| "format": "double", | ||
| "description": "Confidence level for the landmark recognition." | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "requestId": { | ||
| "type": "string", | ||
| "description": "Id of the REST API request." | ||
| }, | ||
| "metadata": { | ||
| "$ref": "#/definitions/ImageMetadata" | ||
| } | ||
| } | ||
| }, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason to use raw string instead of enum? Are we are doing this to ensure customer can use SDK with content values those are not listed as known enum values (Celebrities, Landmarks)? If yes, then we could simply change
"modelAsString": falseto"modelAsString": true.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today we only have two custom (domain) models, but we want to reserve the right to add one without requiring a client SDK refresh. There's a method (
/model) that will return the permissible values. Note that the hand-crafted version only takes a string.