Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeSpecValidation] Pass target path to "tsp compile" #31371

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[TypeSpecValidation] Pass target path to "tsp compile" #31371

merged 1 commit into from
Oct 31, 2024

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Oct 31, 2024 •
edited
Loading

  • Earlier bugs required running "tsp compile" from target dir
  • Should effectively be a no-op for the tool and its users

@mikeharder
Pass target path to "tsp compile"
2884f9a 
- Earlier bugs required running "tsp compile" from target dir
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 31, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 31, 2024 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@mikeharder mikeharder changed the title Pass target path to "tsp compile" [TypeSpecValidation] Pass target path to "tsp compile" Oct 31, 2024
@mikeharder mikeharder marked this pull request as ready for review October 31, 2024 21:56
@mikeharder mikeharder self-assigned this Oct 31, 2024
@mikeharder mikeharder enabled auto-merge (squash) October 31, 2024 22:01
@mikeharder mikeharder merged commit b0679e9 into Azure:main Oct 31, 2024
37 of 38 checks passed
@mikeharder mikeharder deleted the tsv-compile-path branch October 31, 2024 22:37
haagha pushed a commit that referenced this pull request Nov 19, 2024
@mikeharder @haagha
[TypeSpecValidation] Pass target path to "tsp compile" (#31371)
255d461 
- Earlier bugs required running "tsp compile" from target dir
- Should effectively be a no-op for the tool and its users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees

@mikeharder mikeharder

Labels
None yet
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeharder @weshaggard