Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust clientnames for operations in Authoring Analyzetext and Conversations #31360

Merged
merged 32 commits into from
Dec 9, 2024
Merged

Adjust clientnames for operations in Authoring Analyzetext and Conversations #31360

merged 32 commits into from
Dec 9, 2024

Conversation

amber-ccc
Copy link
Member

…GetCopyProjectStatusResult' to Authoring.Analyzetext

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@amber-ccc
- adding clientNames 'GetAssignDeploymentResourcesStatusResult' and '…
d31e839 
…GetCopyProjectStatusResult' to Authoring.Analyzetext
@amber-ccc amber-ccc requested a review from yangyuan as a code owner October 31, 2024 17:27
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 31, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 31, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
.Net Azure.AI.Language.Conversations.Authoring https://apiview.dev/Assemblies/Review/7e44a77d6cc74b57aa96e618df5c8d2d?revisionId=ac7ce71fe8d247b3b310f49f4102d28b
.Net Azure.AI.Language.Text.Authoring https://apiview.dev/Assemblies/Review/deb5b3d8ee4a46a6a3d76572678b0f86?revisionId=5e2aac18b1164cd4b561eb2bf96482a0
TypeSpec Language.AnalyzeConversations-authoring https://apiview.dev/Assemblies/Review/1a730f703f0e4672a645a7f283b636e8?revisionId=bbb07e26e0e14109b83d3b20c19b5cb5
TypeSpec Language.AnalyzeText-authoring https://apiview.dev/Assemblies/Review/b1a99f7e35344703b31b123c23e73bcd?revisionId=d5d986a3160045378d07abfdf17a80fa

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Oct 31, 2024
@azure-sdk azure-sdk mentioned this pull request Oct 31, 2024
Closed
@amber-ccc amber-ccc requested review from allenjzhang and mario-guerra and removed request for a team November 1, 2024 06:29
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane labels Nov 1, 2024
@azure-sdk azure-sdk mentioned this pull request Nov 4, 2024
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Nov 4, 2024
@azure-sdk azure-sdk mentioned this pull request Nov 21, 2024
Closed
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 3, 2024 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

examples
preview

markcowl
markcowl approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typespec here looks good, need to verify no sdk breaking changes

GouriKA
GouriKA reviewed Dec 5, 2024
View reviewed changes
specification/cognitiveservices/Language.AnalyzeText-authoring/models.tsp
* An object containing more specific information about the error. As per
* Microsoft One API guidelines -
* https://github.com/Microsoft/api-guidelines/blob/vNext/Guidelines.md#7102-error-condition-responses.
* An object containing more specific information about the error. As per Microsoft One API guidelines - https://github.com/Microsoft/api-guidelines/blob/vNext/Guidelines.md#7102-error-condition-responses.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you changed the comments to be in single line throughout the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multiple lines here will be several "/n" in the generated swagger, so Heath suggested us to avoid this sort of rendering control characters.

@amber-ccc amber-ccc force-pushed the amber/adjust_models_names_authoring branch from 888885d to eb4f994 Compare December 6, 2024 01:41
@markcowl markcowl added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Dec 7, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Dec 7, 2024
@bidisha-c bidisha-c added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Dec 9, 2024
@amber-ccc amber-ccc merged commit 1bbb8f6 into Azure:main Dec 9, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofCwalina KrzysztofCwalina KrzysztofCwalina left review comments

@GouriKA GouriKA GouriKA approved these changes

@heaths heaths heaths approved these changes

@markcowl markcowl markcowl approved these changes

@yangyuan yangyuan Awaiting requested review from yangyuan yangyuan is a code owner

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@kristapratico kristapratico Awaiting requested review from kristapratico kristapratico is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga is a code owner

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner automatically assigned from Azure/api-stewardship-board

@mario-guerra mario-guerra Awaiting requested review from mario-guerra mario-guerra is a code owner automatically assigned from Azure/api-stewardship-board

Assignees
No one assigned
Labels
BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Cognitive Services data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@amber-ccc @heaths @azure-sdk @markcowl @KrzysztofCwalina @GouriKA @bidisha-c @AzureRestAPISpecReview