Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate typespec validation #31033
Migrate typespec validation #31033
Changes from all commits
43cb00b
b3b9f1a
808ea5f
96b6c82
1ebe623
dba759b
4136688
bab1ae6
d923e56
0e71fc9
6839fbb
ec7af3d
be5efe7
985bf9b
407cb5e
e1ec118
b32b546
1057f5d
8bdee66
9eba441
92e359b
2723721
d232bb5
e7b871b
772ef9f
a154939
c20eb68
7856ddf
4f904de
0b7b6a6
cfddb9e
b3d1458
906a8a2
d49e44f
95a6cc3
62a57b5
7109da1
e4410d9
36de665
5f1b7c6
a088013
889143e
6c836b3
3b50e1a
ecaf771
34a7d4b
a316274
be61a9c
2886209
7fa3248
4f4cfd9
1fbda3c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeharder @danieljurek I thought github force these to be under the workflows directory. Is this a way we can make other reusable pieces for actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow itself must be under
.github/workflows
, but I believe custom actions can live anywhere in your repo, in another repo, etc.We're still experimenting, but we're considering trying to provide most reusable code through custom actions, rather than using
github-script
everywhere and sharing JS code.Custom actions can still use
github-script
internally, but the goal would be to make most of our leaf-node workflows as declarative as possible (no github-script).This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we hit this case if there were only one spec discovered but we have it sharded in 3? I assume this wouldn't be the case for tsv-all but could be in other cases if we use this logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, currently the caller needs to check this first:
https://github.com/Azure/azure-rest-api-specs/pull/31033/files/1fbda3c72ab85858bea20a6a2f9c3654b45b49ed#diff-608a3bb7e5c6d9a396eb1c6636c575f534ed9d9649926eaf2249880c995a4db0R25