Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure load testing API version 2024-07-01-preview #30881

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Azure load testing API version 2024-07-01-preview #30881

merged 6 commits into from
Oct 11, 2024

Conversation

venkatr21
Copy link
Member

API Info: The Basics

  1. Supporting pass fail criteria based on server-side metrics for Azure load testing
  2. Displaying the VUserHours for the test run, which is an estimate of billing consumption of the test run
  3. Scheduling test run changes for Azure load testing which is a new set of API called triggers

Change Scope

This PR adds a

  1. PassFailServerCriteria inside which has fields like resource id of the server, metric namespace, metric name, aggregation, threshold values
  2. Identity reference for metrics which is the identity used to fetch metrics from the customer's server
  3. API changes for newly introduced trigger API for scheduling test run
  4. Add VUH details to the test run

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 7, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 7, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Java azure-developer-loadtesting https://apiview.dev/Assemblies/Review/f9ecb024706e409d90368c6d75c1459f?revisionId=dfcbb95f0e854d03bee02156f4d58dab
Python azure-developer-loadtesting https://apiview.dev/Assemblies/Review/b9a319af1293456d9da576aebe0d5bd2?revisionId=502366953d5d4620b826e3df5912ea1e
TypeSpec LoadTestService https://apiview.dev/Assemblies/Review/d4db9f6cfa514080a0bab9e43f0cab96?revisionId=2017f6b3a71a4cb5a58c299972fb73a9
Swagger Microsoft.LoadTestService https://apiview.dev/Assemblies/Review/495fc1b0cebd40db9f2774dfc62de3cc?revisionId=3cc1acde5b0843968bd2a141adc43fbc

@microsoft-github-policy-service microsoft-github-policy-service bot added the Load Test Service Azure Load Test Service label Oct 7, 2024
@azure-sdk azure-sdk mentioned this pull request Oct 7, 2024
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added data-plane TypeSpec Authored with TypeSpec labels Oct 7, 2024
@azure-sdk azure-sdk mentioned this pull request Oct 7, 2024
Closed
This was referenced Oct 7, 2024
Closed
Closed
@venkatr21 venkatr21 marked this pull request as ready for review October 8, 2024 04:17
@venkatr21 venkatr21 requested a review from a team as a code owner October 8, 2024 04:17
@venkatr21 venkatr21 requested review from scgbear and johanste and removed request for a team October 8, 2024 04:17
mikekistler
mikekistler approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I noticed a minor inconsistency in date-time parameter naming that I flagged in my comments. That would be good to fix but not absolutely necessary for preview.

@weidongxu-microsoft weidongxu-microsoft added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Oct 11, 2024
@venkatr21 venkatr21 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 11, 2024
@venkatr21 venkatr21 merged commit 57cbfdb into main Oct 11, 2024
27 of 30 checks passed
@venkatr21 venkatr21 deleted the users/venkat/azure-loadtesting-2024-07-01-preview branch October 11, 2024 05:55
haagha pushed a commit that referenced this pull request Nov 19, 2024
@venkatr21 @mitsha-microsoft @haagha
Azure load testing API version 2024-07-01-preview (#30881)
1106ab4 
* add api version 2024-07-01-preview

* update readme

* added trigger examples

* spacing fix

* PR Comment for List Parameter

* Updatiing property docs

---------

Co-authored-by: Venkat Ragavan S <[email protected]>
Co-authored-by: Mitesh Shah <[email protected]>
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
@venkatr21 @mitsha-microsoft @cheukchuen
Azure load testing API version 2024-07-01-preview (#30881)
01ac4b5 
* add api version 2024-07-01-preview

* update readme

* added trigger examples

* spacing fix

* PR Comment for List Parameter

* Updatiing property docs

---------

Co-authored-by: Venkat Ragavan S <[email protected]>
Co-authored-by: Mitesh Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsha-microsoft mitsha-microsoft mitsha-microsoft approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@mikekistler mikekistler mikekistler approved these changes

@scgbear scgbear Awaiting requested review from scgbear scgbear is a code owner automatically assigned from Azure/api-stewardship-board

@johanste johanste Awaiting requested review from johanste johanste is a code owner automatically assigned from Azure/api-stewardship-board

Assignees
No one assigned
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. data-plane Load Test Service Azure Load Test Service new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@venkatr21 @weidongxu-microsoft @mitsha-microsoft @mikekistler @AzureRestAPISpecReview