Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the diagnostic text typo #30796

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mattboentoro
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • Fix the diagnostic text typo

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@mattboentoro mattboentoro requested a review from a team as a code owner September 30, 2024 16:41
Copy link

openapi-pipeline-app bot commented Sep 30, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Sep 30, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/cosmosforpostgresql/armcosmosforpostgresql https://apiview.dev/Assemblies/Review/cac9faa3c2504e839013722e847a02db?revisionId=7e2f9a144ced4faab5c0406243254e6d
Go sdk/resourcemanager/mariadb/armmariadb There is no API change compared with the previous version
Go sdk/resourcemanager/mysql/armmysql There is no API change compared with the previous version
Go sdk/resourcemanager/mysql/armmysqlflexibleservers https://apiview.dev/Assemblies/Review/385e38bb2a11498d9b5546585eb56ad5?revisionId=a362c05cb36a460f92b446bfa44695d2
Go sdk/resourcemanager/postgresql/armpostgresql There is no API change compared with the previous version
Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers https://apiview.dev/Assemblies/Review/af578fe7418c4c5b9155096b33a0d480?revisionId=7e3df74ea9604480adb66c720399c7e2
JavaScript @azure/arm-cosmosdbforpostgresql https://apiview.dev/Assemblies/Review/79f51424b9244cc4a97c09436942302b?revisionId=cdf47a5e77b14646ad387d059de4addc
JavaScript @azure/arm-mariadb https://apiview.dev/Assemblies/Review/c5ecac341320435d9c6f2a8674ce910e?revisionId=858139edcced4e64a9c88a7a4da823e2
.Net Azure.ResourceManager.MySql There is no API change compared with the previous version
.Net Azure.ResourceManager.PostgreSql There is no API change compared with the previous version
Java azure-resourcemanager-cosmosdbforpostgresql https://apiview.dev/Assemblies/Review/ae1ae1d716c94040bbcc7d15059b566b?revisionId=8d8fc2ac2afe4816bf2bc1168033f114
Java azure-resourcemanager-mariadb https://apiview.dev/Assemblies/Review/694e6008b32b4f42bcb7d3005cb1d1f7?revisionId=0985742bbe494cd4848a5d0fc52a5c14
Java azure-resourcemanager-mysqlflexibleserver https://apiview.dev/Assemblies/Review/8dd7313daf5c47d38f304b7fbef01335?revisionId=14ef65a736ee47fda5998c5f12f23ad8
Java azure-resourcemanager-postgresqlflexibleserver https://apiview.dev/Assemblies/Review/21a61d731117447dbd7223467d7cfa42?revisionId=202d28e43d68469d82a13b697b102e05

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 30, 2024
This was referenced Sep 30, 2024
Copy link

@nachoalonsoportillo nachoalonsoportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattboentoro
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 5, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 5, 2024
@mattboentoro mattboentoro added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 9, 2024
@mattboentoro mattboentoro merged commit 59a7e32 into Azure:main Oct 11, 2024
28 of 31 checks passed
@mattboentoro mattboentoro deleted the mattboentoro/fix-typo branch October 11, 2024 16:38
haagha pushed a commit that referenced this pull request Nov 19, 2024
digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-ModelValidation ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants