-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Swagger constraints to allow HANA Very Large Instances #3029
Update Swagger constraints to allow HANA Very Large Instances #3029
Conversation
Update HanaHardwareTypeNamesEnum list to include VLI hardware type Update HanaInstanceSizeNamesEnum list to include VLI SKUs Fix typo in HanaHardwareTypeNamesEnum description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM it would be great if you could update your examples based on these changes.
Will merge on CIs passing
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/hanaonazure/resource-manager/readme.md
|
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/hanaonazure/resource-manager/readme.md
|
Update HanaInstances_List.json Update HanaInstances_ListByResourceGroup.json
@dsgouda I've updated the examples to include instances of the new values, and I have validated the updated examples with Please confirm and merge PR if this is acceptable. |
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/hanaonazure/resource-manager/readme.md
|
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/hanaonazure/resource-manager/readme.md
|
Automation for azure-libraries-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goEncountered an unknown error: (azure-sdk-for-go)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 248, in generate_sdk_from_git_object
swagger_files_in_commit = get_readme_files_from_git_object(git_object, restapi_git_folder)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkCore.py", line 90, in get_readme_files_from_git_object
files_list = [file.filename for file in get_files(git_object)]
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkCore.py", line 90, in <listcomp>
files_list = [file.filename for file in get_files(git_object)]
File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 58, in __iter__
newElements = self._grow()
File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 70, in _grow
newElements = self._fetchNextPage()
File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 172, in _fetchNextPage
headers=self.__headers
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 185, in requestJsonAndCheck
return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 231, in requestJson
return self.__requestEncode(cnx, verb, url, parameters, headers, input, encode)
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 284, in __requestEncode
status, responseHeaders, output = self.__requestRaw(cnx, verb, url, requestHeaders, encoded_input)
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 309, in __requestRaw
requestHeaders
File "/usr/lib/python3.6/http/client.py", line 1239, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/usr/lib/python3.6/http/client.py", line 1285, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/usr/lib/python3.6/http/client.py", line 1234, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/usr/lib/python3.6/http/client.py", line 1026, in _send_output
self.send(msg)
File "/usr/lib/python3.6/http/client.py", line 964, in send
self.connect()
File "/usr/lib/python3.6/http/client.py", line 1400, in connect
server_hostname=server_hostname)
File "/usr/lib/python3.6/ssl.py", line 407, in wrap_socket
_context=self, _session=session)
File "/usr/lib/python3.6/ssl.py", line 814, in __init__
self.do_handshake()
File "/usr/lib/python3.6/ssl.py", line 1068, in do_handshake
self._sslobj.do_handshake()
File "/usr/lib/python3.6/ssl.py", line 689, in do_handshake
self._sslobj.do_handshake()
socket.timeout: _ssl.c:761: The handshake operation timed out |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Update HanaHardwareTypeNamesEnum list to include VLI hardware type
Update HanaInstanceSizeNamesEnum list to include VLI SKUs
Fix typo in HanaHardwareTypeNamesEnum description
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger