Refactoring DSCNodeConfigurationCreate Parameters #3012

vrdmr · 2018-05-04T02:04:36Z

Refactoring DSCNodeConfiguration to prevent the Autorest to not merge the models while generating the dot net client.
Also, fixed the DSCNodeConfiguration (2018-01-15) Get call to correct the response code. The service returns the 201 and fixing this to currently unblock out azure powershell release.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-05-04T02:05:15Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-05-04T02:06:43Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#1959

AutorestCI · 2018-05-04T02:09:19Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2653

AutorestCI · 2018-05-04T02:09:57Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpxqs1o8xy/rest/specification/automation/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpxqs1o8xy/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '[email protected]/autorest.go@~2.1.98', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4275)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.98->2.1.98)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2015-10"} .
Processing batch task - {"tag":"package-2017-05-preview"} .
Processing batch task - {"tag":"package-2018-01-preview"} .
FATAL: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: startIndex
   at System.String.LastIndexOf(Char value, Int32 startIndex, Int32 count)
   at AutoRest.Go.Model.CodeModelGo.PackageVerDir() in /opt/vsts/work/1/s/src/Model/CodeModelGo.cs:line 64
   at AutoRest.Go.Model.CodeModelGo.get_DefaultUserAgent() in /opt/vsts/work/1/s/src/Model/CodeModelGo.cs:line 83
   at AutoRest.Go.Model.CodeModelGo.get_UserAgent() in /opt/vsts/work/1/s/src/Model/CodeModelGo.cs:line 31
   at AutoRest.Go.Templates.VersionTemplate.<ExecuteAsync>d__1.MoveNext() in /opt/vsts/work/1/s/src/obj/Razor/Templates/VersionTemplate.cshtml:line 28
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in /opt/vsts/work/1/s/src/CodeGeneratorGo.cs:line 91
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-01-preview"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

azuresdkciprbot · 2018-05-04T02:10:42Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(87 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T02:10:42Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

1 new Warnings.(132 total)

Code	Id	Source	Message
DescriptionAndTitleMissing	R4000	Link	'DscNodeConfigurationCreateOrUpdateParameters' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T07:03:14Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(87 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T07:03:14Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T07:15:28Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T07:15:28Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(87 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

sergey-shandar · 2018-05-04T18:19:19Z

@vrdmr Should we make these breaking changes in a new API version?

ravbhatnagar · 2018-05-08T08:52:14Z

@vrdmr - Looks like the shape of a model has changed. This is a existing APi-version. Do you intend to make this change for an existing api-version?

azuresdkciprbot · 2018-05-08T22:04:24Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(131 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-08T22:04:24Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/automation/resource-manager/readme.md

⚠️

0 new Warnings.(87 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

vrdmr · 2018-05-08T22:02:02Z

...fication/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json

@@ -1482,32 +1482,6 @@
      },
      "description": "Definition of the DSC Meta Configuration."
    },
-    "DscNodeConfigurationCreateOrUpdateParameters": {


Moved these definitions to 2015-10-31/DscNodeConfiguration.json

vrdmr · 2018-05-08T22:03:12Z

...automation/resource-manager/Microsoft.Automation/stable/2015-10-31/dscNodeConfiguration.json

@@ -293,6 +293,78 @@
      ],
      "description": "Definition of the dsc node configuration."
    },
+    "ContentSource": {


Added the definitions from Defnitions.json to this file.

vrdmr · 2018-05-08T22:04:30Z

...automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNodeConfiguration.json

@@ -438,10 +439,6 @@
          "$ref": "#/definitions/ContentSource",
          "description": "Gets or sets the source."
        },
-        "name": {


Corrected the model. The Name is not in the top-level property for the Body Parameter.

vrdmr · 2018-05-08T22:04:52Z

...ager/Microsoft.Automation/stable/2018-01-15/examples/createOrUpdateDscNodeConfiguration.json

@@ -3,7 +3,6 @@
        "subscriptionId": "subid",
        "resourceGroupName": "rg",
        "automationAccountName": "myAutomationAccount20",
-        "credentialName": "myCredential",


This was wrong param being sent in the example.

vrdmr · 2018-05-08T23:17:15Z

@ravbhatnagar - The model change is to make it at par with the service now. The "name" was added. (I've added comments for each file now.

vrdmr · 2018-05-08T23:28:55Z

@sergey-shandar - The 2015-refactoring is just moving the definitions around to prevent the autorest generation issues that we are seeing in the SDK due to the new 2018-01-15 API spec for DSCNodeConfiguration.

vrdmr · 2018-05-11T00:07:03Z

@ravbhatnagar @sergey-shandar Could you please take a look at this PR. Thanks.

ravbhatnagar · 2018-05-11T01:10:33Z

@vrdmr - Sounds good. Since the service never used to return this model, it should be fine. Signing off from ARM side.

vrdmr · 2018-05-11T18:37:47Z

Thanks, @ravbhatnagar. @sergey-shandar - Could you please take a look at this PR.

vrdmr · 2018-05-14T19:36:44Z

Thanks, @sergey-shandar.

azuresdkci assigned sergey-shandar May 4, 2018

azuresdkci requested a review from sergey-shandar May 4, 2018 02:05

AutorestCI mentioned this pull request May 4, 2018

[AutoPR automation/resource-manager] Refacroting DSCNodeConfigurationCreate Parameters Azure/azure-sdk-for-python#2530

Closed

AutorestCI mentioned this pull request May 4, 2018

[AutoPR automation/resource-manager] Refacroting DSCNodeConfigurationCreate Parameters Azure/azure-sdk-for-node#2834

Closed

Refacroting DSCNodeConfigurationCreate Parameters

ed80b6e

sergey-shandar added potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 4, 2018

Fix the return model for Get NodeConfig call

cde3c01

vrdmr commented May 8, 2018

View reviewed changes

vrdmr changed the title ~~Refacroting DSCNodeConfigurationCreate Parameters~~ Refactoring DSCNodeConfigurationCreate Parameters May 9, 2018

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 11, 2018

sergey-shandar approved these changes May 14, 2018

View reviewed changes

sergey-shandar merged commit 0cecb10 into Azure:master May 14, 2018

vrdmr deleted the vameru-dsc-refactor branch July 16, 2018 18:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring DSCNodeConfigurationCreate Parameters #3012

Refactoring DSCNodeConfigurationCreate Parameters #3012

vrdmr commented May 4, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 4, 2018 •

edited

Loading

AutorestCI commented May 4, 2018 •

edited

Loading

AutorestCI commented May 4, 2018 •

edited

Loading

AutorestCI commented May 4, 2018 •

edited

Loading

azuresdkciprbot commented May 4, 2018

azuresdkciprbot commented May 4, 2018

azuresdkciprbot commented May 4, 2018

azuresdkciprbot commented May 4, 2018

azuresdkciprbot commented May 4, 2018

azuresdkciprbot commented May 4, 2018

sergey-shandar commented May 4, 2018

ravbhatnagar commented May 8, 2018

azuresdkciprbot commented May 8, 2018

azuresdkciprbot commented May 8, 2018

vrdmr May 8, 2018

vrdmr May 8, 2018

vrdmr May 8, 2018 •

edited

Loading

vrdmr May 8, 2018

vrdmr commented May 8, 2018

vrdmr commented May 8, 2018

vrdmr commented May 11, 2018

ravbhatnagar commented May 11, 2018

vrdmr commented May 11, 2018

vrdmr commented May 14, 2018

Refactoring DSCNodeConfigurationCreate Parameters #3012

Refactoring DSCNodeConfigurationCreate Parameters #3012

Conversation

vrdmr commented May 4, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented May 4, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented May 4, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 4, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 4, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkciprbot commented May 4, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 4, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 4, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 4, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 4, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 4, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

sergey-shandar commented May 4, 2018

ravbhatnagar commented May 8, 2018

azuresdkciprbot commented May 8, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 8, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

vrdmr May 8, 2018

Choose a reason for hiding this comment

vrdmr May 8, 2018

Choose a reason for hiding this comment

vrdmr May 8, 2018 • edited Loading

Choose a reason for hiding this comment

vrdmr May 8, 2018

Choose a reason for hiding this comment

vrdmr commented May 8, 2018

vrdmr commented May 8, 2018

vrdmr commented May 11, 2018

ravbhatnagar commented May 11, 2018

vrdmr commented May 11, 2018

vrdmr commented May 14, 2018

vrdmr commented May 4, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 4, 2018 •

edited

Loading

AutorestCI commented May 4, 2018 •

edited

Loading

AutorestCI commented May 4, 2018 •

edited

Loading

AutorestCI commented May 4, 2018 •

edited

Loading

vrdmr May 8, 2018 •

edited

Loading