2018-05-01 APIs for Microsoft.Resources #2976

Tiano2017 · 2018-04-30T18:58:46Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-04-30T19:00:50Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpr9dc_x3p/rest/specification/resources/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpr9dc_x3p/sdk', '--nodejs', '[email protected]/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.59)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
[Exception] No input files provided.

Use --help to get help information.

azuresdkciprbot · 2018-04-30T19:03:22Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/resources/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-30T19:03:22Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/resources/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

vivsriaus · 2018-04-30T19:05:15Z

specification/resources/resource-manager/Microsoft.Resources/stable/2017-05-10/resources.json

+        "tags": [
+          "Deployments"
+        ],
+        "operationId": "Deployments_Delete",


Deployments_Delete [](start = 24, length = 18)

We should use a different operation Id, so that it doesn't conflict with the existing RG level deployment APIs below

vivsriaus · 2018-04-30T19:05:47Z

specification/resources/resource-manager/Microsoft.Resources/stable/2017-05-10/resources.json

+    "/subscriptions/{subscriptionId}/providers/Microsoft.Resources/deployments/{deploymentName}": {
+      "delete": {
+        "tags": [
+          "Deployments"


Deployments [](start = 11, length = 11)

Deployments_SubscriptionLevel ? (or something better, to differentiate from the original APIs)

AutorestCI · 2018-04-30T19:09:36Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#154

AutorestCI · 2018-04-30T19:23:58Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2570

AutorestCI · 2018-04-30T19:32:37Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1970

azuresdkciprbot · 2018-04-30T21:54:02Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/resources/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-30T21:54:03Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/resources/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

ravbhatnagar · 2018-05-01T16:14:49Z

specification/resources/resource-manager/Microsoft.Resources/stable/2017-05-10/resources.json

+            "$ref": "#/parameters/SubscriptionIdParameter"
+          }
+        ],
+        "responses": {


Add a "default" error response to capture all the error states. Example here - https://github.com/Azure/azure-rest-api-specs/blob/master/specification/batch/resource-manager/Microsoft.Batch/stable/2017-09-01/BatchManagement.json#L101

we don't have a good story for the default error responses today. This is common for all our APIs. I think we can address that separately.

ravbhatnagar · 2018-05-01T16:20:07Z

specification/resources/resource-manager/Microsoft.Resources/stable/2017-05-10/resources.json

@@ -2046,6 +2361,10 @@
    },
    "Deployment": {
      "properties": {
+        "location": {


We cant make this change in existing API-version. Existing SDKs will not be able to deserialize.

Right. I'm adding it to a new api-version.

ravbhatnagar · 2018-05-01T16:24:38Z

specification/resources/resource-manager/Microsoft.Resources/stable/2017-05-10/resources.json

+            "in": "body",
+            "required": true,
+            "schema": {
+              "$ref": "#/definitions/Deployment"


I know this is legacy but why do we have input model different from output. LIke in input we take Deployment and in output we give back DeploymentExtended. Couldnt we have used the same one and if there are properties which are not settable, we could have marked them as readonly.

This was fixed.

AutorestCI · 2018-05-31T22:29:32Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

Tiano2017 · 2018-05-31T23:35:42Z

@anuchandy, @mcardosos this PR is ready for review. Please help take a look.

shahabhijeet · 2018-06-04T23:35:23Z

specification/resources/resource-manager/readme.md

+
+``` yaml $(tag) == 'package-resources-2018-05'
+input-file:
+- Microsoft.Resources/stable/2018-05-01/resources.json


@Tiano2017 can you get changes from upstream.
Now CSharp specific config file has been added
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/resources/resource-manager/readme.csharp.md

done. @shahabhijeet can you take one more look?

sergey-shandar · 2018-06-04T23:38:01Z

@amarzavery do you have any idea why nod.js is failing?

anuchandy · 2018-06-05T17:21:17Z

@shahabhijeet are you ok with the C# config changes now?

anuchandy · 2018-06-05T18:43:42Z

@Tiano2017 just talked to @shahabhijeet, he has couple of questions around C# config section, please sync with him.

shahabhijeet

Looks good

Tiano2017 · 2018-06-05T19:40:09Z

@anuchandy Synced up with Abhijeet, and he signed off.

azuresdkci assigned mcardosos Apr 30, 2018

azuresdkci requested a review from mcardosos April 30, 2018 19:00

vivsriaus reviewed Apr 30, 2018

View reviewed changes

AutorestCI mentioned this pull request Apr 30, 2018

[AutoPR resources/resource-manager] <Do Not Merge> New APIs for Microsoft.Resources Azure/azure-sdk-for-python#2500

Merged

AutorestCI mentioned this pull request Apr 30, 2018

[AutoPR resources/resource-manager] <Do Not Merge> New APIs for Microsoft.Resources Azure/azure-sdk-for-go#1729

Closed

ravbhatnagar reviewed May 1, 2018

View reviewed changes

salameer unassigned mcardosos May 2, 2018

salameer added the Reassign label May 2, 2018

azuresdkci removed the Reassign label May 2, 2018

azuresdkci assigned anuchandy May 2, 2018

azuresdkci requested a review from anuchandy May 2, 2018 02:33

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 2, 2018

Tiano2017 force-pushed the tiano-d1 branch from 602243e to 5d6b288 Compare May 31, 2018 22:28

reset.

f5c41c0

Tiano2017 force-pushed the tiano-d1 branch from 5d6b288 to f5c41c0 Compare May 31, 2018 22:33

update.

8b06b25

AutorestCI mentioned this pull request May 31, 2018

[AutoPR resources/resource-manager] <Do Not Merge> New APIs for Microsoft.Resources AutorestCI/azure-libraries-for-java#217

Merged

Update readme.md.

2284a3a

Tiano2017 changed the title ~~<Do Not Merge> New APIs for Microsoft.Resources~~ New APIs for Microsoft.Resources May 31, 2018

update readme.md.

5cd6182

AutorestCI mentioned this pull request Jun 1, 2018

[AutoPR resources/resource-manager] New APIs for Microsoft.Resources Azure/azure-sdk-for-go#1938

Closed

fix.

1a25db3

Tiano2017 changed the title ~~New APIs for Microsoft.Resources~~ 2018-05-01 APIs for Microsoft.Resources Jun 4, 2018

shahabhijeet requested changes Jun 4, 2018

View reviewed changes

Tiano2017 added 2 commits June 4, 2018 16:42

Merge remote-tracking branch 'Azure/master' into tiano-d1

eb1b6a0

add changes for readme.csharp.md.

7e0f555

AutorestCI mentioned this pull request Jun 5, 2018

[AutoPR resources/resource-manager] 2018-05-01 APIs for Microsoft.Resources Azure/azure-sdk-for-go#1960

Merged

Tiano2017 mentioned this pull request Jun 5, 2018

Support 2018-05-01 version of Microsoft.Resources API Azure/azure-cli#6498

Closed

shahabhijeet approved these changes Jun 5, 2018

View reviewed changes

anuchandy merged commit 91f504b into Azure:master Jun 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2018-05-01 APIs for Microsoft.Resources #2976

2018-05-01 APIs for Microsoft.Resources #2976

Tiano2017 commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading

azuresdkciprbot commented Apr 30, 2018

azuresdkciprbot commented Apr 30, 2018

vivsriaus Apr 30, 2018

vivsriaus Apr 30, 2018

AutorestCI commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading

azuresdkciprbot commented Apr 30, 2018

azuresdkciprbot commented Apr 30, 2018

ravbhatnagar May 1, 2018

Tiano2017 May 31, 2018

ravbhatnagar May 1, 2018

Tiano2017 May 31, 2018

ravbhatnagar May 1, 2018

Tiano2017 May 31, 2018

AutorestCI commented May 31, 2018 •

edited

Loading

Tiano2017 commented May 31, 2018

shahabhijeet Jun 4, 2018

Tiano2017 Jun 5, 2018

sergey-shandar commented Jun 4, 2018

anuchandy commented Jun 5, 2018

anuchandy commented Jun 5, 2018

shahabhijeet left a comment

Tiano2017 commented Jun 5, 2018

2018-05-01 APIs for Microsoft.Resources #2976

2018-05-01 APIs for Microsoft.Resources #2976

Conversation

Tiano2017 commented Apr 30, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Apr 30, 2018 • edited Loading

Automation for azure-sdk-for-node

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented Apr 30, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 30, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 30, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 30, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AutorestCI commented May 31, 2018 • edited Loading

Automation for azure-sdk-for-ruby

Tiano2017 commented May 31, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergey-shandar commented Jun 4, 2018

anuchandy commented Jun 5, 2018

anuchandy commented Jun 5, 2018

shahabhijeet left a comment

Choose a reason for hiding this comment

Tiano2017 commented Jun 5, 2018

Tiano2017 commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading

AutorestCI commented Apr 30, 2018 •

edited

Loading

AutorestCI commented May 31, 2018 •

edited

Loading