Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update virtualNetworkGateway.json #2975

Merged
merged 1 commit into from
May 14, 2018
Merged

Conversation

anzaman
Copy link
Member

@anzaman anzaman commented Apr 30, 2018

VirtualNetworkGateways_SetVpnclientIpsecParameters AND VirtualNetworkGateways_GetVpnclientIpsecParameters are not in production

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

VirtualNetworkGateways_SetVpnclientIpsecParameters AND VirtualNetworkGateways_GetVpnclientIpsecParameters are not in production
@anzaman
Copy link
Member Author

anzaman commented Apr 30, 2018

@markjbrown

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(108 total)
0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️0 new Warnings.(95 total)
0 new Errors.(76 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@sergey-shandar sergey-shandar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels May 1, 2018
@sergey-shandar
Copy link
Contributor

@ravbhatnagar removing some operations from stable API. As far as I understood, the operations are not in production.

@markjbrown
Copy link
Contributor

@sergey-shandar that is correct. These two operations are not in production and need to be removed so customers do not attempt to use them.

@MikhailTryakhov and @ravbhatnagar please review/approve when you get a moment.

thanks.

@ravbhatnagar
Copy link
Contributor

Looks fine since these are not in prod. Signing off!

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 8, 2018
@sergey-shandar
Copy link
Contributor

@MikhailTryakhov could you review the PR?

@MikhailTryakhov
Copy link
Contributor

@sergey-shandar would review in 1 business day :)

Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to comments above functionality is not in prod so we can remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Network potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants