java, informatica disable emitter in tspconfig #29598

weidongxu-microsoft · 2024-06-27T03:54:29Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-06-27T03:54:33Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-06-27T03:54:34Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Compared specs (v2.2.2)	new version	base version
default	default(140b5e8)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-06-27T03:54:35Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️⚠️ azure-sdk-for-python warning [Detail]

FAQ

⚠️Warning in generating from 064eba1847dc010caa83456ee1dfbe4460617b2f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
cmderr	[automation_init.sh] npm notice
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-informaticadatamanagement [Preview SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 064eba1847dc010caa83456ee1dfbe4460617b2f. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-informaticadatamanagement [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 064eba1847dc010caa83456ee1dfbe4460617b2f. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
warn		Warning: cannot find emitter config for azure-sdk-for-go in tspconfig.yaml for typespec project specification/informatica/Informatica.DataManagement/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/informaticadatamgmt/arminformaticadatamgmt [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 064eba1847dc010caa83456ee1dfbe4460617b2f. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-informaticadatamanagement [Preview SDK Changes]

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-sdk-for-net-track2 warning [Detail]

FAQ

⚠️Warning in generating from 064eba1847dc010caa83456ee1dfbe4460617b2f. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		Warning: azure-sdk-for-net-track2 cannot be found in specification/informatica/resource-manager/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Error: Missing package-dir in @azure-tools/typespec-csharp options of tspconfig.yaml. Please refer to https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml for the right schema.
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice To update run: npm install -g [email protected]
cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
cmderr	[Invoke-GenerateAndBuildV2.ps1] Write-Error: Failed to generate typespec project. Exit code: 1
error	GenerationError: The packageName is empty in the generation output, please confirm if the package has been generated from the SDK generation step.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-06-27T03:54:35Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/informaticadatamgmt/arminformaticadatamgmt	There is no API change compared with the previous version
Java	azure-resourcemanager-informaticadatamanagement	https://apiview.dev/Assemblies/Review/0b990b1bab01456a86d62570fc902c02?revisionId=3f609f52b81a4aa7a082cd4a059a80cf
JavaScript	@azure/arm-informaticadatamanagement	https://apiview.dev/Assemblies/Review/97ce5efe21f14e5fa548e440b9aadad7?revisionId=f550a18d2d0245d6a9191ed764e5460d

weidongxu-microsoft · 2024-06-27T04:13:03Z

there is a few naming diff

    private InfaRuntimeResourceFetchMetaData() {
    private InfaRuntimeResourceFetchMetadata() {

XiaofeiCao · 2024-06-27T05:47:29Z

there is a few naming diff

    private InfaRuntimeResourceFetchMetaData() {
    private InfaRuntimeResourceFetchMetadata() {

Yeah, this is done by fluent naming override. If switched to TypeSpec in the future, we could use @clientName to rename them compatible to swagger output.

java, informatica disable emitter in tspconfig

f9eee8a

XiaofeiCao approved these changes Jun 27, 2024

View reviewed changes

AzureRestAPISpecReview added resource-manager RPaaS TypeSpec Authored with TypeSpec labels Jun 27, 2024

weidongxu-microsoft marked this pull request as ready for review June 27, 2024 04:12

weidongxu-microsoft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 27, 2024

AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test labels Jun 27, 2024

haolingdong-msft approved these changes Jun 27, 2024

View reviewed changes

Merge branch 'main' into java_informatica_disable-tsp-emitter

140b5e8

weidongxu-microsoft merged commit 00a6d4f into Azure:main Jun 28, 2024
31 of 32 checks passed

weidongxu-microsoft deleted the java_informatica_disable-tsp-emitter branch June 28, 2024 02:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

java, informatica disable emitter in tspconfig #29598

java, informatica disable emitter in tspconfig #29598

weidongxu-microsoft commented Jun 27, 2024

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

weidongxu-microsoft commented Jun 27, 2024

XiaofeiCao commented Jun 27, 2024

java, informatica disable emitter in tspconfig #29598

java, informatica disable emitter in tspconfig #29598

Conversation

weidongxu-microsoft commented Jun 27, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Jun 27, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Jun 27, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 27, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Jun 27, 2024 • edited Loading

Generated ApiView

weidongxu-microsoft commented Jun 27, 2024

XiaofeiCao commented Jun 27, 2024

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading