EventHub: added $skip and $top to list calls

[v-Ajnava]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2051

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2658

[AutorestCI]

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#53

[AutorestCI]

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1747

[azuresdkciprbot]

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/eventhub/resource-manager/readme.md

⚠️0 new Warnings.(7 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[azuresdkciprbot]

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/eventhub/resource-manager/readme.md

⚠️0 new Warnings.(5 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[jhendrixMSFT]

@v-Ajnava Note that you're introducing breaking changes in a stable spec. Is this intentional?

[v-Ajnava]

@jhendrixMSFT correct me if I am wrong, as these are not the required properties so it will not be breaking change.

[jhendrixMSFT]

@v-Ajnava It depends on the language. For Go these new params are added to the method signature, see https://github.com/Azure/azure-sdk-for-go/blob/19d431608e56bb5b77c3a47a56f04d40c355d962/services/eventhub/mgmt/2017-04-01/eventhub/consumergroups.go#L305 for an example (we have a work item to avoid this problem).

[jhendrixMSFT]

@v-Ajnava Any update?

[v-Ajnava]

@jhendrixMSFT , actually the Service Bus PR is merged with same optional $skip and $top properties.
adding @sazeesha and @dsouzaarun, can you please suggest on this.

[sazeesha]

@jhendrixMSFT, for a collection with query param our service returns max of 100 resources at a time with a nextLink to the next set of resources. For our Clients to function correctly we need to add the optional skip and top query param. For the GO client what is the timeline to fix it?

[jhendrixMSFT]

@sazeesha At present there is no timeline to change the Go codegen for this issue. We won't prevent you from making this change, I just wanted to raise awareness that this is a breaking change for Go (I don't know if it is for any other languages).