Created newer version (2018-06-17-preview) of workbook resource type #2950

ericc1103 · 2018-04-26T02:52:55Z

Added sourceId as an optional parameter.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…specs

This reverts commit bed6bc3.

This reverts commit c245a85.

… we are not using sourceId anymore

… remove unused endpoint

…acted resource type

AutorestCI · 2018-04-26T02:54:08Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2022

AutorestCI · 2018-04-26T02:54:18Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2691

AutorestCI · 2018-04-26T02:54:23Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-04-26T02:55:08Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

azuresdkciprbot · 2018-04-26T02:57:21Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/applicationinsights/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-26T02:57:21Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/applicationinsights/resource-manager/readme.md

⚠️

0 new Warnings.(6 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jianghaolu · 2018-05-03T21:12:47Z

@ericc1103 Sorry for the delay - do you have plans to add the operation for /providers/microsoft.insights/operations?

ericc1103 · 2018-05-07T18:21:29Z

@jianghaolu Could you give me more detail information about /providers/microsoft.insights/operations?

jianghaolu · 2018-05-09T18:52:49Z

Hi @ericc1103 Sorry for the late reply.

You can find more details about the required operation here: https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/openapi-authoring-automated-guidelines.md#r3023-operationsapiimplementation.

AutorestCI · 2018-06-25T21:37:39Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

ericc1103 · 2018-06-25T21:48:48Z

@jianghaolu please review this and let's finalize it. This is also unblock other team since I have other modification to avoid DuplicateModelCollsion error. I fixed this by making a properties field as not required for PATCH operation.

…nition for PATCH operation since location is not required field

ravbhatnagar · 2018-06-27T07:46:36Z

This was reviewed over skype.

ericc1103 · 2018-06-27T16:27:06Z

Thanks Gaurav. @jianghaolu, let's finalize it.
Thanks,
Eric

ericc1103 · 2018-06-28T17:28:16Z

@jianghaolu Ping again...

anuchandy · 2018-07-02T20:13:24Z

@ericc1103 can you ensure these fixes #3324 are ported to this new api-version swagger as well?

Also there seems conflict in the readme file.

ericc1103 · 2018-07-02T22:56:03Z

@anuchandy Applied these fixes #3324 and resolved the merge conflicts.

anuchandy · 2018-07-02T23:02:03Z

...oninsights/resource-manager/Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json

+          "x-ms-mutability": [
+            "create",
+            "read"
+          ]


Can user change the location of workbook resource? if not please remove this property.

@anuchandy Done!

anuchandy · 2018-07-02T23:03:54Z

@ericc1103 thank you, i've a question on location update, please see above comment. Once you address it we are good.

anuchandy · 2018-07-02T23:16:59Z

@ericc1103 actually we need to remove the location property from the update model if location cannot be changed.

anuchandy · 2018-07-02T23:23:36Z

@ericc1103 looks good. One more question - is this API version deployed to production at least in one region?

ericc1103 · 2018-07-02T23:25:32Z

@anuchandy It is deployed to multiple regions as of now.

Thanks!

anuchandy · 2018-07-02T23:26:03Z

thanks @ericc1103 for confirming.

There is an ARMViolation OperationsAPIImplementation but merging this PR as ARM already approved this.

ericc1103 added 19 commits March 29, 2018 14:18

Adding Workbooks resource type.

a892e9f

Rename workbookDelete.json to WorkbookDelete.json

aee9914

Fixed undefiend parameter issue with Delete verb.

4ba66aa

Merge branch 'master' of https://github.com/ericc1103/azure-rest-api-…

e6041b2

…specs

Update swagger to add subscriptionId

6672215

Fixed duplicated operation id issue

92ff8e9

Removed links endpoint

c245a85

Removed unused samples

bed6bc3

Revert "Removed unused samples"

d3bac20

This reverts commit bed6bc3.

Revert "Removed links endpoint"

5259a41

This reverts commit c245a85.

Removed link logic and added get by resourceid

4227f6c

Applied PR comments

328b75c

Added Resource Group parameter for GET. Removed get by sourceId since…

b742198

… we are not using sourceId anymore

Merged with upstream. Modify Workbook Resource Type to include RG and…

15a0dcb

… remove unused endpoint

Resolved the merge conflicts with readme.md

12a3962

Merge remote-tracking branch 'upstream/master'

f78a25b

Remove a location parameter since ARM routes it as we are using an tr…

ebf8df0

…acted resource type

Created newer version (2018-04-01-preview) for workbook resource type.

75c93eb

Merge remote-tracking branch 'upstream/master'

b2613f1

azuresdkci assigned jianghaolu Apr 26, 2018

azuresdkci requested a review from jianghaolu April 26, 2018 02:54

AutorestCI mentioned this pull request Jun 25, 2018

[AutoPR applicationinsights/resource-manager] Created newer version (2018-06-17-preview) of workbook resource type Azure/azure-sdk-for-node#3063

Merged

ericc1103 mentioned this pull request Jun 25, 2018

Add new version for proactive detection config #3224

Closed

ericc1103 added 2 commits June 25, 2018 21:28

Updated Resource properties with the correct fields. Created new defi…

f59f9fe

…nition for PATCH operation since location is not required field

Update readme file

eb74830

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 27, 2018

ericc1103 added 2 commits July 2, 2018 15:47

Uses plural for operation group name

3fcc797

Get the latest version from the upstream and resolved the merge conflict

60eb6f2

anuchandy reviewed Jul 2, 2018

View reviewed changes

anuchandy self-assigned this Jul 2, 2018

Removed x-ms-mutability settings

bd29c56

Removed the location settings for PATCH

46c31d1

anuchandy approved these changes Jul 2, 2018

View reviewed changes

anuchandy merged commit b1674bb into Azure:master Jul 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created newer version (2018-06-17-preview) of workbook resource type #2950

Created newer version (2018-06-17-preview) of workbook resource type #2950

ericc1103 commented Apr 26, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 26, 2018 •

edited

Loading

AutorestCI commented Apr 26, 2018 •

edited

Loading

AutorestCI commented Apr 26, 2018 •

edited

Loading

AutorestCI commented Apr 26, 2018 •

edited

Loading

azuresdkciprbot commented Apr 26, 2018

azuresdkciprbot commented Apr 26, 2018

jianghaolu commented May 3, 2018

ericc1103 commented May 7, 2018

jianghaolu commented May 9, 2018

AutorestCI commented Jun 25, 2018 •

edited

Loading

ericc1103 commented Jun 25, 2018 •

edited

Loading

ravbhatnagar commented Jun 27, 2018

ericc1103 commented Jun 27, 2018

ericc1103 commented Jun 28, 2018

anuchandy commented Jul 2, 2018

ericc1103 commented Jul 2, 2018

anuchandy Jul 2, 2018

ericc1103 Jul 2, 2018

anuchandy commented Jul 2, 2018

anuchandy commented Jul 2, 2018

anuchandy commented Jul 2, 2018

ericc1103 commented Jul 2, 2018

anuchandy commented Jul 2, 2018 •

edited

Loading

Created newer version (2018-06-17-preview) of workbook resource type #2950

Created newer version (2018-06-17-preview) of workbook resource type #2950

Conversation

ericc1103 commented Apr 26, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Apr 26, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 26, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Apr 26, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 26, 2018 • edited Loading

Automation for azure-sdk-for-go

azuresdkciprbot commented Apr 26, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 26, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

jianghaolu commented May 3, 2018

ericc1103 commented May 7, 2018

jianghaolu commented May 9, 2018

AutorestCI commented Jun 25, 2018 • edited Loading

Automation for azure-sdk-for-java

ericc1103 commented Jun 25, 2018 • edited Loading

ravbhatnagar commented Jun 27, 2018

ericc1103 commented Jun 27, 2018

ericc1103 commented Jun 28, 2018

anuchandy commented Jul 2, 2018

ericc1103 commented Jul 2, 2018

anuchandy Jul 2, 2018

Choose a reason for hiding this comment

ericc1103 Jul 2, 2018

Choose a reason for hiding this comment

anuchandy commented Jul 2, 2018

anuchandy commented Jul 2, 2018

anuchandy commented Jul 2, 2018

ericc1103 commented Jul 2, 2018

anuchandy commented Jul 2, 2018 • edited Loading

ericc1103 commented Apr 26, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 26, 2018 •

edited

Loading

AutorestCI commented Apr 26, 2018 •

edited

Loading

AutorestCI commented Apr 26, 2018 •

edited

Loading

AutorestCI commented Apr 26, 2018 •

edited

Loading

AutorestCI commented Jun 25, 2018 •

edited

Loading

ericc1103 commented Jun 25, 2018 •

edited

Loading

anuchandy commented Jul 2, 2018 •

edited

Loading