Microsoft.Kubernetes to add preview version 2024-07-01-preview #29487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.12) | new version | base version |
|---|---|---|
| connectedClusters.json | 2024-07-01-preview(d367735) | 2024-01-01(main) |
| connectedClusters.json | 2024-07-01-preview(d367735) | 2024-06-01-preview(main) |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 2 Errors, 9 Warnings failed [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2024-07-01-preview | package-2024-07-01-preview(d367735) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L932 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L940 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
| Missing identifier id in array item property Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L708 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L881 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L885 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L897 |
||
| Schema should have a description or title. Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L912 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L915 |
||
| Schema should have a description or title. Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L925 |
||
| Missing identifier id in array item property Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L972 |
||
| Missing identifier id in array item property Location: Microsoft.Kubernetes/preview/2024-07-01-preview/connectedClusters.json#L979 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Kubernetes/connectedClusters/{}/listClusterUserCredentials is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hybridkubernetes/resource-manager/readme.md json: Microsoft.Kubernetes/preview/2021-04-01-preview/connectedClusters.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
new-api-version
resource-manager
RPaaS
WaitForARMFeedback
This was referenced Jun 19, 2024
mentat9
reviewed
Jun 22, 2024
| "type": "object", | ||
| "description": "The configuration settings for the feature that do not contain any sensitive or secret information.", | ||
| "x-nullable": true, | ||
| "additionalProperties": { |
There was a problem hiding this comment.
This is an ARM anti-pattern and not generally allowed. Please schematize this object (preferred), or use an array of key value pairs if the properties aren't known ahead of time. If your RP doesn't use or validate these properties at all (i.e. they are just passed through to another API), this pattern is allowed.
There was a problem hiding this comment.
We have separated the values that we are using in our RP by introducing gateway parameter, making it a first class property. The other values that will be sent in 'arcAgentryConfigurations'(additional property) param will just be forwarded to another service as pass through.
mentat9
reviewed
Jun 22, 2024
| "description": "The configuration settings for the feature that contain any sensitive or secret information.", | ||
| "x-nullable": true, | ||
| "x-ms-secret": true, | ||
| "additionalProperties": { |
There was a problem hiding this comment.
replied above.
mentat9
added
the
ARMChangesRequested
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
|
@bavneetsingh16 - Please add the correct template to your PR: #29487 (comment) and fill out the intake form. |
The template generation does not seem to be working for this pr. |
ramoka178
added
WaitForARMFeedback
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.