Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. #29357

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. #29357

merged 2 commits into from
Jun 9, 2024

Conversation

Khushboo-Baheti
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 6, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 6, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
Compared specs (v0.10.9) new version base version
virtualNetworkGateway.json 2024-01-01(39b3a22) 2023-11-01(main)
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-01 package-2024-01(39b3a22) package-2024-01(release-network-Microsoft.Network-2024-01-01)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L37
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L159
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L191
❌ PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L235
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L252
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L325
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L378
❌ ParametersInPost gatewayVip is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L385
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L415
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L442
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L443
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L475
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L496
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L541
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L562
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L607
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L628
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L664
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L685
❌ ParametersInPost peer is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L692
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L728
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L749
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L799
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L835
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L856
❌ ParametersInPost peer is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L863
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L899
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L920
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L959
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L986
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 6, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️❌ azure-sdk-for-net failed [Detail]
  • ❌Code Generator Failed in generating from 15222cdbd6811355714aada16f14b8c6b2e8755f. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
  • ❌Microsoft.Azure.Management.Network [Preview SDK Changes] 
    cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]      1>/home/cloudtest/.nuget/packages/microsoft.internal.netsdkbuild.mgmt.tools/0.12.0-dev.20220216.1/targets/common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/mnt/vss/_work/1/s/azure-sdk-for-net/eng/mgmt.proj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]          /home/cloudtest/.nuget/packages/microsoft.internal.netsdkbuild.mgmt.tools/0.12.0-dev.20220216.1/targets/common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/mnt/vss/_work/1/s/azure-sdk-for-net/eng/mgmt.proj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️⚠️ azure-sdk-for-net-track2 warning [Detail]
  • ⚠️Warning in generating from 15222cdbd6811355714aada16f14b8c6b2e8755f. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • ️✔️Azure.ResourceManager.Network [Preview SDK Changes] 
    info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 15222cdbd6811355714aada16f14b8c6b2e8755f. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-network [Preview SDK Changes]
    • azure_mgmt_network-25.4.0-py3-none-any.whl
    • azure-mgmt-network-25.4.0.zip
    info	[Changelog]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 15222cdbd6811355714aada16f14b8c6b2e8755f. SDK Automation 14.0.0 
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-network-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
    • azure-resourcemanager-network-generated-1.0.0-beta.1.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 15222cdbd6811355714aada16f14b8c6b2e8755f. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes] 
    info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `BastionHostSKUNamePremium` added to enum type `BastionHostSKUName`
info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
info	[Changelog] - New enum type `ConnectionAuthenticationType` with values `ConnectionAuthenticationTypeCertificate`, `ConnectionAuthenticationTypePSK`
info	[Changelog] - New enum type `InboundSecurityRuleType` with values `InboundSecurityRuleTypeAutoExpire`, `InboundSecurityRuleTypePermanent`
info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
info	[Changelog] - New enum type `ProbeNoHealthyBackendsBehavior` with values `ProbeNoHealthyBackendsBehaviorAllProbedDown`, `ProbeNoHealthyBackendsBehaviorAllProbedUp`
info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
info	[Changelog] - New function `*VirtualAppliancesClient.BeginRestart(context.Context, string, string, *VirtualAppliancesClientBeginRestartOptions) (*runtime.Poller[VirtualAppliancesClientRestartResponse], error)`
info	[Changelog] - New struct `CertificateAuthentication`
info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
info	[Changelog] - New struct `FirewallPolicyDraft`
info	[Changelog] - New struct `FirewallPolicyDraftProperties`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
info	[Changelog] - New struct `HeaderValueMatcher`
info	[Changelog] - New struct `PacketCaptureSettings`
info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
info	[Changelog] - New field `EnableSessionRecording` in struct `BastionHostPropertiesFormat`
info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
info	[Changelog] - New field `Identity` in struct `FlowLog`
info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
info	[Changelog] - New field `RuleType` in struct `InboundSecurityRuleProperties`
info	[Changelog] - New field `AppliesOn`, `DestinationPortRanges`, `Name` in struct `InboundSecurityRules`
info	[Changelog] - New field `PrivateIPAddressPrefixLength` in struct `InterfaceIPConfigurationPropertiesFormat`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
info	[Changelog] - New field `NoHealthyBackendsBehavior` in struct `ProbePropertiesFormat`
info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `Identity` in struct `VirtualNetworkGateway`
info	[Changelog] - New field `AuthenticationType`, `CertificateAuthentication` in struct `VirtualNetworkGatewayConnectionPropertiesFormat`
info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 88 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 15222cdbd6811355714aada16f14b8c6b2e8755f. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-network [Preview SDK Changes]
    • azure-arm-network-33.2.0.tgz
    info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group FirewallPolicyDeployments
info	[Changelog]   - Added operation group FirewallPolicyDrafts
info	[Changelog]   - Added operation group FirewallPolicyRuleCollectionGroupDrafts
info	[Changelog]   - Added operation NetworkVirtualAppliances.beginRestart
info	[Changelog]   - Added operation NetworkVirtualAppliances.beginRestartAndWait
info	[Changelog]   - Added Interface CertificateAuthentication
info	[Changelog]   - Added Interface ConnectionMonitorEndpointLocationDetails
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployHeaders
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraft
info	[Changelog]   - Added Interface FirewallPolicyDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsGetOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraft
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsGetOptionalParams
info	[Changelog]   - Added Interface HeaderValueMatcher
info	[Changelog]   - Added Interface NetworkVirtualApplianceInstanceIds
info	[Changelog]   - Added Interface NetworkVirtualAppliancePropertiesFormatNetworkProfile
info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartHeaders
info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartOptionalParams
info	[Changelog]   - Added Interface PacketCaptureSettings
info	[Changelog]   - Added Interface VirtualApplianceIPConfiguration
info	[Changelog]   - Added Interface VirtualApplianceIPConfigurationProperties
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfiguration
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfigurationProperties
info	[Changelog]   - Added Type Alias ApplicationGatewaySkuFamily
info	[Changelog]   - Added Type Alias ConnectionAuthenticationType
info	[Changelog]   - Added Type Alias FirewallPolicyDeploymentsDeployResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsGetResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsGetResponse
info	[Changelog]   - Added Type Alias InboundSecurityRuleType
info	[Changelog]   - Added Type Alias NetworkVirtualAppliancesRestartResponse
info	[Changelog]   - Added Type Alias NicTypeInRequest
info	[Changelog]   - Added Type Alias NicTypeInResponse
info	[Changelog]   - Added Type Alias ProbeNoHealthyBackendsBehavior
info	[Changelog]   - Added Type Alias SharingScope
info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
info	[Changelog]   - Interface ApplicationGatewaySku has a new optional parameter family
info	[Changelog]   - Interface BastionHost has a new optional parameter enableSessionRecording
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter locationDetails
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter subscriptionId
info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter enableDirectPortRateLimit
info	[Changelog]   - Interface FlowLog has a new optional parameter identity
info	[Changelog]   - Interface FlowLogInformation has a new optional parameter identity
info	[Changelog]   - Interface InboundSecurityRule has a new optional parameter ruleType
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter appliesOn
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter destinationPortRanges
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter name
info	[Changelog]   - Interface NetworkInterfaceIPConfiguration has a new optional parameter privateIPAddressPrefixLength
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter networkProfile
info	[Changelog]   - Interface PacketCapture has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCapture has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureStorageLocation has a new optional parameter localPath
info	[Changelog]   - Interface PolicySettings has a new optional parameter jsChallengeCookieExpirationInMins
info	[Changelog]   - Interface Probe has a new optional parameter noHealthyBackendsBehavior
info	[Changelog]   - Interface Subnet has a new optional parameter sharingScope
info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter nicType
info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter identity
info	[Changelog]   - Interface VirtualNetworkGatewayConnection has a new optional parameter authenticationType
info	[Changelog]   - Interface VirtualNetworkGatewayConnection has a new optional parameter certificateAuthentication
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter enableOnlyIPv6Peering
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localSubnetNames
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localVirtualNetworkAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter peerCompleteVnets
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter remoteSubnetNames
info	[Changelog]   - Interface VpnSiteLinkConnection has a new optional parameter dpdTimeoutSeconds
info	[Changelog]   - Added Enum KnownApplicationGatewaySkuFamily
info	[Changelog]   - Added Enum KnownConnectionAuthenticationType
info	[Changelog]   - Added Enum KnownInboundSecurityRuleType
info	[Changelog]   - Added Enum KnownNicTypeInRequest
info	[Changelog]   - Added Enum KnownNicTypeInResponse
info	[Changelog]   - Added Enum KnownProbeNoHealthyBackendsBehavior
info	[Changelog]   - Added Enum KnownSharingScope
info	[Changelog]   - Enum KnownBastionHostSkuName has a new value Premium
info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcNetwork
️❌ azure-resource-manager-schemas failed [Detail]
  • ❌Code Generator Failed in generating from 15222cdbd6811355714aada16f14b8c6b2e8755f. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 15222cdbd6811355714aada16f14b8c6b2e8755f. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.network.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 6, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/network/armnetwork https://apiview.dev/Assemblies/Review/1b263a329090477991c0a7b7b0ae21d7?revisionId=0722043a81354829aceccd45b9e62001
Java azure-resourcemanager-network-generated https://apiview.dev/Assemblies/Review/d496e631581f47bcab5c961219fc2258?revisionId=fed52827e0284c6cb0d1143724513b8c
JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=30ea4e711fd84c13ac1ed83e0a7c8019
Swagger Microsoft.Network https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=ae21c498683847e7b2e2974f8921f2a6

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 6, 2024
This was referenced Jun 6, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 7, 2024
Closed
Closed
@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 9, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 9, 2024
@rkmanda rkmanda merged commit fff6b9a into Azure:release-network-Microsoft.Network-2024-01-01 Jun 9, 2024
26 of 29 checks passed
Khushboo-Baheti added a commit to Khushboo-Baheti/azure-rest-api-specs that referenced this pull request Jun 10, 2024
@Khushboo-Baheti
Fix for PR VirtualNetworkGatewayConnection using key vault for authen…
9386445 
…tication. (Azure#29357)

* Fix

* Fix2

---------

Co-authored-by: Khushboo Baheti <[email protected]>
GuptaVertika pushed a commit that referenced this pull request Jun 10, 2024
@Khushboo-Baheti
Fix for PR VirtualNetworkGatewayConnection using key vault for authen…
fa39bf4 
…tication. (#29357) (#29376)

* Fix

* Fix2

---------

Co-authored-by: Khushboo Baheti <[email protected]>
rkmanda pushed a commit that referenced this pull request Jun 19, 2024
@GuptaVertika @saurabh83
@abhi7860 @arsheen @EugenioPena @daweiwang-microsoft @bhupeshbhatt1985 @bhupeshbhattmicrosoft @ashutmi @Khushboo-Baheti @jianzhao1992 @nimaller
Guptavertika/release network microsoft.network official 2024 01 01 (#…
b48d5d7 
…29302)

* Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01

* Updates readme

* Updates API version in new specs and examples

* Add examples for Subnet peering and v6 Subnet peering. (#28827)

Add examples for Subnet peering and v6 Subnet peering.
---------

Co-authored-by: saurabh83 <[email protected]>

* Init (#29127)

Co-authored-by: Abhishek Shah <[email protected]>

* Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048)

Co-authored-by: Arsheen Khatib (from Dev Box) <[email protected]>

* Added NoHealthyBackendsBehavior (#28868)

Added the property "NoHealthyBackendsBehavior" to the Probe properties.

* VirtualNetworkGatewayConnection using key vault for authentication. (#28760)

* Add parameters for cert based auth connection

* retrigger checks

* retrigger checks

* lintDiff

* Trigger Build

* revert PATCH changes

* fix

* change managed identity to v5

* add format and description

* rresolving conflict

* resolving readme file

* Revert "VirtualNetworkGatewayConnection using key vault for authentication. (#28760)"

This reverts commit c37ec24.

* Lint diff error suppress

* Guptavertika/release network microsoft.network official 2024 01 01 (#29367)

* added networkidentifier under vnet->subet->serviceendpoint

* added format :armid and updated description

* corrected the type

* fixed response

* response type fixed example

---------

Co-authored-by: Bhupesh Bhatt <[email protected]>

* Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339) (#29375)

* Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357) (#29376)

* Fix

* Fix2

---------

Co-authored-by: Khushboo Baheti <[email protected]>

* Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251)

* Add CrossConnection name as an optional query parameter for List CrossConnection

* update example

* Addressing comments

* Change to OData filtering

* Fix the parameter reference

* Update

---------

Co-authored-by: Jianqi Zhao <[email protected]>

* initial changes (#29235)

* Changed type of networkIdentifier from PublicIPAddress to SubResource (#29469)

* added networkidentifier under vnet->subet->serviceendpoint

* added format :armid and updated description

* corrected the type

* fixed response

* response type fixed example

* Changed type of networkIdentifier from ./publicIpAddress.json#/definitions/PublicIPAddress to ./network.json#/definitions/SubResource

---------

Co-authored-by: Bhupesh Bhatt <[email protected]>

---------

Co-authored-by: saurabh83 <[email protected]>
Co-authored-by: saurabh83 <[email protected]>
Co-authored-by: Abhishek Shah <[email protected]>
Co-authored-by: Abhishek Shah <[email protected]>
Co-authored-by: AFK1194 <[email protected]>
Co-authored-by: Arsheen Khatib (from Dev Box) <[email protected]>
Co-authored-by: Eugenio Peña García <[email protected]>
Co-authored-by: daweiwang-microsoft <[email protected]>
Co-authored-by: Bhupesh Kumar Bhatt <[email protected]>
Co-authored-by: Bhupesh Bhatt <[email protected]>
Co-authored-by: Ashutosh Mishra <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: jianzhao1992 <[email protected]>
Co-authored-by: Jianqi Zhao <[email protected]>
Co-authored-by: nimaller <[email protected]>
mentat9 pushed a commit that referenced this pull request Jun 21, 2024
@nikhilpadhye1 @GuptaVertika
@saurabh83 @abhi7860 @arsheen @EugenioPena @daweiwang-microsoft @bhupeshbhatt1985 @Khushboo-Baheti @ashutmi @jianzhao1992 @nimaller
Moving missed changes from 2023-11-01 packet capture swagger fix to l… (
a0ace9e 
#29473)

* Adds base for updating Microsoft.Network from version stable/2023-11-01 to version 2024-01-01

* Updates readme

* Updates API version in new specs and examples

* Add examples for Subnet peering and v6 Subnet peering. (#28827)

Add examples for Subnet peering and v6 Subnet peering.
---------

Co-authored-by: saurabh83 <[email protected]>

* Init (#29127)

Co-authored-by: Abhishek Shah <[email protected]>

* Adding the new response code to the 2024-01-01 version release of swagger to match the bugfix in 2023-11-01 (#29048)

Co-authored-by: Arsheen Khatib (from Dev Box) <[email protected]>

* Added NoHealthyBackendsBehavior (#28868)

Added the property "NoHealthyBackendsBehavior" to the Probe properties.

* VirtualNetworkGatewayConnection using key vault for authentication. (#28760)

* Add parameters for cert based auth connection

* retrigger checks

* retrigger checks

* lintDiff

* Trigger Build

* revert PATCH changes

* fix

* change managed identity to v5

* add format and description

* added networkidentifier under vnet->subet->serviceendpoint (#29292)

* added networkidentifier under vnet->subet->serviceendpoint

* resolving conflict (#29343)

* Fix for PR VirtualNetworkGatewayConnection using key vault for authentication. (#29357)

* Fix

* Fix2

---------

Co-authored-by: Khushboo Baheti <[email protected]>

* Adding GET operaton for Network Virtual Appliance Inbound Secuirty Rule (#29339)

* Moving missed changes from 2023-11-01 packet capture swagger fix to latest api version

* Add CrossConnection Name as an optional query parameter in List ExpressRoute CrossConnection (#29251)

* Add CrossConnection name as an optional query parameter for List CrossConnection

* update example

* Addressing comments

* Change to OData filtering

* Fix the parameter reference

* Update

---------

Co-authored-by: Jianqi Zhao <[email protected]>

* initial changes (#29235)

* adding supression for the breaking change in azure-sdk-for-go

* adding correct package for this supression

---------

Co-authored-by: GuptaVertika <[email protected]>
Co-authored-by: saurabh83 <[email protected]>
Co-authored-by: saurabh83 <[email protected]>
Co-authored-by: Abhishek Shah <[email protected]>
Co-authored-by: Abhishek Shah <[email protected]>
Co-authored-by: AFK1194 <[email protected]>
Co-authored-by: Arsheen Khatib (from Dev Box) <[email protected]>
Co-authored-by: Eugenio Peña García <[email protected]>
Co-authored-by: daweiwang-microsoft <[email protected]>
Co-authored-by: Bhupesh Kumar Bhatt <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: Ashutosh Mishra <[email protected]>
Co-authored-by: jianzhao1992 <[email protected]>
Co-authored-by: Jianqi Zhao <[email protected]>
Co-authored-by: nimaller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkmanda rkmanda rkmanda approved these changes

@Joanna-Yang-Art Joanna-Yang-Art Awaiting requested review from Joanna-Yang-Art

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Khushboo-Baheti @rkmanda @AzureRestAPISpecReview