move common type definition to pick up from latest official typing file #28870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.8) | new version | base version |
|---|---|---|
| capabilities.json | 2024-03-22-preview(68001dc) | 2024-01-01(main) |
| capabilities.json | 2024-03-22-preview(68001dc) | 2023-10-27-preview(main) |
| capabilityTypes.json | 2024-03-22-preview(68001dc) | 2024-01-01(main) |
| capabilityTypes.json | 2024-03-22-preview(68001dc) | 2023-10-27-preview(main) |
| common.json | 2024-03-22-preview(68001dc) | 2024-01-01(main) |
| common.json | 2024-03-22-preview(68001dc) | 2023-10-27-preview(main) |
| privateAccesses.json | 2024-03-22-preview(68001dc) | 2023-10-27-preview(main) |
| targetTypes.json | 2024-03-22-preview(68001dc) | 2024-01-01(main) |
| targetTypes.json | 2024-03-22-preview(68001dc) | 2023-10-27-preview(main) |
| targets.json | 2024-03-22-preview(68001dc) | 2024-01-01(main) |
| targets.json | 2024-03-22-preview(68001dc) | 2023-10-27-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| package-preview-2024-03 | package-preview-2024-03(68001dc) | package-preview-2024-03(MasterRyd3l-chaos-Microsoft.Chaos-2024-03-22-preview) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Apr 26, 2024
This was referenced Apr 26, 2024
brrusino
approved these changes
Apr 29, 2024
MasterRyd3l
merged commit a80f393
into
MasterRyd3l-chaos-Microsoft.Chaos-2024-03-22-preview
27 of 29 checks passed
mentat9
pushed a commit
that referenced
this pull request
May 13, 2024
* Adds base for updating Microsoft.Chaos from version preview/2023-10-27-preview to version 2024-03-22-preview * Updates readme * Updates API version in new specs and examples * merge in 2024-01-01 stable branch additions * Add PublicNetworkAccess Field under privateAccesses resource (#28110) * Add new field for privateAccess * Fix reference * Fix PublicNetworkAccess definition * Fix PrettierCheck * Fix enum name * Rename enum property * Test my push permission * Adds base for updating Microsoft.Chaos from version preview/2023-10-27-preview to version 2024-03-22-preview * Updates readme * Updates API version in new specs and examples * merge in 2024-01-01 stable branch additions * Add PublicNetworkAccess Field under privateAccesses resource (#28110) * Add new field for privateAccess * Fix reference * Fix PublicNetworkAccess definition * Fix PrettierCheck * Fix enum name * Rename enum property * Convert two operations to be async (#28350) * Convert two operations to be async * Fix examples * Resolve comments * Change delete async operation status code * Added Patch Tags Endpoint to Private Link (#28296) * Added UpdatePrivateAccessTags endpoint * Addressing points for the PR review, it was about rename the new private link endpoint to PrivateAccesses_Patch, and changned the return code from 200 to 202 * Update the Private Access tags payload --------- Co-authored-by: Adi Hazeem <[email protected]> * update readme * Resolved conflict * Resolved conflict * Resolved conflict * Fix linting error for PUT and DELETE (#28417) * Fix check error * move readonly flag * Added 200 response to PrivateAccess Tags Patch Endpoint (#28465) * Added 200 response to PrivateAccess Tags example --------- Co-authored-by: Adi Hazeem <[email protected]> * add missing LRO header to open api spec * attempted model validation fix * fixed prop spelling mistake * prettier * remove unused example file * move common type definition to pick up from latest official typing file * move common type definition to pick up from latest official typing file (#28870) Co-authored-by: James Duan <[email protected]> * fix id format in sample file * address review comments from Tim (#28991) Co-authored-by: James Duan <[email protected]> --------- Co-authored-by: James Duan <[email protected]> Co-authored-by: RayY-96 <[email protected]> Co-authored-by: Adi Hazeem <[email protected]> Co-authored-by: Adi Hazeem <[email protected]> Co-authored-by: Brent Rusinow (from Dev Box) <[email protected]>
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
* Adds base for updating Microsoft.Chaos from version preview/2023-10-27-preview to version 2024-03-22-preview * Updates readme * Updates API version in new specs and examples * merge in 2024-01-01 stable branch additions * Add PublicNetworkAccess Field under privateAccesses resource (Azure#28110) * Add new field for privateAccess * Fix reference * Fix PublicNetworkAccess definition * Fix PrettierCheck * Fix enum name * Rename enum property * Test my push permission * Adds base for updating Microsoft.Chaos from version preview/2023-10-27-preview to version 2024-03-22-preview * Updates readme * Updates API version in new specs and examples * merge in 2024-01-01 stable branch additions * Add PublicNetworkAccess Field under privateAccesses resource (Azure#28110) * Add new field for privateAccess * Fix reference * Fix PublicNetworkAccess definition * Fix PrettierCheck * Fix enum name * Rename enum property * Convert two operations to be async (Azure#28350) * Convert two operations to be async * Fix examples * Resolve comments * Change delete async operation status code * Added Patch Tags Endpoint to Private Link (Azure#28296) * Added UpdatePrivateAccessTags endpoint * Addressing points for the PR review, it was about rename the new private link endpoint to PrivateAccesses_Patch, and changned the return code from 200 to 202 * Update the Private Access tags payload --------- Co-authored-by: Adi Hazeem <[email protected]> * update readme * Resolved conflict * Resolved conflict * Resolved conflict * Fix linting error for PUT and DELETE (Azure#28417) * Fix check error * move readonly flag * Added 200 response to PrivateAccess Tags Patch Endpoint (Azure#28465) * Added 200 response to PrivateAccess Tags example --------- Co-authored-by: Adi Hazeem <[email protected]> * add missing LRO header to open api spec * attempted model validation fix * fixed prop spelling mistake * prettier * remove unused example file * move common type definition to pick up from latest official typing file * move common type definition to pick up from latest official typing file (Azure#28870) Co-authored-by: James Duan <[email protected]> * fix id format in sample file * address review comments from Tim (Azure#28991) Co-authored-by: James Duan <[email protected]> --------- Co-authored-by: James Duan <[email protected]> Co-authored-by: RayY-96 <[email protected]> Co-authored-by: Adi Hazeem <[email protected]> Co-authored-by: Adi Hazeem <[email protected]> Co-authored-by: Brent Rusinow (from Dev Box) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates all the v2 common typing to v5