Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualNetworkGatewayConnection using key vault for authentication. #28760

Merged
merged 11 commits into from
May 31, 2024

retrigger checks

5d80145
Select commit
Loading
Failed to load commit list.
Merged

VirtualNetworkGatewayConnection using key vault for authentication. #28760

retrigger checks
5d80145
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff failed Apr 23, 2024 in 16m 27s

Swagger LintDiff failed

LintDiff: 140 Errors, 74 Warnings
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.0) new version base version
package-2024-01 package-2024-01(5d80145) package-2024-01(release-network-Microsoft.Network-2024-01-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/applicationGateway.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/dscpConfiguration.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/loadBalancer.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/networkInterface.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/networkProfile.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/networkSecurityGroup.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/privateEndpoint.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/privateLinkService.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/publicIpAddress.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/routeTable.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/serviceEndpointPolicy.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/virtualNetwork.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/virtualNetworkTap.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/virtualWan.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/webapplicationfirewall.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/5d8014596ac1d1dc3ce0d7954e26edaab06441bf/#L1
❌ PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L235		 RPC-Patch-V1-11


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L37
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L159
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L191
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L252
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L325
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L378
❌ ParametersInPost gatewayVip is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L385
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L415
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L442
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L443
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L475
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L496
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L541
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L562
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L607
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L628
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L664
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L685
❌ ParametersInPost peer is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L692
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L728
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L749
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L799
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L835
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L856
❌ ParametersInPost peer is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L863
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L899
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L920
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L959
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L986
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L987
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1040
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1099
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1138
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1147
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1168
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1207
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1216
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1234
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1350
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1382
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1443
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1470
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1470
❌ ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1471
❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1471
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1538
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1569
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1633
❌ ResourceNameRestriction The resource name parameter 'virtualNetworkGatewayConnectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1633
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/virtualNetworkGateway.json#L1678
View more details on openapi-pipeline-app