Change default deployment for MS team channel to CommercialDeployment #28741

kunsinghms · 2024-04-18T08:56:17Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- This is to fix a small bug for team channel where Team channel Deployment Environment's default value was wrongly written - To fix it has been changed to CommercialDeployment

The change is to solve this issue - https://github.com/Azure/azure-rest-api-specs/issues/28636

This is a one-line change to correct default deployment environment value to correct CommercialDeployment environment value for team channel under Azure Bot Service.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-04-18T08:56:23Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-04-18T08:56:24Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.12)	new version	base version
botservice.json	2023-09-15-preview(91e4f61)	2023-09-15-preview(main)

Rule	Message
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2412:9 Old: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2412:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-preview-2023-09	package-preview-2023-09(91e4f61)	package-preview-2023-09(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` PutRequestResponseSchemeArm	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Bots_Create' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema' Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L31
`❌` PatchResponseCodes	Synchronous PATCH operations must have responses with 200 and default return codes. They also must not have other response codes. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L86
`❌` UnSupportedPatchProperties	Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L104
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:name. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L109
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:displayName. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L109
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:endpoint. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L109
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:msaAppId. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L109
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not have default value, property:publicNetworkAccess. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L109
`❌` ResourceNameRestriction	The resource name parameter 'channelName' should be defined with a 'pattern' restriction. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L304
`❌` RepeatedPathInfo	The 'channelName' already appears in the path, please don't repeat it in the request body. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L335
`❌` PatchResponseCodes	Synchronous PATCH operations must have responses with 200 and default return codes. They also must not have other response codes. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L375
`❌` UnSupportedPatchProperties	Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L405
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:name. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L410
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:channelName. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L410
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not have default value, property:location. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L410
`❌` ResourceNameRestriction	The resource name parameter 'channelName' should be defined with a 'pattern' restriction. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L556
`❌` ResourceNameRestriction	The resource name parameter 'channelName' should be defined with a 'pattern' restriction. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L646
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.BotService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L807
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L808
`❌` ProvisioningStateMustBeReadOnly	provisioningState property must be set to readOnly. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L937
`❌` ProvisioningStateMustBeReadOnly	provisioningState property must be set to readOnly. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L991
`❌` ProvisioningStateMustBeReadOnly	provisioningState property must be set to readOnly. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L997
`❌` PatchResponseCodes	Synchronous PATCH operations must have responses with 200 and default return codes. They also must not have other response codes. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1009
`❌` UnSupportedPatchProperties	Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1030
`❌` UnSupportedPatchProperties	Mark the property 'properties.provisioningState', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1030
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:name. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1034
`❌` ProvisioningStateMustBeReadOnly	provisioningState property must be set to readOnly. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1049
`❌` ProvisioningStateMustBeReadOnly	provisioningState property must be set to readOnly. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1055
`❌` ProvisioningStateMustBeReadOnly	provisioningState property must be set to readOnly. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1098
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1200

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-18T08:56:24Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️🔄 azure-sdk-for-net-track2 inProgress [Detail]

️⚠️ azure-sdk-for-python warning [Detail]

FAQ

⚠️Warning in generating from 6aedd999dd7f0a9f5e0bfd68486d812b21f54dc4. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
cmderr	[automation_init.sh] npm notice
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-botservice [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationsOperations
info	[Changelog]   - Model BotProperties has a new parameter network_security_perimeter_configurations
info	[Changelog]   - Model ConnectionSettingProperties has a new parameter id
info	[Changelog]   - Model ConnectionSettingProperties has a new parameter name

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 6aedd999dd7f0a9f5e0bfd68486d812b21f54dc4. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/botservice/armbotservice [Preview SDK Changes]

️❌ azure-resource-manager-schemas failed [Detail]

FAQ

❌Code Generator Failed in generating from 6aedd999dd7f0a9f5e0bfd68486d812b21f54dc4. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from 6aedd999dd7f0a9f5e0bfd68486d812b21f54dc4. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-botservice [Preview SDK Changes]

️⚠️ azure-powershell warning [Detail]

FAQ

⚠️Warning in generating from 6aedd999dd7f0a9f5e0bfd68486d812b21f54dc4. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.botservice.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-18T08:56:25Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/botservice/armbotservice	https://apiview.dev/Assemblies/Review/27fe64b3ab374f879e7b1cd4ca87b939?revisionId=40138a185fe940839a9ef1de02f96c28
JavaScript	@azure/arm-botservice	https://apiview.dev/Assemblies/Review/ae807e0c52854a808032967bccd5b6da?revisionId=661f9e76d4ff43c880f80d3999561e6c
Swagger	Microsoft.BotService	https://apiview.dev/Assemblies/Review/b1b623986e7b4599ab6ffd63d35dee9d?revisionId=8a8d0c76276c403aa01f6714b8c4abbb

openapi-workflow-bot · 2024-04-18T09:02:43Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

…EnvToCommercialDeployment

openapi-pipeline-app · 2024-06-05T17:19:15Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.9)	new version	base version
botservice.json	2023-09-15-preview(dd41069)	2023-09-15-preview(main)

Rule	Message
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2412:9 Old: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2412:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️⌛CredScan pending [Detail]

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⌛PoliCheck pending [Detail]

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️⌛PR Summary pending [Detail]

️⌛Automated merging requirements met pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

…EnvToCommercialDeployment

@Body

* fix spread for purview datamap and translation document (Azure#29707) * update * update * update * update translation * update * fix ai document translation * fix wrong change and regen * fix * update swagger * update * format * change to use @Body * update * format --------- Co-authored-by: tadelesh <[email protected]> * fix body spread breaking change (Azure#29723) * fix face * fix communication messages * regen swagger * fix casing * rollback face * fix face * fix tsp * add java * fix easm * [communication] Update examples to use string for retry-after (Azure#29739) - Required by autorest schema for examples * [DevOpsInfrastructure] Add ".Management" suffix to TypeSpec folder name (Azure#29737) * move directive to readme.md to avoid unnecessary breaking changes for… (Azure#29742) * move directive to readme.md to avoid unnecessary breaking changes for all languages * update suppressions --------- Co-authored-by: Qiaoqiao Zhang <[email protected]> * Update fields description (Azure#28483) * Microsoft.Fabric - Fix Delete & Update Status Codes. (Azure#29721) * fix status codes and corresponding examples * fix update exmaple * Update mfe.json to fix out of order gen issue (Azure#29634) * [ServiceBus]: Api version 2023-01-01-preview to support data disaster recovery (Azure#29315) * Base commit * New Api Version 2023/01/01/preview * Readme Updated with new version * Failover API with Example * Minor folder correction * Updates * Updates' * Add new API version (2024-06-01), and nxdomainRedirect property to VirtualNetworkLink resource (Azure#29470) * Add nxdomainRedirect property to VirtualNetworkLink resource * Updated readme files and fixed various warnings/errors * Review request for Microsoft.ContainerService/aks to add version stable/2024-05-01 (Azure#29535) * Adds base for updating Microsoft.ContainerService/aks from version stable/2024-02-01 to version 2024-05-01 * Updates readme * Updates API version in new specs and examples * remove osOptions from AKS 2024-05-01 API (Azure#29422) Co-authored-by: Charlie Li <[email protected]> * add SecurityPatch to NodeOsUpgradeChannel (Azure#29468) * Adding Daemonset related flags to May 2024 GA (Azure#29579) * update sdk-suppressions.yaml * Update sdk-suppressions.yaml * Update sdk-suppressions.yaml * add value 'none' for networkPolicy field (Azure#29653) --------- Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Ye Wang [msft] <[email protected]> Co-authored-by: Youn Jae Kim <[email protected]> Co-authored-by: Alancere <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: robogatikov <[email protected]> * Change default deployment for Msteam channel to CommercialDeployment (Azure#28741) * [Monitor] Add .Management suffix to TypeSpec folder name (Azure#29740) * [VerifiedId] Add ".Management" suffix to TypeSpec folder name (Azure#29747) * disable flatten for informatica (Azure#29755) * Update readme.md * Update readme.python.md * Update tspconfig.yaml * Update readme.python.md (Azure#29769) * tsp, BodyParameter, fix a few missing op (Azure#29770) * tsp, loadtesting, remove empty visibility from FileInfo.fileName (Azure#29521) * Enable stream-style-serialization (Azure#29768) * [OpenAI-Assistants] Fixing examples and avocado related CI issues (Azure#29499) * cleaned up config file * reverted name * Restored names and verified example adding behaviour for openapi2 emitter * Added example JSON files and the readme file * Added examples for past releases * Added more documentation to the script * Readme corrections * More readme corrections * Renamed retrieveAssistants examples to getAssistants to match TSP definition * Removed some swagger files * create_assistants json corrections * wip * Get Assistants * WIP * File operations * Files JSON examples * wip * wip * More various fixes * wip * wip * wip * removing bodyRoot decorator * Checking if things are actually fixed * Made expandable nullable enum into 'null' instead of null * Revert "Made expandable nullable enum into 'null' instead of null" This reverts commit 03d2bf5. * WIP * wip * Possible solution to bad @Body usage * Found better solution for version added mismatch createMessage * wip * WIP * Started with vector store stuff * More fixes for vector store stuff * More fixes * Last fixes for vector store batch files * Using string 'null' instread of JSON null * Revert "Using string 'null' instread of JSON null" This reverts commit 39fdbc6. * Corrected operationId * trying out null as a string * Revert "trying out null as a string" This reverts commit ab876a1. * Stringified nulls to make CI happy * Changed the value of instructions for ThreadRun examples. Field not nullable nor optional * Addressing metadata issue * Revert "Stringified nulls to make CI happy" This reverts commit 3dbb723. * Reverting left over stuff * TSP formatter * Prettified JSON * Added suppresion to work around bug * Removed unnecessary example files * Removed convenience scripts * Using bodyRoot again * Revert "Using bodyRoot again" This reverts commit a31f2a0. * Using BodyParameter in createMessage op * The CI seems stuck * [TypeSpec] Upgrade typespec-apiview to 0.4.9 (Azure#29783) * Fix casing of timestamp properties (Azure#29675) * Fix casing of timestamp properties * Fix examples * more examples * property overrides * regen swagger * adding MessageAnalysisCompletedEvent to EG SDk (Azure#28912) * adding MessageAnalysisCompletedEvent to EG SDk * adding event to communication tps * generating spec * generating spec * removing sentiment * removing sentiment * removing sentiment * more changes * addressing comments * updating the analysis events * updating the analysis events * updating the analysis events * Update specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json * tsp format --------- Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: l0lawrence <[email protected]> * Revert "adding MessageAnalysisCompletedEvent to EG SDk (Azure#28912)" (Azure#29789) This reverts commit 0117e47. * Added examples for new api version - 2024-04-05 in GuestConfigurationRP (Azure#29166) * Copy files from stable/2022-01-25 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-05 Updated the API version from stable/2022-01-25 to stable/2024-04-05. * Added tag for 2024-04-05 in readme file * Fixing swagger PrettierCheck * Prettier changes * Add changes for Api * Prettier scan fix * Fixing failing net sdk * Revert of previous change. * java update automation config (Azure#29777) * java update automation config * format * rename property name for python sdk (Azure#29793) * [Oracle Database@Azure] Add new preview and stable API versions for 2024-06-01 (Azure#29585) * add new preview and stable API versions * remove unnecessary add decorator * re-compile after merging with main --------- Co-authored-by: zhuoyun wang <[email protected]> * [vmware] Add ".Management" suffix to TypeSpec folder name (Azure#29748) * [Informatica.DataManagement] Add .Management suffix to TypeSpec folder name (Azure#29738) * Fix acronym casing (Azure#29797) * Fix acronym casing * tsp format * Add Typespec conversion option to intake template (Azure#29616) * Add Typespec converstion option to intake template Intake form needs an option to indicate the author is converting swagger to Typespec. This change adds a checkbox for that option and indicates it should not be combined with adding a new API version. * Update control_plane_template.md Update text and add link to TypeSpec conversion docs per feedback. * Update control_plane_template.md * Update control_plane_template.md Update help link for TypeSpec conversion --------- Co-authored-by: Konrad Jamrozik <[email protected]> * Update powerbidedicated.json (Azure#29322) Updated based on this doc bug: https://dev.azure.com/msft-skilling/Content/_workitems/edit/154565 * Add tsp-client to root package.json (Azure#29803) - Allows devs to run `npx tsp-client` after `npm ci`, with no additional installs - Pins versions of `tsp-client` and its deps in the root package-lock.json - Fixes Azure#29686 * Add 2024-05-15-preview of SpeechToText API (CognitiveServices) (Azure#29804) * Add preview GA as base * Updates for new preview version * Update readme.md * Added required ttl to examples * Add description * Add missing example * Keep latest GA latest * [tsp-client] Add acceptance tests (Azure#29811) * Make union types required in 2024 service version (Azure#29832) * Make union types required in 2024 service version * pass api version * Fixes * Add examples directory * Update readme to point to new swagger * Add Generated tag * Exclude whatsapp * [tsp-client] Upgrade to 0.9.3 (Azure#29837) - Adds autorest and plugins as dependencies - Runs the packages from their install folders, to guarantee the versions don't change after install * remove-track2-for-python (Azure#29814) * java mgmt, dataprotection, hide auth headers (Azure#29838) java mgmt, dataprotection, hide auth headers * update compute typescript.md (Azure#24529) * update compute typescript.md * Update sdk-suppressions.yaml --------- Co-authored-by: Qiaoqiao Zhang <[email protected]> * easm, java sdk, tspconfig api-version=2023-03-01-preview, fix 1 BodyParameter (Azure#29839) * easm, java sdk, tspconfig api-version 2023-03-01-preview * BodyParameter * [Oracle.Database] Add .Management suffix to TypeSpec folder name (Azure#29746) * Add stub `specs-model` tool (Azure#29820) * (squashed) Add stub specs-model tool Co-authored-by: Mike Harder <[email protected]> * Fix operation id (Azure#29840) * [TypeSpecValidation] Enforce ".Management" suffix (Azure#29663) - Fixes Azure#29654 * [tsp-client] Only run test action for PRs targeting main (Azure#29843) - Only branch guaranteed to have specs used for testing * Compute: DiskRP 2024-03-02 version (Azure#29399) * Create new version folder by copying last version * update version references * update readme.md * Consolidated DiskRP swagger changes for api version 2024-03-02 (Azure#29602) * Update diskRestorePoint.json with logicalSectorSize property under "DiskRestorePointProperties" * Update DiskRestorePoint_Get.json with logicalSectorSize property * Update DiskRestorePoint_Get_WhenSourceResourceIsFromDifferentRegion.json with logicalSectorSize property * Update DiskRestorePoint_ListByVmRestorePoint.json with logicalSectorSize property * Updated diskRestorePoint.json to add format. * update default readme tag * update version references in examples --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: kbaibhavgithub <[email protected]> * fix example api version (Azure#29525) Co-authored-by: Alon Pelled <[email protected]> * [NetAppFiles] Release netapp microsoft.net app 2024 03 01 preview (Azure#29682) * Copy files from preview/2023-11-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-03-01-preview Updated the API version from preview/2023-11-01-preview to preview/2024-03-01-preview. * Added tag for 2024-03-01-preview in readme file * update api-version 2023-03-01-preview * Spelling and location header * Spelling * arm-id missing * arm-id missing * multiple in description * api-version in example * api-version in example * external replication descriptions * Remove Get GlobalCommunicationsSite API from Orbital AODG APIs (Azure#29716) * Remove Get GlobalCommunicationsSite API from Orbital AODG Apis since it utilized unsupported ARM function resulting in an error * remove examples for apis * [EG] update utc datetime to optional (Azure#29762) * update utc datetime to optional * missed one * use madeRequired * add examples * update * remove * rebase * [suppressions] Add end-to-end tests (Azure#29858) * Refactor Batch TypeSpec to be standardized (Azure#29252) * Refactor client and routes tsp to be standardized * Fixed refactoring * Renamed example files for clarity and consistency * Update operationsIds in all examples to be correct * Fixed interface name * Regenerate swagger and examples * Fix spelling error in client * Format client tsp file * Add BatchNodeReimageContent model back * Pluralize interface names and tags * Fix pluralization mistakes * Group overrides by language * Refactor Java client name overrides * Correctly format TypeSpec * Rename client interface from Batch to BatchClient * Add OperationIdNounVerb suppression * Fix minor spelling error * tsp, openai-assistants, refactor BodyParameter (Azure#29749) * tsp, openai, refactor BodyParameter (Azure#29743) * Initial Creation of Azure.Health.Deidentification Dataplane API Typespec (Azure#29745) * Updates HealthDataAiService.Deid with feedback from SDK Review Team (Azure#29036) * Generate new Service for deidentification * [data-plane] Initial Creation of HealthDataAiServices.Deid 2 (Azure#27563) Initial Creation of HealthDataAIServices Deid Service Spec. --------- Co-authored-by: Graham Thomas <[email protected]> * Adds errorCode and explanation; Replaces pagination with continuationToken (Azure#28061) * Adds errorCode and explanation; Replaces pagination with continuationToken * Updates to use standard Azure Foundation Error --------- Co-authored-by: Graham Thomas <[email protected]> * Updated CompletedAt to LastUpdatedAt for all terminal states (Azure#28349) * Updated CompletedAt to LastUpdatedAt for all terminal states * Updates examples; Moves error order * Set examples to more realistic value * Updates File model for future expansion * Adds Input FileLocation --------- Co-authored-by: Graham Thomas <[email protected]> * Updates parameter validators/defaults/nullability; Replaces checksum with etag (Azure#28528) * Updates minor tweaks * Updates examples --------- Co-authored-by: Graham Thomas <[email protected]> * Updates HealthDataAiService.Deid with feedback from SDK Review Team * Updates TSPconfig for c# * Adds CSharp special * Updates version to match live version * Updates java package name * Fix java namespace name * Updates python package name * Updates to match version service is currently using * Updates package names * Removes update in cspell * Updates java namespace * Fixes cspell.json * Test1 * Convert to diff long running operation * Adds client config * Attempt base LRO * Updated naming and LRO config * Stash merge * Linter fixes; SDK related Updates * SDK Related Updates * Changes ordering of parameters; Fixes StringIndexType enum values * Removes script update * Updates examples * Don't update vscode settings * Updates examples * Fixes linter issues * Fixes documentDataType enum value to match casing within service * fix documentDataType enum value * change name of js package * changing property continuationToken because of a conflict in java * revert changes for continuationToken * Adding post processing for java --------- Co-authored-by: Graham Thomas <[email protected]> Co-authored-by: Daniel Szaniszlo <[email protected]> * Updates linter extends value * Updates typespec with new validations for 0.57 * Fixing namespace suppression * Fixing namespace suppression 2 * Fixing namespace suppression 3 * Fixing namespace suppression 4 * Fixes formatting * Updates how StringIndices are handled * Update docstring to contain languages * Makes etag optional for PhiTaggerResult on realtime requests * Removes redundant read decorator on etag * Regenerates with new docs * Fixes formatting * Removes @secret on location * Team review updates * Renames folder to match namespace change * Updates client name after namespace change * Makes fields with defaults optional --------- Co-authored-by: Graham Thomas <[email protected]> Co-authored-by: Daniel Szaniszlo <[email protected]> * Review request for Microsoft.ContainerService/aks to add version preview/2024-05-02-preview (Azure#29774) * Adds base for updating Microsoft.ContainerService/aks from version preview/2024-04-02-preview to version 2024-05-02-preview * Updates readme * Updates API version in new specs and examples * remove osOptions from AKS 2024-05-02-preview API (Azure#29421) Co-authored-by: Charlie Li <[email protected]> * fix ComponentsByRelease (Azure#29426) * fix definition of ComponentsByRelease * add x-ms-identifiers * update securityPatch description (Azure#29530) --------- Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Shaoru Hu <[email protected]> Co-authored-by: Ye Wang [msft] <[email protected]> * [OpenAI] Added missing GA service versions, 2024-02-01 and 2024-06-01 (Azure#29424) * added a missing GA service version * add the generated.json 2024-02-01 but looks different to inference.json * add the 2024-06-01 service API version * remove self introudced new generated.json from 2024-02-01 * added operation id * Update specification/ai/Face/tspconfig.yaml * Ran npx tsv command * copied from previous examples * added generated swagger version into readme * fixed "Missing required property: deployment-id" * run tsp compile * generated.json with generated_ prefix json file. * revert the data-plane changes for inference.json * add generated.json updates * suppress spellcheck failures --------- Co-authored-by: Jose Alvarez <[email protected]> * [Batch] Switch contentLength from int64 to string (Azure#29656) This is a breaking change, but accurately reflects what the Batch service has always returned for this property. * rerun npx tsv specification/cognitiveservices/OpenAI.Inference (Azure#29872) * Upgrade to TypeSpec 0.58 (Azure#29863) * Update PR templates: fix typo in hyperlink (Azure#29876) * Update data_plane_template.md: fix typo in hyperlink * Update control_plane_template.md * Remove unused customization-class from tspconfig (Azure#29873) * Update readme.python.md (Azure#29881) * Update readme.python.md * Update readme.python.md * update --------- Co-authored-by: msyyc <[email protected]> * Update readme.python.md (Azure#29886) * Remove unsupported If-Match header value for Blob Immutability Policy operations (Azure#29632) * Remove references to unsupported If-Match header value * Update description * Update etag description * Update description with double quotes * Microsoft.HealthDataAIServices: New API version 2024-02-28-preview (Azure#29659) * adding spec * update tsp * update * fix * validation * fix structure * fix readme swagger path * fix lintdiff error * fix provisioningState readonly * fix example * add java readme * Update tspconfig.yaml * add emitters * add azure-sdk-for-net-track2 * remove .net from tspconfig * Update specification/healthdataaiservices/resource-manager/Microsoft.HealthDataAIServices/readme.md * move readmes * fix swagger path * add .net to tspconfig * update readme * fix * remove net track 1 * update python config --------- Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Add listRegistrationToken endpoint to latest stable and preview versions (Azure#29676) * add listRegistrationToken endpoint to latest stable and preview versions * typo * update example to have correct resourceId format * resolve comments * use x-ms-secret * rename registrationInfoList * rename registrationInfoMinimalg * [DataFactory]Support ‘domain’ Property In Dynamics Family (Azure#29709) * Support ‘domain’ Property In Dynamics Family * add * Tag Updated (Azure#29775) * Fix HealthDataAiService (Azure#29909) * Update readme.python.md (Azure#29888) * Remove VM image that no longer functions (Azure#29870) * Remove useref and Fleet update changes (Azure#29493) * Remove useref and Fleet update changes * Remove useref * fix spell check * Fix validation errors * suppress casing errors * Fix formatting * Refactor * Remove Fleet Forbidden values * Add additional property suppression. * edit suppressions * Add Suppression for camel casing * Make confidential fields to have create and update visibility only. * update docs * remove format decorator and use url type * Address comments * revert settings change as it is visible. * Address comments * configReference is visible in response. * Add arm-id format to resource ids * Address comments * update provisioningState in examples * update examples * Update location in examples * Update example * Update security posture reference to the latest compute api version. * Fix merge conflicts * Update and add more examples --------- Co-authored-by: Sahil Arora <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Support MI Auth for Azure Table (Azure#29702) * support mi auth for azure table connector * add synapse changes * update sdk-suppressions.yaml --------- Co-authored-by: Alancere <[email protected]> * Update specificationRepositoryConfiguration.json (Azure#29926) There is no need to keep `-track2` since all the Python SDK is already track2 SDK now. * Update GenerateOutputSchema.json (Azure#29865) * Update GenerateOutputSchema.json Sync the schema with the latest code. * Cognitive Services 2024-06-01-preview (Azure#29228) * Copy files from preview/2024-04-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-06-01-preview Updated the API version from preview/2024-04-01-preview to preview/2024-06-01-preview. * Added tag for 2024-06-01-preview in readme file * RAI API changes * fix check errors * fix old versions RAI content filters * Revert "fix old versions RAI content filters" This reverts commit 9d3087f. * Add "description" * Add CalculateModelCapacity API * fix Swagger LintDiff * fix * reverted changes of old API version * address comments * fix lint error * Updated ModelCapacityCalculatorWorkload * Address comments * fix Mode Validation * fix linter * address comments * fix swagger lint errors * Adding SCVMM API Version 2024-06-01 (Azure#29568) * Base commit. Adding copy of the existing api version * Updating readme.md * Updating main.tsp and models.tsp * Updating scvmm.json * Updating examples for api version 2024-06-01 * Resolving Comments. Adding privatelinkscoperesourceid in get and list and update osprofilepropeties in virtualmachine instance get and list. * Making productKey a secret. * addding missing examples (Azure#29753) * tspconfig, java, eventgrid, exclude preview from ServiceVersion (Azure#29928) * exclude preview in eventgrid * remove namer * Review request for Microsoft.DocumentDB to modify description of burst capacity feature (Azure#29892) * modified description of burst capacity feature * added keyvaultkeyuri to cSpell --------- Co-authored-by: Venu Sivanadham <[email protected]> * Swagger changes to support Vertica V2 in ADF (Azure#29652) * support Vertica V2 in ADF * Update LinkedService.json in synapse * updating password * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Support MI Auth for Azure File (Azure#29779) Co-authored-by: Shenwang Zeng <[email protected]> Co-authored-by: Razvan Badea <[email protected]> * Move Computeschedule from private to public preview (Azure#29660) * initial commit to clone computeschedule to public repo * changes to fix merge requirement errors * change to address spellcheck * added rpaas to the readme file to meet the RP quality checklist for rpaas RPs * made changes to address comments * address validation failure * changes to address validation of armid errors * made changes to address guid validation errors * removed older versions * added more example files to match private preview * trigger re-run of checks --------- Co-authored-by: Razvan Badea <[email protected]> * fix fleet pageable operation (Azure#29939) * [NetApp] Release netapp microsoft.net app 2024 03 01 (Azure#29725) * Copy files from stable/2023-11-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-03-01 Updated the API version from stable/2023-11-01 to stable/2024-03-01. * Added tag for 2024-03-01 in readme file * update specs * arm-id missing * api-version in example, desciption update * merge fix * usageThreshold min in patch to match put * update readme * swagger lintdiff * swagger lintdiff * update readme --------- Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: tadelesh <[email protected]> Co-authored-by: Nate Kimball <[email protected]> Co-authored-by: Mike Harder <[email protected]> Co-authored-by: ZiWei Chen <[email protected]> Co-authored-by: Qiaoqiao Zhang <[email protected]> Co-authored-by: Pamela Fox <[email protected]> Co-authored-by: Badea Marjieh <[email protected]> Co-authored-by: ragovada <[email protected]> Co-authored-by: schaudhari6254888 <[email protected]> Co-authored-by: Pranav Nair <[email protected]> Co-authored-by: FumingZhang <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Ye Wang [msft] <[email protected]> Co-authored-by: Youn Jae Kim <[email protected]> Co-authored-by: Alancere <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: robogatikov <[email protected]> Co-authored-by: Kunal K Singh <[email protected]> Co-authored-by: ChenxiJiang333 <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Shawn Fang <[email protected]> Co-authored-by: Jose Alvarez <[email protected]> Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: Osahumen Uyi Aghasomwan <[email protected]> Co-authored-by: l0lawrence <[email protected]> Co-authored-by: ameyaiam3 <[email protected]> Co-authored-by: Xiaofei Cao <[email protected]> Co-authored-by: zhuoyunwang <[email protected]> Co-authored-by: zhuoyun wang <[email protected]> Co-authored-by: Chris Stackhouse <[email protected]> Co-authored-by: Konrad Jamrozik <[email protected]> Co-authored-by: Kesem Sharabi <[email protected]> Co-authored-by: Ralf Beckers <[email protected]> Co-authored-by: Hong Li(MSFT) <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: kbaibhavgithub <[email protected]> Co-authored-by: alonzop <[email protected]> Co-authored-by: Alon Pelled <[email protected]> Co-authored-by: Auðunn <[email protected]> Co-authored-by: Nathan M Kennedy <[email protected]> Co-authored-by: Sanjana Kapur <[email protected]> Co-authored-by: Graham Thomas <[email protected]> Co-authored-by: Graham Thomas <[email protected]> Co-authored-by: Daniel Szaniszlo <[email protected]> Co-authored-by: Shaoru Hu <[email protected]> Co-authored-by: Jose Alvarez <[email protected]> Co-authored-by: David Watrous <[email protected]> Co-authored-by: Timothee Guerin <[email protected]> Co-authored-by: danielszaniszlo <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: asmahmoo <[email protected]> Co-authored-by: ryanosh <[email protected]> Co-authored-by: Jingshu918 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Adam Sandor <[email protected]> Co-authored-by: Sahil Arora <[email protected]> Co-authored-by: Sahil Arora <[email protected]> Co-authored-by: Yao Kou <[email protected]> Co-authored-by: tianxinliu <[email protected]> Co-authored-by: Kartik Verma <[email protected]> Co-authored-by: kanil4664 <[email protected]> Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: Venu Sivanadham <[email protected]> Co-authored-by: ms-kanikagupta <[email protected]> Co-authored-by: 触动心灵 <[email protected]> Co-authored-by: Shenwang Zeng <[email protected]> Co-authored-by: Razvan Badea <[email protected]> Co-authored-by: Nneka Okeke <[email protected]>

Change default deployment for Msteam channel to CommercialDeployment

8d22cb4

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 18, 2024

azure-sdk mentioned this pull request Apr 18, 2024

[AutoPR sdk/resourcemanager/botservice/armbotservice] Change default deployment for MS team channel to CommercialDeployment azure-sdk/azure-sdk-for-go#9660

Closed

AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Apr 18, 2024

JeffreyRichter added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Jun 5, 2024

Merge branch 'main' into Users/kunsingh/ChangeMsTeamChannelDeployment…

dd41069

…EnvToCommercialDeployment

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jun 5, 2024

Merge branch 'main' into Users/kunsingh/ChangeMsTeamChannelDeployment…

1b04b4f

…EnvToCommercialDeployment

kunsinghms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 13, 2024

openapi-pipeline-app bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jun 13, 2024

TimLovellSmith enabled auto-merge (squash) July 3, 2024 18:34

Merge branch 'main' into Users/kunsingh/ChangeMsTeamChannelDeployment…

04ddc7c

…EnvToCommercialDeployment

Merge branch 'main' into Users/kunsingh/ChangeMsTeamChannelDeployment…

91e4f61

…EnvToCommercialDeployment

madhura-np approved these changes Jul 9, 2024

View reviewed changes

TimLovellSmith merged commit 3b1151d into Azure:main Jul 9, 2024
28 of 31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change default deployment for MS team channel to CommercialDeployment #28741

Change default deployment for MS team channel to CommercialDeployment #28741

kunsinghms commented Apr 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2024 •

edited

Loading

openapi-workflow-bot bot commented Apr 18, 2024

openapi-pipeline-app bot commented Jun 5, 2024

Change default deployment for MS team channel to CommercialDeployment #28741

Change default deployment for MS team channel to CommercialDeployment #28741

Conversation

kunsinghms commented Apr 18, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Apr 18, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Apr 18, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 18, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Apr 18, 2024 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Apr 18, 2024

openapi-pipeline-app bot commented Jun 5, 2024

Swagger Validation Report

kunsinghms commented Apr 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Apr 18, 2024 •

edited

Loading