NSP RP changes for public preview #28552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| package-preview-2024-05 | package-preview-2024-05(51eed40) | package-preview-2024-05(release-cosmos-db-Microsoft.DocumentDB-2024-05-15-preview) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L19 |
RPC-Get-V1-11 | |
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: NamspaceNetworkSecurityPerimeterConfigurationList Location: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L70 |
||
| Use the latest version v5 of types.json. Location: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L168 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L234 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L258 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L306 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L352 |
||
Property location must have 'x-ms-mutability':['read', 'create'] extension defined.Location: Microsoft.DocumentDB/preview/2024-05-15-preview/networkSecurityPerimeter.json#L426 |
RPC-Put-V1-14 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Apr 1, 2024
Closed
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
This was referenced Apr 2, 2024
Closed
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Please use the proper template to create the PR and fill out required information. Please follow the PR review workflow. Please also fix the following failures: |
gary-x-li
added
the
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
pjohari-ms
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
pjohari-ms
approved these changes
Apr 15, 2024
pjohari-ms
merged commit 379095a
into
Azure:release-cosmos-db-Microsoft.DocumentDB-2024-05-15-preview
28 of 29 checks passed
pjohari-ms
added a commit
that referenced
this pull request
May 21, 2024
* NSP RP API changes * small change * validation failures handling * linter errors * types version * still failing * Probably all the fixes * Missed one file * Will revert this commit - temp fix for hanging push * Reverted commit --------- Co-authored-by: pjohari-ms <[email protected]>
razvanbadea-msft
pushed a commit
that referenced
this pull request
May 22, 2024
#29192) * Copy files from preview/2024-02-15-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-05-15-preview Updated the API version from preview/2024-02-15-preview to preview/2024-05-15-preview. * Added tag for 2024-05-15-preview in readme file * Add mongo v5 and v6 to the preview swagger (#28472) Co-authored-by: Andrew Khoma <[email protected]> * swagger changes for capacityMode changes (#28457) * swagger changes for capacityMode changes * Ran the npx Prettier command * fixing swagger lint * fixing camelcase issue * NSP RP changes for public preview (#28552) * NSP RP API changes * small change * validation failures handling * linter errors * types version * still failing * Probably all the fixes * Missed one file * Will revert this commit - temp fix for hanging push * Reverted commit --------- Co-authored-by: pjohari-ms <[email protected]> * Remove mongoCluster swagger spec and examples for 2024-05-15-preview release (#28693) * Porting from stable changes from Cassandra API (#28801) * nsp related comments (#28950) * Review comments - Cassandra and circular reference (#29021) * Review comments - Cassandra and circular reference * Nits - Services.json * Porting from stable brranch * Nits * Moved files * Using common types * Fixes * Used custom parameter - as suggested by reviewer * Merged commit correctly * Another merge remove issue * Prettier issues due to line endings being different during merge * Prettier check. Whole folder. --------- Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: chandrasekhar gunturi <[email protected]> Co-authored-by: Vandit Jain <[email protected]> Co-authored-by: Oliver Towers <[email protected]>
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
Azure#29192) * Copy files from preview/2024-02-15-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-05-15-preview Updated the API version from preview/2024-02-15-preview to preview/2024-05-15-preview. * Added tag for 2024-05-15-preview in readme file * Add mongo v5 and v6 to the preview swagger (Azure#28472) Co-authored-by: Andrew Khoma <[email protected]> * swagger changes for capacityMode changes (Azure#28457) * swagger changes for capacityMode changes * Ran the npx Prettier command * fixing swagger lint * fixing camelcase issue * NSP RP changes for public preview (Azure#28552) * NSP RP API changes * small change * validation failures handling * linter errors * types version * still failing * Probably all the fixes * Missed one file * Will revert this commit - temp fix for hanging push * Reverted commit --------- Co-authored-by: pjohari-ms <[email protected]> * Remove mongoCluster swagger spec and examples for 2024-05-15-preview release (Azure#28693) * Porting from stable changes from Cassandra API (Azure#28801) * nsp related comments (Azure#28950) * Review comments - Cassandra and circular reference (Azure#29021) * Review comments - Cassandra and circular reference * Nits - Services.json * Porting from stable brranch * Nits * Moved files * Using common types * Fixes * Used custom parameter - as suggested by reviewer * Merged commit correctly * Another merge remove issue * Prettier issues due to line endings being different during merge * Prettier check. Whole folder. --------- Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: Andrew Khoma <[email protected]> Co-authored-by: chandrasekhar gunturi <[email protected]> Co-authored-by: Vandit Jain <[email protected]> Co-authored-by: Oliver Towers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.