Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CosmosDB-MICassandra] Added VPN feature properties to stable #28540

Merged
merged 3 commits into from
Apr 23, 2024
Merged

[CosmosDB-MICassandra] Added VPN feature properties to stable #28540

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9e6fa1
Added VPN feature properties
DrewKaufmann Mar 31, 2024
518ea99
Fixed SpellCheck violation and added arm-id format to privateLinkReso…
DrewKaufmann Apr 17, 2024
32c52d5
Added arm-id-details to privateLinkResourceId
DrewKaufmann Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions ...n/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2024-05-15/managedCassandra.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,31 @@
"provisionError": {
"$ref": "#/definitions/CassandraError",
"description": "Error related to resource provisioning."
},
"azureConnectionMethod": {
"type": "string",
"description": "How to connect to the azure services needed for running the cluster",
"enum": [
"None",
"VPN"
],
"x-ms-enum": {
"name": "AzureConnectionType",
"modelAsString": true
}
},
"privateLinkResourceId": {
"readOnly": true,
"type": "string",
"format": "arm-id",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.Network/privateLinkServices"
}
]
},
"description": "If the Connection Method is Vpn, this is the Id of the private link resource that the datacenters need to connect to."
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format : "arm-id".

https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont you need to include the allowed resources to restrict it to privae links ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guanzhousongmicrosoft @DrewKaufmann can you take a look at this suggestion as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by @DrewKaufmann. Resolving conversation.

}
}
Expand Down Expand Up @@ -1346,6 +1371,10 @@
"provisionError": {
"$ref": "#/definitions/CassandraError",
"description": "Error related to resource provisioning."
},
"privateEndpointIpAddress": {
"type": "string",
"description": "Ip of the VPN Endpoint for this data center."
}
}
}
Expand Down