Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ScriptActivityScriptBlock Type Property To Support Parameterization… #28538

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Change ScriptActivityScriptBlock Type Property To Support Parameterization… #28538

merged 6 commits into from
Apr 15, 2024

Conversation

Jingshu918
Copy link
Contributor

@Jingshu918 Jingshu918 commented Apr 1, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Apr 1, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Apr 1, 2024

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.7) new version base version
Pipeline.json 2018-06-01(1871286) 2018-06-01(main)
Pipeline.json 2020-12-01(1871286) 2020-12-01(main)
Rule Message
1026 - TypeChanged The new version has a different type 'object' than the previous one 'string'.
New: stable/2018-06-01/entityTypes/Pipeline.json#L8525:9
Old: stable/2018-06-01/entityTypes/Pipeline.json#L8525:9
1026 - TypeChanged The new version has a different type 'object' than the previous one 'string'.
New: stable/2020-12-01/entityTypes/Pipeline.json#L7533:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L7533:9
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
New: stable/2018-06-01/entityTypes/Pipeline.json#L8525:9
Old: stable/2018-06-01/entityTypes/Pipeline.json#L8525:9
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
New: stable/2020-12-01/entityTypes/Pipeline.json#L7533:9
Old: stable/2020-12-01/entityTypes/Pipeline.json#L7533:9
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

Hi @Jingshu918, this service has enabled ShiftLeft Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it is intentional or reject it if it is not expected. Normally, all the specification or example changes should start with PR created in ADO.

  • You can refer to ShiftLeft Toolset Introduction for details.
  • Please contact service focal contacts or ShiftLeft Toolset Support Channel if need further help.
  • Copy link

    openapi-pipeline-app bot commented Apr 1, 2024

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed in generating from 98bb783b08ee932174210602e4bf3505fab9a146. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mCannot find path�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1mit does not exist.�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact�[0m
    • Azure.ResourceManager.DataFactory [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning in generating from 98bb783b08ee932174210602e4bf3505fab9a146. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️azure-mgmt-datafactory [Preview SDK Changes] Breaking Change Detected
      • azure-mgmt-datafactory-1.0.0.zip
      • azure_mgmt_datafactory-1.0.0-py3-none-any.whl
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model ManagedIdentityCredential no longer has parameter resource_id
      Present SDK breaking changes suppressions
      Model ManagedIdentityCredential no longer has parameter resource_id
      Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning in generating from 98bb783b08ee932174210602e4bf3505fab9a146. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-datafactory [Preview SDK Changes]
      • pom.xml
      • azure-resourcemanager-datafactory-1.0.0-beta.28-sources.jar
      • azure-resourcemanager-datafactory-1.0.0-beta.28.jar
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded in generating from 98bb783b08ee932174210602e4bf3505fab9a146. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-go not found in swagger-to-sdk
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/datafactory/armdatafactory [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*CredentialOperationsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, ManagedIdentityCredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, CredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)`
      info	[Changelog] - Type of `AzureFunctionActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
      info	[Changelog] - Type of `CredentialListResponse.Value` has been changed from `[]*ManagedIdentityCredentialResource` to `[]*CredentialResource`
      info	[Changelog] - Type of `WebActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
      info	[Changelog] - Type of `WebHookActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
      info	[Changelog] - Enum `ScriptType` has been removed
      info	[Changelog] - Struct `ManagedIdentityCredentialResource` has been removed
      info	[Changelog] - Struct `ManagedIdentityTypeProperties` has been removed
      info	[Changelog] - Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientCreateOrUpdateResponse` has been removed
      info	[Changelog] - Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientGetResponse` has been removed
      info	[Changelog] - Field `TypeProperties` of struct `ManagedIdentityCredential` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - Type of `ScriptActivityScriptBlock.Type` has been changed from `*ScriptType` to `any`
      info	[Changelog] - New struct `CredentialResource`
      info	[Changelog] - New anonymous field `CredentialResource` in struct `CredentialOperationsClientCreateOrUpdateResponse`
      info	[Changelog] - New anonymous field `CredentialResource` in struct `CredentialOperationsClientGetResponse`
      info	[Changelog]
      info	[Changelog] Total 14 breaking change(s), 4 additive change(s).
      Present SDK breaking changes suppressions
      Enum `ScriptType` has been removed
      Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientCreateOrUpdateResponse` has been removed
      Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientGetResponse` has been removed
      Field `TypeProperties` of struct `ManagedIdentityCredential` has been removed
      Function `*CredentialOperationsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, ManagedIdentityCredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, CredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)`
      Struct `ManagedIdentityCredentialResource` has been removed
      Struct `ManagedIdentityTypeProperties` has been removed
      Type of `AzureFunctionActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
      Type of `CredentialListResponse.Value` has been changed from `[]*ManagedIdentityCredentialResource` to `[]*CredentialResource`
      Type of `WebActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
      Type of `WebHookActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
      Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded in generating from 98bb783b08ee932174210602e4bf3505fab9a146. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-datafactory [Preview SDK Changes] Breaking Change Detected
      • azure-arm-datafactory-15.0.0.tgz
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface ServicePrincipalCredentialResource
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Operation CredentialOperations.createOrUpdate has a new signature
      info	[Changelog]   - Interface ManagedIdentityCredential no longer has parameter resourceId
      info	[Changelog]   - Type of parameter headers of interface AzureFunctionActivity is changed from {
      info	[Changelog]         [propertyName: string]: string;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter value of interface CredentialListResponse is changed from ManagedIdentityCredentialResource[] to CredentialResource[]
      info	[Changelog]   - Type of parameter type of interface ScriptActivityScriptBlock is changed from ScriptType to any
      info	[Changelog]   - Type of parameter headers of interface WebActivity is changed from {
      info	[Changelog]         [propertyName: string]: string;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      info	[Changelog]   - Type of parameter headers of interface WebHookActivity is changed from {
      info	[Changelog]         [propertyName: string]: string;
      info	[Changelog]     } to {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     }
      Present SDK breaking changes suppressions
      Interface ManagedIdentityCredential no longer has parameter resourceId
      Operation CredentialOperations.createOrUpdate has a new signature
      Type of parameter headers of interface AzureFunctionActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
      Type of parameter headers of interface WebActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
      Type of parameter headers of interface WebHookActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
      Type of parameter type of interface ScriptActivityScriptBlock is changed from ScriptType to any
      Type of parameter value of interface CredentialListResponse is changed from ManagedIdentityCredentialResource[] to CredentialResource[]
      Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed in generating from 98bb783b08ee932174210602e4bf3505fab9a146. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  notice
      cmderr	[initScript.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
      cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
      cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[initScript.sh] npm notice
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • datafactory/resource-manager [Preview Schema Changes]
    ️⚠️ azure-powershell warning [Detail]
    • ⚠️Warning in generating from 98bb783b08ee932174210602e4bf3505fab9a146. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-powershell not found in swagger-to-sdk
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ⚠️Az.datafactory.DefaultTag [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 1, 2024
    @Jingshu918 Jingshu918 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 1, 2024
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager labels Apr 2, 2024
    @kazrael2119
    Copy link
    Contributor

    Hi @gary-x-li , Do we need to include this change in this month's release?https://github.com/Azure/sdk-release-request/projects/2025#card-92235598

    @raosuhas raosuhas merged commit 7045db2 into Azure:main Apr 15, 2024
    30 of 32 checks passed
    tjprescott pushed a commit that referenced this pull request Apr 17, 2024
    …ation… (#28538)
    
    * Change ScriptActivityScriptBlock Type Property To Support Parameterization
    
    * fix
    
    * Create sdk-suppressions.yaml
    
    * add azure-sdk-for-go suppression
    
    * Update sdk-suppressions.yaml
    
    * Update sdk-suppressions.yaml
    
    ---------
    
    Co-authored-by: Yuchao Yan <[email protected]>
    Co-authored-by: Alancere <[email protected]>
    Co-authored-by: kazrael2119 <[email protected]>
    wiboris pushed a commit to wiboris/azure-rest-api-specs that referenced this pull request May 7, 2024
    …ation… (Azure#28538)
    
    * Change ScriptActivityScriptBlock Type Property To Support Parameterization
    
    * fix
    
    * Create sdk-suppressions.yaml
    
    * add azure-sdk-for-go suppression
    
    * Update sdk-suppressions.yaml
    
    * Update sdk-suppressions.yaml
    
    ---------
    
    Co-authored-by: Yuchao Yan <[email protected]>
    Co-authored-by: Alancere <[email protected]>
    Co-authored-by: kazrael2119 <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-UserImpact Changes are not backward compatible and may cause customer disruption. BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-JavaScript-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression-Approved BreakingChange-Python-Sdk-Suppression BreakingChange-Python-Sdk-Suppression-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager ShiftLeftViolation
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.