Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognitive Services 2024-04-01-preview #28509

Merged
merged 35 commits into from
May 13, 2024

Conversation

tianxin-ms
Copy link
Member

@tianxin-ms tianxin-ms commented Mar 28, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Mar 28, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Mar 28, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.8) new version base version
cognitiveservices.json 2024-04-01-preview(7e7de19) 2023-05-01(main)
cognitiveservices.json 2024-04-01-preview(7e7de19) 2023-10-01-preview(main)
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 3 Errors, 55 Warnings failed [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-04 package-preview-2024-04(7e7de19) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 30 items are listed, please refer to log for more details.

Rule Message Related RPC [For API reviewers]
ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1355
RPC-Uri-V1-05
ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1573
RPC-Uri-V1-05
ResourceNameRestriction The resource name parameter 'commitmentPlanName' should be defined with a 'pattern' restriction.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1666
RPC-Uri-V1-05
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L944
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L947
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L972
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L995
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L998
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1020
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'addraiblocklistitems' in:'RaiBlocklistItems_BatchAdd'. Consider updating the operationId
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2630
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2639
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2645
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2648
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2673
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'deleteraiblocklistitems' in:'RaiBlocklistItems_BatchDelete'. Consider updating the operationId
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2684
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2693
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2699
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2702
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2724
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3288
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3294
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3297
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3310
⚠️ RequiredReadOnlySystemData The response of operation:'NetworkSecurityPerimeterConfigurations_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3320
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3333
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3339
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3342
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3358
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3378
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L3384


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L31
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L81
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:keySource.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L118
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L118
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L137
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L152
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L181
PathForTrackedResourceTypes The path must be under a subscription and resource group for tracked resource types.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L237
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L281
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L313
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L584
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L612
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L671
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1076
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1104
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1161
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1161
RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1161
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1205
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1220
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1252
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1269
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1297
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1492
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1525
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1557
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1768
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L1800
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2854
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json#L2893
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 28, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-python warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-resource-manager-schemas failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-powershell succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 28, 2024

@tianxin-ms tianxin-ms force-pushed the tianxinliu/2024-04-01-preview branch from 4eac467 to 4a8588e Compare April 1, 2024 23:33
@tianxin-ms tianxin-ms force-pushed the tianxinliu/2024-04-01-preview branch from b5c9112 to c7e1fa3 Compare April 3, 2024 01:52
@tianxin-ms tianxin-ms force-pushed the tianxinliu/2024-04-01-preview branch from bcced44 to 9899fad Compare April 3, 2024 04:23
@tianxin-ms tianxin-ms force-pushed the tianxinliu/2024-04-01-preview branch from db68f19 to a02a89f Compare April 8, 2024 23:51
@TimLovellSmith
Copy link
Member

azure-sdk-for-go is blocking merge, please address then request merge again

@tianxin-ms
Copy link
Member Author

It's fixed, thank you so much for your help. @TimLovellSmith

@tianxin-ms
Copy link
Member Author

/pr RequestMerge

@TimLovellSmith
Copy link
Member

@tianxin-ms I'm working on adding NetworkSecurityPerimeters to common-types, as it seems clearly needed! Please could you help me review the PR? Thanks. #28958

}
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.CognitiveServices/locations/{location}/modelCapacities/{model-format}/{model-name}/{model-version}": {
Copy link
Member

@TimLovellSmith TimLovellSmith May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ARMBlockingComment] Unfortunately I just noticed this and I don't think it follows ARM guidelines - ARM (and RBAC) needs the type/{instance}/type/{instance}/type/{instance} pattern to be followed in resource URLs #Resolved

@TimLovellSmith TimLovellSmith added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels May 3, 2024
@tianxin-ms tianxin-ms removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 3, 2024
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 3, 2024
@TimLovellSmith
Copy link
Member

@tianxin-ms There are some ModelValidation errors to fix now

@TimLovellSmith
Copy link
Member

TimLovellSmith commented May 3, 2024

},

This is basically okay. Now that I think of it further, it might be even better just to have one complex filter parameter in line with the well-known 'list resources' API, which allows OData style filtering by e.g. type+region. But I don't think that is actually required, and it could even be added in a future version, if all the filter parameters are optional #Resolved


Refers to: specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json:6771 in a2e20e1. [](commit_id = a2e20e1, deletion_comment = False)

@TimLovellSmith
Copy link
Member

TimLovellSmith commented May 3, 2024

  "required": true,

Just wondering - non-blocking -- do you really wish to make it required? Maybe it would be useful to not need to specify all the parameters, and be able to query different subsets?


Refers to: specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json:6766 in 0a714ec. [](commit_id = 0a714ec, deletion_comment = False)

@tianxin-ms
Copy link
Member Author

@tianxin-ms There are some ModelValidation errors to fix now

Thanks, I just fixed it, a typo

@tianxin-ms
Copy link
Member Author

  "required": true,

Just wondering - non-blocking -- do you really wish to make it required? Maybe it would be useful to not need to specify all the parameters, and be able to query different subsets?

Refers to: specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/preview/2024-04-01-preview/cognitiveservices.json:6766 in 0a714ec. [](commit_id = 0a714ec, deletion_comment = False)

It's designed to be required, those 3 are all needed to query a "model". We will return bad request, if every of them is missing.

@tianxin-ms
Copy link
Member Author

@TimLovellSmith , the ModelValidation error is fixed now, could you please help us signoff and approve the manifest PR?

@slreznit
Copy link

slreznit commented May 6, 2024

@TimLovellSmith , the ModelValidation error is fixed now, could you please help us signoff and approve the manifest PR?

+1 We are waiting for this manifest for over a month now and this is blocking our product release

@TimLovellSmith TimLovellSmith added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 6, 2024
@mentat9 mentat9 merged commit 99e6b32 into Azure:main May 13, 2024
29 of 32 checks passed
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
* Adds base for updating Microsoft.CognitiveServices from version preview/2023-10-01-preview to version 2024-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Cognitive Services 2024-04-01-preview

* Add NSP APIs

* address some error

* address lintdiff error

* Add list for defender

* fix nsp ModelValidation

* Add Mode Capacities Apis

* fix example

* Added properties for models api

* Update models APIs

* fix a name

* Removed getModel

* Change an example name

* Fix example name

* Update NSP APIs

* update PutRaiPolicy example

* using proxy resource type

* Fix example

* Remove models API from 04-01-preview

* Remove sibling values alongside $ref

* Address ModelValidation check

* Address comments

* fix breaking change

* address NSP comments

* fix nsp example

* fix NSP

* fix an example

* fix sdk-go

* Fix modelCapacities APIs

* removed $

---------

Co-authored-by: madhura <[email protected]>
@tianxin-ms tianxin-ms deleted the tianxinliu/2024-04-01-preview branch September 10, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.