Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat)Gateway): Adding gateway config resource #28478

Merge branch 'release-ApiManagement-2023-09-01-preview' into gatewayC…

f6e03ee
Select commit
Loading
Failed to load commit list.
Merged

feat)Gateway): Adding gateway config resource #28478

Merge branch 'release-ApiManagement-2023-09-01-preview' into gatewayC…
f6e03ee
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff failed Mar 28, 2024 in 1h 52m 6s

Swagger LintDiff failed

LintDiff: 2 Errors, 10 Warnings
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.0) new version base version
package-preview-2023-09 package-preview-2023-09(f6e03ee) package-preview-2023-09(release-ApiManagement-2023-09-01-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
PutGetPatchResponseSchema /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/gateways/{gatewayName}/configConnections/{configConnectionId} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimgatewayConfigConnections.json#L83
RPC-Put-V1-12
NestedResourcesMustHaveListOperation The nested resource 'ApiManagementGatewayConfigConnectionUpdateResource' does not have list operation, please add it.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimgatewayConfigConnections.json#L415
⚠️ MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimgatewayConfigConnections.json#L38
RPC-Get-V1-11
⚠️ RequiredReadOnlySystemData The response of operation:'ApiManagementGatewayConfigConnection_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimgatewayConfigConnections.json#L84
⚠️ RequiredReadOnlySystemData The response of operation:'ApiManagementGatewayConfigConnection_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimgatewayConfigConnections.json#L127
⚠️ RequiredReadOnlySystemData The response of operation:'ApiManagementGatewayConfigConnection_Update' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimgatewayConfigConnections.json#L186
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimgatewayConfigConnections.json#L307
⚠️ AllResourcesMustHaveGetOperation The resource 'ApiManagementGatewayConfigConnectionUpdateResource' does not have get operation, please add it.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimgatewayConfigConnections.json#L415
RPC-Get-V1-04


The following errors/warnings exist before current PR submission:

Rule Message
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimanagement.json#L100
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimanagement.json#L104
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimanagement.json#L535
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'operationId'.
Location: Microsoft.ApiManagement/preview/2023-09-01-preview/apimanagement.json#L554