Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert two operations to be async #28350

Change delete async operation status code

2437e50
Select commit
Loading
Failed to load commit list.
Merged

Convert two operations to be async #28350

Change delete async operation status code
2437e50
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff failed Mar 21, 2024 in 2m 56s

Swagger LintDiff failed

LintDiff: 4 Errors, 10 Warnings
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.0) new version base version
package-preview-2024-03 package-preview-2024-03(2437e50) package-preview-2024-03(MasterRyd3l-chaos-Microsoft.Chaos-2024-03-22-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L176
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L176
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L238
RPC-Delete-V1-01
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L259
RPC-Async-V1-07


The following errors/warnings exist before current PR submission:

Rule Message
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L52
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L94
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L139
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L182
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L244
⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L281
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L287
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L332
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L375
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Chaos/preview/2024-03-22-preview/privateAccesses.json#L429