Change connection-string to be object and support making severname, d… #2834

zhanyu2014 · 2018-04-08T07:30:06Z

…atabasename visible to customers

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…atabasename visible to customers

msftclas · 2018-04-08T07:30:17Z

All CLA requirements met.

AutorestCI · 2018-04-08T07:32:46Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

AutorestCI · 2018-04-08T07:33:44Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#18

AutorestCI · 2018-04-08T07:34:20Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1640

AutorestCI · 2018-04-08T07:34:49Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2770

marstr

The descriptions should really be updated to mention that there is a non-trivial string type.

marstr · 2018-04-09T18:18:43Z

...urce-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/LinkedService.json

@@ -104,7 +104,7 @@
      "properties": {
        "connectionString": {
          "description": "The connection string.",
-          "$ref": "../datafactory.json#/definitions/SecretBase"
+          "type": "object"


I see SecretBase was an object with a property type. Does that continue to be true here? Reading the description without the context of this PR, I would be surprised if this was anything but a string.

Before the connectionString was defined as SecretBase, and customers can only give value as "SecureString" or "AKV" (Two data contract used in ADF) for this field. Now we want to support customer to provide value with string directly while the existed "SecureString" and "AKV" can still work, so we change its type to be object.

marstr · 2018-04-09T18:20:02Z

...urce-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/LinkedService.json

+          "type": "object"
+        },
+        "encryptedCredential": {
+          "description": "The encrypted credential used for authentication. Credentials are encrypted using the integration runtime credential manager. Type: string (or Expression with resultType string).",


Ah, I'm presuming that this is the answer to my question above. It would be worth adding that to the description, if it's the case.

Description is updated.

marstr · 2018-04-09T22:42:56Z

Ah, another thing that I should point out @zhanyu2014 is that it says your CLA hasn't been signed. I assume you're a Microsoft employee, so you should go to http://opensource and join the appropriate organizations.

marstr · 2018-04-10T20:59:52Z

Adding the ARM review label before I forget.

jhendrixMSFT · 2018-04-10T23:10:31Z

@AutorestCI regenerate azure-sdk-for-go

azuresdkciprbot · 2018-04-12T21:59:01Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-12T22:51:54Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

marstr · 2018-04-13T16:49:13Z

I'd like to remind you @zhanyu2014 that our License CLA bot still says that you are not appropriately documented as a Microsoft Employee. I cannot merge this PR until your CLA is recognized.

marstr · 2018-04-16T23:45:35Z

Please acknowledge, @zhanyu2014. If I see no response, I'll have to close this PR as inactive.

zhanyu2014 · 2018-04-17T02:05:21Z

The related SLA has been validated and passed, related comments in change has been resolved, please help continue to finish this review and merge it. @marstr, @jianghaolu.

marstr · 2018-04-17T17:08:32Z

The only thing remaining now is @ravbhatnagar or another ARM representative to sign off. Thanks for signing the CLA, @zhanyu2014.

marstr · 2018-04-19T19:51:59Z

Ready for me to merge, @zhanyu2014?

zhanyu2014 · 2018-04-20T05:45:19Z

@marstr, please help us finish the code merge.

Change connection-string to be object and support making severname, d…

5a4a7d3

…atabasename visible to customers

azuresdkci assigned jianghaolu and marstr and unassigned jianghaolu Apr 8, 2018

azuresdkci requested review from jianghaolu and marstr April 8, 2018 07:31

AutorestCI mentioned this pull request Apr 8, 2018

[AutoPR datafactory/resource-manager] Change connection-string to be object and support making severname, d… Azure/azure-sdk-for-python#2363

Merged

AutorestCI mentioned this pull request Apr 8, 2018

[AutoPR datafactory/resource-manager] Change connection-string to be object and support making severname, d… AutorestCI/azure-libraries-for-java#63

Merged

AutorestCI mentioned this pull request Apr 8, 2018

[AutoPR datafactory/resource-manager] Change connection-string to be object and support making severname, d… Azure/azure-sdk-for-go#1528

Closed

AutorestCI mentioned this pull request Apr 8, 2018

[AutoPR datafactory/resource-manager] Change connection-string to be object and support making severname, d… Azure/azure-sdk-for-node#2702

Merged

marstr requested changes Apr 9, 2018

View reviewed changes

Update description

a3865a4

Azure deleted a comment from AutorestCI Apr 10, 2018

marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 10, 2018

AutorestCI mentioned this pull request Apr 10, 2018

[AutoPR datafactory/resource-manager] Change connection-string to be object and support making severname, d… Azure/azure-sdk-for-go#1547

Closed

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 19, 2018

marstr approved these changes Apr 19, 2018

View reviewed changes

marstr merged commit 7eef9b8 into Azure:master Apr 20, 2018

AutorestCI mentioned this pull request Apr 20, 2018

[AutoPR datafactory/resource-manager] Change connection-string to be object and support making severname, d… Azure/azure-sdk-for-go#1664

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change connection-string to be object and support making severname, d… #2834

Change connection-string to be object and support making severname, d… #2834

zhanyu2014 commented Apr 8, 2018 •

edited by azuresdkci

Loading

msftclas commented Apr 8, 2018 •

edited

Loading

AutorestCI commented Apr 8, 2018 •

edited

Loading

AutorestCI commented Apr 8, 2018 •

edited

Loading

AutorestCI commented Apr 8, 2018 •

edited

Loading

AutorestCI commented Apr 8, 2018 •

edited

Loading

marstr left a comment

marstr Apr 9, 2018

zhanyu2014 Apr 10, 2018

marstr Apr 9, 2018

zhanyu2014 Apr 10, 2018

marstr commented Apr 9, 2018

marstr commented Apr 10, 2018

jhendrixMSFT commented Apr 10, 2018

azuresdkciprbot commented Apr 12, 2018

azuresdkciprbot commented Apr 12, 2018

marstr commented Apr 13, 2018

marstr commented Apr 16, 2018

zhanyu2014 commented Apr 17, 2018

marstr commented Apr 17, 2018

marstr commented Apr 19, 2018

zhanyu2014 commented Apr 20, 2018

Change connection-string to be object and support making severname, d… #2834

Change connection-string to be object and support making severname, d… #2834

Conversation

zhanyu2014 commented Apr 8, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

msftclas commented Apr 8, 2018 • edited Loading

AutorestCI commented Apr 8, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 8, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 8, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Apr 8, 2018 • edited Loading

Automation for azure-sdk-for-node

marstr left a comment

Choose a reason for hiding this comment

marstr Apr 9, 2018

Choose a reason for hiding this comment

zhanyu2014 Apr 10, 2018

Choose a reason for hiding this comment

marstr Apr 9, 2018

Choose a reason for hiding this comment

zhanyu2014 Apr 10, 2018

Choose a reason for hiding this comment

marstr commented Apr 9, 2018

marstr commented Apr 10, 2018

jhendrixMSFT commented Apr 10, 2018

azuresdkciprbot commented Apr 12, 2018

azuresdkciprbot commented Apr 12, 2018

marstr commented Apr 13, 2018

marstr commented Apr 16, 2018

zhanyu2014 commented Apr 17, 2018

marstr commented Apr 17, 2018

marstr commented Apr 19, 2018

zhanyu2014 commented Apr 20, 2018

zhanyu2014 commented Apr 8, 2018 •

edited by azuresdkci

Loading

msftclas commented Apr 8, 2018 •

edited

Loading

AutorestCI commented Apr 8, 2018 •

edited

Loading

AutorestCI commented Apr 8, 2018 •

edited

Loading

AutorestCI commented Apr 8, 2018 •

edited

Loading

AutorestCI commented Apr 8, 2018 •

edited

Loading