Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger changes for ServiceNowV2 expression app model. #28294

Merged
merged 14 commits into from
May 13, 2024
Merged

Swagger changes for ServiceNowV2 expression app model. #28294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8e893bd
Swagger changes for ServiceNowV2 expression app model.
prebansa Mar 18, 2024
7e01a14
Changes
prebansa Mar 18, 2024
6a5a1b5
updates
prebansa Mar 26, 2024
a3bc524
Merge branch 'main' into users/prebansa/servicenowv2exp
prebansa Apr 1, 2024
23d5945
updates
prebansa Apr 19, 2024
cd1396c
Merge branch 'main' into users/prebansa/servicenowv2exp
prebansa Apr 19, 2024
97594a8
Update Pipeline.json
kanikagupta11 Apr 30, 2024
91f562e
Merge branch 'main' into users/prebansa/servicenowv2exp
kanikagupta11 Apr 30, 2024
d3e9dbf
Merge branch 'main' into users/prebansa/servicenowv2exp
kanikagupta11 May 7, 2024
613f3a9
Update sdk-suppressions.yaml
kazrael2119 May 8, 2024
e8907f0
add azure-sdk-for-go suppression
Alancere May 8, 2024
0a23629
Update sdk-suppressions.yaml
msyyc May 8, 2024
735e959
Update sdk-suppressions.yaml
msyyc May 8, 2024
e637baa
Merge branch 'main' into users/prebansa/servicenowv2exp
kanikagupta11 May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ...actory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9229,7 +9229,8 @@
"Constant",
"Field",
"Unary",
"Binary"
"Binary",
"NAry"
],
"type": "string",
"description": "Type of expressions supported by the system. Type: string."
Expand All @@ -9238,9 +9239,14 @@
"description": "Value for Constant/Field Type: string.",
"type": "string"
},
"operator": {
"description": "Expression operator value Type: string.",
"type": "string"
"operators": {
"description": "Expression operator value Type: list of strings.",
"type": "array",
"items": {
"type": "string",
"x-ms-format": "dfe-string",
"description": "Type: string."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are operators really freeform strings.... or is it more like an enumeration type?
You'll be validating these on the server side I assume?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operators are freeform string since ExpressionV2 is generic and we don't want to make it ServiceNowV2 connector specific. This will be checked in backend.

}
},
"operands": {
"description": "List of nested expressions.",
Expand Down
15 changes: 4 additions & 11 deletions specification/datafactory/resource-manager/sdk-suppressions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,12 @@ suppressions:
- package: azure-mgmt-datafactory
breaking-changes:
- Model ManagedIdentityCredential no longer has parameter resource_id
- Model ExpressionV2 no longer has parameter operator
azure-sdk-for-go:
- package: sdk/resourcemanager/datafactory/armdatafactory
breaking-changes:
- Enum `ScriptType` has been removed
- Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientCreateOrUpdateResponse` has been removed
- Field `ManagedIdentityCredentialResource` of struct `CredentialOperationsClientGetResponse` has been removed
- Field `TypeProperties` of struct `ManagedIdentityCredential` has been removed
- Function `*CredentialOperationsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, ManagedIdentityCredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, CredentialResource, *CredentialOperationsClientCreateOrUpdateOptions)`
- Struct `ManagedIdentityCredentialResource` has been removed
- Struct `ManagedIdentityTypeProperties` has been removed
- Type of `AzureFunctionActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
- Type of `CredentialListResponse.Value` has been changed from `[]*ManagedIdentityCredentialResource` to `[]*CredentialResource`
- Type of `WebActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
- Type of `WebHookActivityTypeProperties.Headers` has been changed from `map[string]*string` to `map[string]any`
- Field `Operator` of struct `ExpressionV2` has been removed
azure-sdk-for-js:
- package: "@azure/arm-datafactory"
breaking-changes:
Expand All @@ -26,4 +18,5 @@ suppressions:
- "Type of parameter headers of interface WebActivity is changed from {\n [propertyName: string]: string;\n } to {\n [propertyName: string]: any;\n }"
- "Type of parameter headers of interface WebHookActivity is changed from {\n [propertyName: string]: string;\n } to {\n [propertyName: string]: any;\n }"
- Type of parameter type of interface ScriptActivityScriptBlock is changed from ScriptType to any
- Type of parameter value of interface CredentialListResponse is changed from ManagedIdentityCredentialResource[] to CredentialResource[]
- Type of parameter value of interface CredentialListResponse is changed from ManagedIdentityCredentialResource[] to CredentialResource[]
- Interface ExpressionV2 no longer has parameter operator
13 changes: 9 additions & 4 deletions ...fication/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8138,7 +8138,8 @@
"Constant",
"Field",
"Unary",
"Binary"
"Binary",
"NAry"
],
"type": "string",
"description": "Type of expressions supported by the system. Type: string."
Expand All @@ -8147,9 +8148,13 @@
"description": "Value for Constant/Field Type: string.",
"type": "string"
},
"operator": {
"description": "Expression operator value Type: string.",
"type": "string"
"operators": {
"description": "Expression operator value Type: list of strings.",
"type": "array",
"items": {
"type": "string",
"description": "Type: string."
}
},
"operands": {
"description": "List of nested expressions.",
Expand Down