Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger changes for adding SPN, UAMI and SAMI credentials #28122

Merged
merged 4 commits into from
Mar 19, 2024

Merge branch 'main' into dev/saurabhchugh/AddingCredentialSourcesForD…

eaa57b0
Select commit
Loading
Failed to load commit list.
Merged

Swagger changes for adding SPN, UAMI and SAMI credentials #28122

Merge branch 'main' into dev/saurabhchugh/AddingCredentialSourcesForD…
eaa57b0
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff succeeded Mar 19, 2024 in 5m 11s

~[NotRequired_Staging] Swagger LintDiff succeeded

ppe/LintDiff
View Azure DevOps build log for more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-2018-06 package-2018-06(eaa57b0) package-2018-06(main)

The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ XmsParameterLocation The parameter 'api-version' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L8160
❌ XmsParameterLocation The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L7994
❌ GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6235
❌ GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6229
❌ AllTrackedResourcesMustHaveDelete The resource Factory does not have a corresponding delete operation.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L6167
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L5045
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4804
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4659
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4557
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4529
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4376
❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnection_CreateOrUpdate' Request Model: 'parameters[6].schema' Response Model: 'responses[200].schema'
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4376
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4168
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4112
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4070
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L4011
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3807
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3755
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3550
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3294
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3146
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3110
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3103
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3067
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3060
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L3054
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2966
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2960
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2868
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2826
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2764
❌ ParametersInPost isRecursive is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2630
❌ ParametersInPost startFromFailure is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2394
❌ ParametersInPost startActivityName is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2394
❌ ParametersInPost isRecovery is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2394
❌ ParametersInPost referencePipelineRunId is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2394
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2327
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2285
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2223
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2122
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2080
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L2018
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1917
❌ GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1875
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1813
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1510
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1504
❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'IntegrationRuntimes' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1418
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1227
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.DataFactory/stable/2018-06-01/datafactory.json#L1221
View more details on openapi-pipeline-app