Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure VMware Solution 2023-09-01 in TypeSpec #28023

Merged
merged 32 commits into from
Mar 15, 2024

Merge branch 'main' into AVS/2023-09-01

1628d55
Select commit
Loading
Failed to load commit list.
Merged

Azure VMware Solution 2023-09-01 in TypeSpec #28023

Merge branch 'main' into AVS/2023-09-01
1628d55
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff failed Mar 15, 2024 in 15m 18s

~[NotRequired_Staging] Swagger LintDiff failed

ppe/LintDiff: 29 Errors, 0 Warnings
View Azure DevOps build log for more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-2023-09-01 package-2023-09-01(1628d55) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L9250		 RPC-Policy-V1-03
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L9250		 RPC-Policy-V1-05, RPC-Put-V1-23
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3285		 RPC-Delete-V1-01
❌ PatchPropertiesCorrespondToPutProperties internet property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L447		 RPC-Patch-V1-01


The following errors/warnings exist before current PR submission:

Rule Message
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L9380
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L9377
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L9227
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L9227
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L9051
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L6448
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L6018
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5694
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5460
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5043
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L4731
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L4409
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3704
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2819
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2353
❌ PatchPropertiesCorrespondToPutProperties azureHybridBenefitType property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2268
❌ PatchPropertiesCorrespondToPutProperties affinityStrength property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2268
❌ PatchPropertiesCorrespondToPutProperties hostMembers property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2268
❌ PatchPropertiesCorrespondToPutProperties vmMembers property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L2268
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1916
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1636
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1297
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1041
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L785
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L519
View more details on openapi-pipeline-app