Liran e alertsmanagement microsoft.alerts management 2024 03 01 preview #27738

Liran-E · 2024-02-12T12:56:49Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…w/2023-05-01-preview to version 2024-03-01-preview

openapi-pipeline-app · 2024-02-12T12:56:52Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-02-12T12:56:53Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 7 Errors, 6 Warnings failed [Detail]

Compared specs (v0.10.7)	new version	base version
AlertProcessingRules.json	2024-03-01-preview(da84ac1)	2021-08-08(main)
AlertProcessingRules.json	2024-03-01-preview(da84ac1)	2023-05-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'api-version' removed or renamed? New: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L365:3 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L359:3
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L34:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L76:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L121:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L168:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L251:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L304:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L34:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L34:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L76:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L76:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L121:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L121:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L168:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L168:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L257:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L251:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L310:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L304:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

Compared specs (v2.2.0)	new version	base version
package-2023-03	package-2023-03(da84ac1)	package-2023-03(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'alertProcessingRuleName' should be defined with a 'pattern' restriction. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L117
`❌` XmsParameterLocation	The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L366
`❌` MissingTypeObject	The schema 'errorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L384
`❌` MissingTypeObject	The schema 'errorResponseBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L392
`❌` MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L416
`❌` MissingTypeObject	The schema 'ManagedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L437
`❌` MissingTypeObject	The schema 'PatchProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L884
`❌` MissingTypeObject	The schema 'PatchObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L893
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L39
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L84
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L136
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L192
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L272
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L334
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L367
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L375
⚠️ XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L407
⚠️ XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L520
⚠️ XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L545
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L676
⚠️ XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L700
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L711
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AlertsManagement/preview/2024-03-01-preview/AlertProcessingRules.json#L887

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/alertsmanagement/resource-manager/readme.md tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2023-03

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-02-12T12:56:54Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from 0e63dbed19393f0a00514d0fc9977f2e4fe276a8. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mCannot find path�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m�[31;1m�[36;1m�[31;1m�[36;1m     | �[31;1mit does not exist.�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1mLine |�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[0m�[36;1m�[36;1m�[0m�[36;1m�[0m�[36;1m�[31;1m�[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact�[0m

❌Azure.ResourceManager.AlertsManagement [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from 0e63dbed19393f0a00514d0fc9977f2e4fe276a8. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️azure-mgmt-alertsmanagement [View full logs] [Preview SDK Changes]
- azure_mgmt_alertsmanagement-1.0.0b1-py3-none-any.whl
- azure-mgmt-alertsmanagement-1.0.0b1.zip

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 0e63dbed19393f0a00514d0fc9977f2e4fe276a8. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/alertsmanagement/armalertsmanagement [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*AlertsClient.ChangeState` parameter(s) have been changed from `(context.Context, string, AlertState, *AlertsClientChangeStateOptions)` to `(context.Context, string, string, AlertState, *AlertsClientChangeStateOptions)`
info	[Changelog] - Function `*AlertsClient.GetByID` parameter(s) have been changed from `(context.Context, string, *AlertsClientGetByIDOptions)` to `(context.Context, string, string, *AlertsClientGetByIDOptions)`
info	[Changelog] - Function `*AlertsClient.GetHistory` parameter(s) have been changed from `(context.Context, string, *AlertsClientGetHistoryOptions)` to `(context.Context, string, string, *AlertsClientGetHistoryOptions)`
info	[Changelog] - Function `*AlertsClient.GetSummary` parameter(s) have been changed from `(context.Context, AlertsSummaryGroupByFields, *AlertsClientGetSummaryOptions)` to `(context.Context, string, AlertsSummaryGroupByFields, *AlertsClientGetSummaryOptions)`
info	[Changelog] - Function `*AlertsClient.NewGetAllPager` parameter(s) have been changed from `(*AlertsClientGetAllOptions)` to `(string, *AlertsClientGetAllOptions)`
info	[Changelog] - Function `*PrometheusRuleGroupsClient.Update` parameter(s) have been changed from `(context.Context, string, string, PrometheusRuleGroupResourcePatch, *PrometheusRuleGroupsClientUpdateOptions)` to `(context.Context, string, string, PrometheusRuleGroupResourcePatchParameters, *PrometheusRuleGroupsClientUpdateOptions)`
info	[Changelog] - Function `*ClientFactory.NewTenantActivityLogAlertsClient` has been removed
info	[Changelog] - Function `NewTenantActivityLogAlertsClient` has been removed
info	[Changelog] - Function `*TenantActivityLogAlertsClient.CreateOrUpdate` has been removed
info	[Changelog] - Function `*TenantActivityLogAlertsClient.Delete` has been removed
info	[Changelog] - Function `*TenantActivityLogAlertsClient.Get` has been removed
info	[Changelog] - Function `*TenantActivityLogAlertsClient.NewListByManagementGroupPager` has been removed
info	[Changelog] - Function `*TenantActivityLogAlertsClient.NewListByTenantPager` has been removed
info	[Changelog] - Function `*TenantActivityLogAlertsClient.Update` has been removed
info	[Changelog] - Struct `ActionGroup` has been removed
info	[Changelog] - Struct `ActionList` has been removed
info	[Changelog] - Struct `AlertRuleAllOfCondition` has been removed
info	[Changelog] - Struct `AlertRuleAnyOfOrLeafCondition` has been removed
info	[Changelog] - Struct `AlertRuleLeafCondition` has been removed
info	[Changelog] - Struct `AlertRuleProperties` has been removed
info	[Changelog] - Struct `PrometheusRuleGroupResourcePatch` has been removed
info	[Changelog] - Struct `PrometheusRuleGroupResourcePatchProperties` has been removed
info	[Changelog] - Struct `TenantActivityLogAlertResource` has been removed
info	[Changelog] - Struct `TenantAlertRuleList` has been removed
info	[Changelog] - Struct `TenantAlertRulePatchObject` has been removed
info	[Changelog] - Struct `TenantAlertRulePatchProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ActionTypeCorrelateAlerts` added to enum type `ActionType`
info	[Changelog] - New value `MonitorServiceResourceHealth` added to enum type `MonitorService`
info	[Changelog] - New enum type `NotificationsForCorrelatedAlerts` with values `NotificationsForCorrelatedAlertsNotifyAlways`, `NotificationsForCorrelatedAlertsSuppressAlways`
info	[Changelog] - New enum type `Status` with values `StatusFailed`, `StatusSucceeded`
info	[Changelog] - New enum type `Type` with values `TypePrometheusInstantQuery`, `TypePrometheusRangeQuery`
info	[Changelog] - New enum type `UpdateType` with values `UpdateTypeTimeBased`
info	[Changelog] - New function `*AlertEnrichmentItem.GetAlertEnrichmentItem() *AlertEnrichmentItem`
info	[Changelog] - New function `*AlertsClient.GetEnrichments(context.Context, string, string, *AlertsClientGetEnrichmentsOptions) (AlertsClientGetEnrichmentsResponse, error)`
info	[Changelog] - New function `*AlertsClient.NewListEnrichmentsPager(string, string, *AlertsClientListEnrichmentsOptions) *runtime.Pager[AlertsClientListEnrichmentsResponse]`
info	[Changelog] - New function `*CorrelateAlerts.GetAction() *Action`
info	[Changelog] - New function `*PrometheusEnrichmentItem.GetAlertEnrichmentItem() *AlertEnrichmentItem`
info	[Changelog] - New function `*PrometheusEnrichmentItem.GetPrometheusEnrichmentItem() *PrometheusEnrichmentItem`
info	[Changelog] - New function `*PrometheusInstantQuery.GetAlertEnrichmentItem() *AlertEnrichmentItem`
info	[Changelog] - New function `*PrometheusInstantQuery.GetPrometheusEnrichmentItem() *PrometheusEnrichmentItem`
info	[Changelog] - New function `*PrometheusRangeQuery.GetAlertEnrichmentItem() *AlertEnrichmentItem`
info	[Changelog] - New function `*PrometheusRangeQuery.GetPrometheusEnrichmentItem() *PrometheusEnrichmentItem`
info	[Changelog] - New struct `AlertEnrichmentProperties`
info	[Changelog] - New struct `AlertEnrichmentResponse`
info	[Changelog] - New struct `AlertEnrichmentsList`
info	[Changelog] - New struct `CorrelateAlerts`
info	[Changelog] - New struct `CorrelateBy`
info	[Changelog] - New struct `CorrelationDetails`
info	[Changelog] - New struct `CorrelationUpdates`
info	[Changelog] - New struct `PrometheusInstantQuery`
info	[Changelog] - New struct `PrometheusRangeQuery`
info	[Changelog] - New struct `PrometheusRuleGroupResourcePatchParameters`
info	[Changelog] - New struct `PrometheusRuleGroupResourcePatchParametersProperties`
info	[Changelog] - New field `Category` in struct `AlertRuleRecommendationProperties`
info	[Changelog] - New field `CorrelationDetails`, `HasEnrichments`, `IsStatefulAlert` in struct `Essentials`
info	[Changelog]
info	[Changelog] Total 38 breaking change(s), 49 additive change(s).

Present SDK breaking changes suppressions
No suppression file added.

Absent SDK breaking changes suppressions
- Function `*AlertsClient.ChangeState` parameter(s) have been changed from `(context.Context, string, AlertState, *AlertsClientChangeStateOptions)` to `(context.Context, string, string, AlertState, *AlertsClientChangeStateOptions)`
- Function `*AlertsClient.GetByID` parameter(s) have been changed from `(context.Context, string, *AlertsClientGetByIDOptions)` to `(context.Context, string, string, *AlertsClientGetByIDOptions)`
- Function `*AlertsClient.GetHistory` parameter(s) have been changed from `(context.Context, string, *AlertsClientGetHistoryOptions)` to `(context.Context, string, string, *AlertsClientGetHistoryOptions)`
- Function `*AlertsClient.GetSummary` parameter(s) have been changed from `(context.Context, AlertsSummaryGroupByFields, *AlertsClientGetSummaryOptions)` to `(context.Context, string, AlertsSummaryGroupByFields, *AlertsClientGetSummaryOptions)`
- Function `*AlertsClient.NewGetAllPager` parameter(s) have been changed from `(*AlertsClientGetAllOptions)` to `(string, *AlertsClientGetAllOptions)`
- Function `*ClientFactory.NewTenantActivityLogAlertsClient` has been removed
- Function `*PrometheusRuleGroupsClient.Update` parameter(s) have been changed from `(context.Context, string, string, PrometheusRuleGroupResourcePatch, *PrometheusRuleGroupsClientUpdateOptions)` to `(context.Context, string, string, PrometheusRuleGroupResourcePatchParameters, *PrometheusRuleGroupsClientUpdateOptions)`
- Function `*TenantActivityLogAlertsClient.CreateOrUpdate` has been removed
- Function `*TenantActivityLogAlertsClient.Delete` has been removed
- Function `*TenantActivityLogAlertsClient.Get` has been removed
- Function `*TenantActivityLogAlertsClient.NewListByManagementGroupPager` has been removed
- Function `*TenantActivityLogAlertsClient.NewListByTenantPager` has been removed
- Function `*TenantActivityLogAlertsClient.Update` has been removed
- Function `NewTenantActivityLogAlertsClient` has been removed
- Struct `ActionGroup` has been removed
- Struct `ActionList` has been removed
- Struct `AlertRuleAllOfCondition` has been removed
- Struct `AlertRuleAnyOfOrLeafCondition` has been removed
- Struct `AlertRuleLeafCondition` has been removed
- Struct `AlertRuleProperties` has been removed
- Struct `PrometheusRuleGroupResourcePatchProperties` has been removed
- Struct `PrometheusRuleGroupResourcePatch` has been removed
- Struct `TenantActivityLogAlertResource` has been removed
- Struct `TenantAlertRuleList` has been removed
- Struct `TenantAlertRulePatchObject` has been removed
- Struct `TenantAlertRulePatchProperties` has been removed

Parse Suppression File Errors
No suppression file added.

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 0e63dbed19393f0a00514d0fc9977f2e4fe276a8. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.1
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.1>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️alertsmanagement [View full logs] [Preview Schema Changes]

️⚠️ azure-powershell warning [Detail]

⚠️Warning [Logs] Generate from 0e63dbed19393f0a00514d0fc9977f2e4fe276a8. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.alertsmanagement.DefaultTag [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-02-12T12:56:55Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/alertsmanagement/armalertsmanagement	https://apiview.dev/Assemblies/Review/667256c0b11549428219d7e11100b300?revisionId=76bfc1f8472b4f8cade172b787b5fd4b
Swagger	Microsoft.AlertsManagement	https://apiview.dev/Assemblies/Review/112510d47e054569b515b92ac01535e6?revisionId=813061b1ed31492daf577d4e59bce9d2

openapi-workflow-bot · 2024-02-13T09:30:45Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

rkmanda · 2024-02-13T19:27:59Z

I saw your question on the ARM API review office hours, You are at step 1, you need to first get the breaking change approval. For the operations API issue, please add a suppression in the readme file and call it a false alarm pl

rkmanda · 2024-02-14T19:02:47Z

pl add a suppression for the failure using - https://github.com/Azure/autorest/blob/main/docs/generate/suppress-warnings.md

…agement-2024-03-01-preview

2. other fixes to comments by the reviewer

Liran-E · 2024-03-27T09:06:24Z

what's next?

rkmanda · 2024-04-04T21:23:46Z

/azp run

azure-pipelines · 2024-04-04T21:24:03Z

Azure Pipelines successfully started running 4 pipeline(s).

Liran-E · 2024-04-30T06:47:16Z

Hi, There's no activity on my PR because it is waiting a review (seems like breaking change review).

Liran-E · 2024-05-15T12:52:07Z

/pr RequestMerge

…ew (Azure#27738) * Adds base for updating Microsoft.AlertsManagement from version preview/2023-05-01-preview to version 2024-03-01-preview * Updates readme * Updates API version in new specs and examples * API 2024-03-01-preview: CorrelationUpdates * prettier check fix attempt * Swagger SemanticValidation fix * Swagger PrettierCheck fix * added suppression for OperationsAPIImplementation * 1. changed default package alertprocessingrules.json 2. other fixes to comments by the reviewer * pr fixes * indentation fix * pr fixes * fixed enum casing --------- Co-authored-by: MIDDLEEAST\lienglender <[email protected]>

Liran-E and others added 4 commits February 12, 2024 14:33

Adds base for updating Microsoft.AlertsManagement from version previe…

b5fd94c

…w/2023-05-01-preview to version 2024-03-01-preview

Updates readme

de723ab

Updates API version in new specs and examples

57dface

API 2024-03-01-preview: CorrelationUpdates

6ad3109

Liran-E requested a review from orieldar as a code owner February 12, 2024 12:56

azure-sdk mentioned this pull request Feb 12, 2024

[AutoPR sdk/resourcemanager/alertsmanagement/armalertsmanagement] Liran e alertsmanagement microsoft.alerts management 2024 03 01 preview azure-sdk/azure-sdk-for-go#8818

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 12, 2024

azure-sdk mentioned this pull request Feb 12, 2024

[AutoPR alertsmanagement] Liran e alertsmanagement microsoft.alerts management 2024 03 01 preview azure-sdk/azure-resource-manager-schemas#4105

Draft

AzureRestAPISpecReview added ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 12, 2024

MIDDLEEAST\lienglender added 2 commits February 13, 2024 10:37

prettier check fix attempt

c118173

Swagger SemanticValidation fix

c398303

Swagger PrettierCheck fix

feb2f24

added suppression for OperationsAPIImplementation

720eda3

azure-sdk mentioned this pull request Feb 22, 2024

[AutoPR alertsmanagement/resource-manager] Liran e alertsmanagement microsoft.alerts management 2024 03 01 preview azure-sdk/azure-resource-manager-schemas#4208

Draft

MIDDLEEAST\lienglender added 4 commits March 5, 2024 10:10

Merge branch 'main' into Liran-E-alertsmanagement-Microsoft.AlertsMan…

2a7a726

…agement-2024-03-01-preview

1. changed default package alertprocessingrules.json

8fa0d0d

2. other fixes to comments by the reviewer

pr fixes

9162cff

indentation fix

01e7e74

AzureRestAPISpecReview added the SuppressionReviewRequired label Mar 5, 2024

MIDDLEEAST\lienglender added 2 commits March 5, 2024 14:49

pr fixes

ae05f61

fixed enum casing

da84ac1

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Mar 5, 2024

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Mar 7, 2024

Liran-E removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 11, 2024

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 11, 2024

Liran-E removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 11, 2024

TimLovellSmith added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 1, 2024

azure-sdk mentioned this pull request Apr 4, 2024

[AutoPR azure-mgmt-alertsmanagement] Liran e alertsmanagement microsoft.alerts management 2024 03 01 preview azure-sdk/azure-sdk-for-python#6821

Closed

gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 8, 2024

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 8, 2024

microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Apr 29, 2024

Liran-E removed the no-recent-activity There has been no recent activity on this issue. label Apr 30, 2024

TimLovellSmith added the Approved-Suppression label Apr 30, 2024

microsoft-github-policy-service bot added the MergeRequested label May 15, 2024

mentat9 self-requested a review May 15, 2024 16:24

mentat9 approved these changes May 15, 2024

View reviewed changes

mentat9 merged commit 387c4e6 into main May 15, 2024
33 of 34 checks passed

mentat9 deleted the Liran-E-alertsmanagement-Microsoft.AlertsManagement-2024-03-01-preview branch May 15, 2024 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Liran e alertsmanagement microsoft.alerts management 2024 03 01 preview #27738

Liran e alertsmanagement microsoft.alerts management 2024 03 01 preview #27738

Liran-E commented Feb 12, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2024 •

edited

Loading

openapi-workflow-bot bot commented Feb 13, 2024

rkmanda commented Feb 13, 2024

rkmanda commented Feb 14, 2024

Liran-E commented Mar 27, 2024

rkmanda commented Apr 4, 2024

azure-pipelines bot commented Apr 4, 2024

Liran-E commented Apr 30, 2024

Liran-E commented May 15, 2024

Liran e alertsmanagement microsoft.alerts management 2024 03 01 preview #27738

Liran e alertsmanagement microsoft.alerts management 2024 03 01 preview #27738

Conversation

Liran-E commented Feb 12, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Feb 12, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Feb 12, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 12, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Feb 12, 2024 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Feb 13, 2024

rkmanda commented Feb 13, 2024

rkmanda commented Feb 14, 2024

Liran-E commented Mar 27, 2024

rkmanda commented Apr 4, 2024

azure-pipelines bot commented Apr 4, 2024

Liran-E commented Apr 30, 2024

Liran-E commented May 15, 2024

Liran-E commented Feb 12, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 12, 2024 •

edited

Loading