Agrbhuvnesh azurestackhci microsoft.azure stack hci 2024-02-15-preview #27600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…023-11-01-preview to version 2023-11-15-preview
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.7) | new version | base version |
|---|---|---|
| arcSettings.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| arcSettings.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| clusters.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| clusters.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| deploymentSettings.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| deploymentSettings.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| edgeDevices.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| edgeDevices.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| extensions.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| extensions.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| offers.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| offers.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| operations.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| operations.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| publishers.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| publishers.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| securitySettings.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| securitySettings.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| skus.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| skus.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| updateRuns.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| updateRuns.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| updateSummaries.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| updateSummaries.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
| updates.json | 2024-02-15-preview(ba8bc00) | 2024-01-01(main) |
| updates.json | 2024-02-15-preview(ba8bc00) | 2023-11-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 19 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 19 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 21 Warnings warning [Detail]
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| package-preview-2024-02 | package-preview-2024-02(ba8bc00) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 19 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Missing identifier id in array item property Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L858 |
||
| Missing identifier id in array item property Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L949 |
||
| Missing identifier id in array item property Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L956 |
||
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L1378 |
||
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L1394 |
||
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L1456 |
||
| Schema should have a description or title. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L1465 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/deploymentSettings.json#L648 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L881 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L886 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L909 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L914 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L919 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L924 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L929 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L934 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L939 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L957 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/edgeDevices.json#L967 |
The following errors/warnings exist before current PR submission:
Only 19 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/arcSettings.json#L120 |
|
The property 'tags' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/arcSettings.json#L189 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/arcSettings.json#L218 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/arcSettings.json#L242 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/arcSettings.json#L351 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/arcSettings.json#L409 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/arcSettings.json#L441 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L159 |
|
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L237 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L257 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L286 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L338 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L387 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/clusters.json#L445 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/extensions.json#L227 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/extensions.json#L247 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/extensions.json#L274 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/extensions.json#L332 |
|
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.AzureStackHCI/preview/2024-02-15-preview/offers.json#L134 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
CI-MissingBaseCommit
new-api-version
resource-manager
RPaaS
WaitForARMFeedback
|
Hi @agrbhuvnesh! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Jan 31, 2024
added 3 commits
February 2, 2024 11:54
…into agrbhuvnesh-azurestackhci-Microsoft.AzureStackHCI-2023-11-15-preview
agrbhuvnesh
changed the title
added 2 commits
March 21, 2024 14:12
msyyc
added
BreakingChange-Python-Sdk-Suppression-Approved
and removed
BreakingChange-Python-Sdk-Suppression-Approved
labels
raych1
reviewed
Mar 29, 2024
specification/azurestackhci/resource-manager/sdk-suppressions.yaml
Outdated
Show resolved
Hide resolved
raych1
reviewed
Mar 29, 2024
specification/azurestackhci/resource-manager/sdk-suppressions.yaml
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/pr RequestMerge |
ms-henglu
approved these changes
Apr 1, 2024
ms-henglu
deleted the
agrbhuvnesh-azurestackhci-Microsoft.AzureStackHCI-2023-11-15-preview
branch
wiboris
pushed a commit
to wiboris/azure-rest-api-specs
that referenced
this pull request
May 7, 2024
Azure#27600) * Adds base for updating Microsoft.AzureStackHCI from version preview/2023-11-01-preview to version 2023-11-15-preview * Updates readme * Updates API version in new specs and examples * :wq * created edgedevice as polymorphic resource * updated version * update * added files * updated * updated * update enum def * add sdk-suppressions.yaml * Update sdk-suppressions.yaml * Update sdk-suppressions.yaml * Update sdk-suppressions.yaml * Update sdk-suppressions.yaml --------- Co-authored-by: Bhuvnesh kumar <[email protected]> Co-authored-by: Heng Lu <[email protected]> Co-authored-by: Alancere <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: kazrael2119 <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.