[data-plane] Initial Creation of HealthDataAiServices.Deid #27452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR validation pipeline restarted successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| default | default(b68ecbe) | default(release-healthdataaiservices-deidentification-2024-01-31-preview) |
| package-2024-01-31-preview | package-2024-01-31-preview(b68ecbe) | default(release-healthdataaiservices-deidentification-2024-01-31-preview) |
[must fix]The following errors/warnings are introduced by current PR:
️❌Avocado: 3 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: data-plane/Microsoft.HealthDataAIServices/preview/2024-01-31-preview |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: Microsoft.HealthDataAIServices/preview/2024-01-31-preview/examples |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: b68ecbe886fddf02d1a6f623cb7ad02b1f8f7716/specification/deidentification/data-plane |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️❌TypeSpecAPIView: 0 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
| "How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR." |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
CI-MissingBaseCommit
new-api-version
TypeSpec
|
Hi @GrahamMThomas! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Jan 19, 2024
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
1 similar comment
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
GrahamMThomas
force-pushed
the
gthomas/feat/health-deid
branch
from
d602d0e to
3d0b53f
Compare
GrahamMThomas
force-pushed
the
gthomas/feat/health-deid
branch
from
c26f987 to
9d89195
Compare
GrahamMThomas
requested review from
MushMal and
weidongxu-microsoft
and removed request for
a team
...aaiservices/HealthDataAIServices.Deidentification/examples/2024-01-31-preview/CreateJob.json
Outdated
Show resolved
Hide resolved
GrahamMThomas
force-pushed
the
gthomas/feat/health-deid
branch
from
ba9af3f to
dc65a6f
Compare
|
Can we get a branch for this PR to merge into instead of main? We are currently in private preview with very few customers and don't want published SDKs yet. |
|
You can use https://openapihub.azure-devex-tools.com/ to create a feature branch. Select "create openapi specs". And if you need collaboration on the feature branch, select "multiple people working" within. |
mikekistler
requested changes
Jan 25, 2024
...vices.Deidentification/preview/2024-01-31-preview/HealthDataAIServices.Deidentification.json
Outdated
Show resolved
Hide resolved
...vices.Deidentification/preview/2024-01-31-preview/HealthDataAIServices.Deidentification.json
Outdated
Show resolved
Hide resolved
...vices.Deidentification/preview/2024-01-31-preview/HealthDataAIServices.Deidentification.json
Outdated
Show resolved
Hide resolved
...vices.Deidentification/preview/2024-01-31-preview/HealthDataAIServices.Deidentification.json
Outdated
Show resolved
Hide resolved
GrahamMThomas
force-pushed
the
gthomas/feat/health-deid
branch
from
ed3503c to
e3e31e6
Compare
GrahamMThomas
changed the base branch from
main
to
release-healthdataaiservices-deidentification-2024-01-31-preview
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
|
Hi, @GrahamMThomas, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
GrahamMThomas
force-pushed
the
gthomas/feat/health-deid
branch
from
e3e31e6 to
b68ecbe
Compare
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: data-plane/Microsoft.HealthDataAIServices/preview/2024-01-31-preview |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: Microsoft.HealthDataAIServices/preview/2024-01-31-preview/examples |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: b68ecbe886fddf02d1a6f623cb7ad02b1f8f7716/specification/deidentification/data-plane |
️⌛SwaggerAPIView pending [Detail]
️⌛TypeSpecAPIView pending [Detail]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️🔄SemanticValidation inProgress [Detail]
️⌛SpellCheck pending [Detail]
️⌛PR Summary pending [Detail]
️⌛Automated merging requirements met pending [Detail]
|
Closing as I think something is wrong with the build pipeline state. Will reopen a new PR. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.