OS History API - Swagger #2743

sds6 · 2018-03-23T03:12:54Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

msftclas · 2018-03-23T03:13:04Z

All CLA requirements met.

AutorestCI · 2018-03-23T03:16:03Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpex32jgqk/rest/specification/compute/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpex32jgqk/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '[email protected]/autorest.go@~2.1.95', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.95->2.1.95)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-disks-2018-04"} .
Processing batch task - {"tag":"package-2017-12"} .
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'StorageAccountTypes' and different values: Standard_LRS,Premium_LRS vs. Standard_LRS,Premium_LRS
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\ObjectBuilder.cs:line 147
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 204
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 46
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SchemaBuilder.cs:line 131
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 271
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISH8kiit\38_20171116T010915\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: go/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
Failure during batch task - {"tag":"package-2017-12"} -- Error: Plugin imodeler1 reported failure..
  Error: Plugin imodeler1 reported failure.

AutorestCI · 2018-03-23T03:16:47Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2710

AutorestCI · 2018-03-23T03:16:57Z

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#2

AutorestCI · 2018-03-23T03:23:12Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2276

lmazuel · 2018-03-23T18:52:52Z

@AutorestCI rebuild azure-libraries-for-java

sarangan12 · 2018-03-23T20:27:20Z

@sds6 The contributor license agreement has not been signed yet. Could you join the appropriate org to resolve the issue?

sds6 · 2018-03-23T21:49:39Z

@sarangan12 signed.

sarangan12 · 2018-03-23T22:14:23Z

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/357213506
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/357213505

Please take a look at these errors and try to fix them.

sarangan12 · 2018-03-28T17:49:44Z

@sds6 Any updates????

sds6 · 2018-03-28T21:16:12Z

Will have an update early next week.

…

On Wed, Mar 28, 2018 at 10:49 AM, Sarangan Rajamanickam < ***@***.***> wrote: @sds6 <https://github.com/sds6> Any updates???? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2743 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIg6-Fr__w_H9yw557CviiFGsEx21UmBks5ti81FgaJpZM4S4HHD> .

sds6 · 2018-04-03T21:59:54Z

@sarangan12 All the errors I see are for x-ms-examples. Compute is adding them gradually for all APIs over the next few months. Similar PR #2589 was also approved ignoring x-ms-examples. Adding in @hyonholee to chime in.

sarangan12 · 2018-04-05T17:45:45Z

@sds6 Take a look at this: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/357213505 These errors are not related to x-ms-examples. These errors must be fixed before approval

sarangan12

Please see the link https://travis-ci.org/Azure/azure-rest-api-specs/jobs/357213505 These are not x-ms-examples errors. They must be fixed before approval

sarangan12 · 2018-04-09T22:02:52Z

@sds6 The recent changes have introduced more new errors. Please check the travis CI.

sds6 · 2018-04-10T19:58:17Z

@sarangan12 Those changes are not related to the push I made.

hyonholee · 2018-04-10T21:00:43Z

specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/compute.json

+          "readOnly": true,
+          "type": "string",
+          "format": "date-time",
+          "description": "Start time of the upgrade."


"End time of the upgrade"

hyonholee · 2018-04-10T21:01:10Z

specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/compute.json

+        "startedBy": {
+          "readOnly": true,
+          "type": "string",
+          "description": "Error Details for this upgrade if there are any.",


Update the description

hyonholee · 2018-04-10T21:01:27Z

specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/compute.json

+          "description": "Resource type"
+        },
+        "location": {
+          "type": "string",


"readOnly": true,

hyonholee · 2018-04-10T21:01:44Z

specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/compute.json

+          "description": "Resource location"
+        }
+      },
+        "description": "Virtual Machine Scale Set OS Upgrade History operation response."


NIT: fix indent

jhendrixMSFT · 2018-04-10T22:12:30Z

@AutorestCI regenerate azure-sdk-for-go

jhendrixMSFT · 2018-04-10T23:19:49Z

@AutorestCI regenerate azure-sdk-for-go

azuresdkciprbot · 2018-04-12T22:10:13Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 15
After the PR: Warning(s): 0 Error(s): 15

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-12T23:01:57Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 15
After the PR: Warning(s): 0 Error(s): 15

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

added OS History for 12-01

1d00c59

azuresdkci assigned sarangan12 Mar 23, 2018

AutorestCI mentioned this pull request Mar 23, 2018

[AutoPR compute/resource-manager] OS History API - Swagger Azure/azure-sdk-for-node#2537

Closed

AutorestCI mentioned this pull request Mar 23, 2018

[AutoPR compute/resource-manager] OS History API - Swagger Azure/azure-libraries-for-java#376

Closed

AutorestCI mentioned this pull request Mar 23, 2018

[AutoPR compute/resource-manager] OS History API - Swagger Azure/azure-sdk-for-python#2264

Closed

AutorestCI mentioned this pull request Mar 23, 2018

[AutoPR compute/resource-manager] OS History API - Swagger AutorestCI/azure-libraries-for-java#1

Open

sarangan12 approved these changes Apr 5, 2018

View reviewed changes

sarangan12 requested changes Apr 5, 2018

View reviewed changes

modified Json file

fd4e857

This was referenced Apr 9, 2018

[AutoPR compute/resource-manager] OS History API - Swagger Azure/azure-sdk-for-python#2365

Merged

[AutoPR compute/resource-manager] OS History API - Swagger Azure/azure-sdk-for-go#1531

Closed

changed description

2c66a61

hyonholee reviewed Apr 10, 2018

View reviewed changes

removed PIR to use exiting ImageRef

169017e

AutorestCI mentioned this pull request Apr 10, 2018

[AutoPR compute/resource-manager] OS History API - Swagger Azure/azure-sdk-for-go#1546

Closed

AutorestCI mentioned this pull request Apr 10, 2018

[AutoPR compute/resource-manager] OS History API - Swagger Azure/azure-sdk-for-go#1548

Closed

sarangan12 approved these changes Apr 11, 2018

View reviewed changes

sarangan12 merged commit d4f8a02 into Azure:master Apr 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OS History API - Swagger #2743

OS History API - Swagger #2743

sds6 commented Mar 23, 2018 •

edited by azuresdkci

Loading

msftclas commented Mar 23, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading

lmazuel commented Mar 23, 2018

sarangan12 commented Mar 23, 2018

sds6 commented Mar 23, 2018

sarangan12 commented Mar 23, 2018

sarangan12 commented Mar 28, 2018

sds6 commented Mar 28, 2018 via email

sds6 commented Apr 3, 2018

sarangan12 commented Apr 5, 2018

sarangan12 left a comment

sarangan12 commented Apr 9, 2018

sds6 commented Apr 10, 2018

hyonholee Apr 10, 2018

hyonholee Apr 10, 2018

hyonholee Apr 10, 2018

hyonholee Apr 10, 2018

jhendrixMSFT commented Apr 10, 2018

jhendrixMSFT commented Apr 10, 2018

azuresdkciprbot commented Apr 12, 2018

azuresdkciprbot commented Apr 12, 2018

OS History API - Swagger #2743

OS History API - Swagger #2743

Conversation

sds6 commented Mar 23, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

msftclas commented Mar 23, 2018 • edited Loading

AutorestCI commented Mar 23, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Mar 23, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 23, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Mar 23, 2018 • edited Loading

Automation for azure-sdk-for-python

lmazuel commented Mar 23, 2018

sarangan12 commented Mar 23, 2018

sds6 commented Mar 23, 2018

sarangan12 commented Mar 23, 2018

sarangan12 commented Mar 28, 2018

sds6 commented Mar 28, 2018 via email

sds6 commented Apr 3, 2018

sarangan12 commented Apr 5, 2018

sarangan12 left a comment

Choose a reason for hiding this comment

sarangan12 commented Apr 9, 2018

sds6 commented Apr 10, 2018

hyonholee Apr 10, 2018

Choose a reason for hiding this comment

hyonholee Apr 10, 2018

Choose a reason for hiding this comment

hyonholee Apr 10, 2018

Choose a reason for hiding this comment

hyonholee Apr 10, 2018

Choose a reason for hiding this comment

jhendrixMSFT commented Apr 10, 2018

jhendrixMSFT commented Apr 10, 2018

azuresdkciprbot commented Apr 12, 2018

azuresdkciprbot commented Apr 12, 2018

sds6 commented Mar 23, 2018 •

edited by azuresdkci

Loading

msftclas commented Mar 23, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading

AutorestCI commented Mar 23, 2018 •

edited

Loading