Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Kubernetes to add version stable/2024-01-01 #26765

Merged

Conversation

atchutbarli
Copy link
Contributor

@atchutbarli atchutbarli commented Nov 17, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

Copy link

openapi-pipeline-app bot commented Nov 17, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Nov 17, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
connectedClusters.json 2024-01-01(d7ebf8c) 2021-10-01(main)
connectedClusters.json 2024-01-01(d7ebf8c) 2023-11-01-preview(main)
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2024-01 package-2024-01(d7ebf8c) default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L31
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L31
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L129
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L198
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L228
ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L247
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L247
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L308
OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Kubernetes/operations' does not match the ARM specification. Please standardize the schema.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L406
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L407
SystemDataDefinitionsCommonTypes System data references must utilize common types.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L522
IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L592
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L34
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L55
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L58
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L61
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L92
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L103
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L118
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L121
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L124
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L149
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L156
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L171
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L174
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L177
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L193
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L200
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L212
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/stable/2024-01-01/connectedClusters.json#L215
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 17, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/hybridkubernetes/armhybridkubernetes - Approved - 2.0.0
+	Type of `ConnectedClusterPatch.Properties` has been changed from `any` to `*ConnectedClusterPatchProperties`
azure-sdk-for-python-track2 - track2_azure-mgmt-hybridkubernetes - Approved - 1.1.0
+	Model ConnectedClusterPatch no longer has parameter properties
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 8133b6d4dd7c8ab0dafd74591433290ff47a4869. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.4
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-hybridkubernetes [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Model ConnectedCluster has a new parameter aad_profile
    info	[Changelog]   - Model ConnectedCluster has a new parameter arc_agent_profile
    info	[Changelog]   - Model ConnectedCluster has a new parameter azure_hybrid_benefit
    info	[Changelog]   - Model ConnectedCluster has a new parameter distribution_version
    info	[Changelog]   - Model ConnectedCluster has a new parameter kind
    info	[Changelog]   - Model ConnectedCluster has a new parameter miscellaneous_properties
    info	[Changelog]   - Model ConnectedCluster has a new parameter private_link_scope_resource_id
    info	[Changelog]   - Model ConnectedCluster has a new parameter private_link_state
    info	[Changelog]   - Model ConnectedClusterPatch has a new parameter azure_hybrid_benefit
    info	[Changelog]   - Model ConnectedClusterPatch has a new parameter distribution
    info	[Changelog]   - Model ConnectedClusterPatch has a new parameter distribution_version
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model ConnectedClusterPatch no longer has parameter properties
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 8133b6d4dd7c8ab0dafd74591433290ff47a4869. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-hybridkubernetes [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 8133b6d4dd7c8ab0dafd74591433290ff47a4869. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/hybridkubernetes/armhybridkubernetes [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `ConnectedClusterPatch.Properties` has been changed from `any` to `*ConnectedClusterPatchProperties`
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `AutoUpgradeOptions` with values `AutoUpgradeOptionsDisabled`, `AutoUpgradeOptionsEnabled`
    info	[Changelog] - New enum type `AzureHybridBenefit` with values `AzureHybridBenefitFalse`, `AzureHybridBenefitNotApplicable`, `AzureHybridBenefitTrue`
    info	[Changelog] - New enum type `ConnectedClusterKind` with values `ConnectedClusterKindProvisionedCluster`
    info	[Changelog] - New enum type `PrivateLinkState` with values `PrivateLinkStateDisabled`, `PrivateLinkStateEnabled`
    info	[Changelog] - New struct `AADProfile`
    info	[Changelog] - New struct `ArcAgentProfile`
    info	[Changelog] - New struct `ConnectedClusterPatchProperties`
    info	[Changelog] - New field `Kind` in struct `ConnectedCluster`
    info	[Changelog] - New field `AADProfile`, `ArcAgentProfile`, `AzureHybridBenefit`, `DistributionVersion`, `MiscellaneousProperties`, `PrivateLinkScopeResourceID`, `PrivateLinkState` in struct `ConnectedClusterProperties`
    info	[Changelog]
    info	[Changelog] Total 1 breaking change(s), 20 additive change(s).
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 8133b6d4dd7c8ab0dafd74591433290ff47a4869. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Kubernetes [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 8133b6d4dd7c8ab0dafd74591433290ff47a4869. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.4
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️hybridkubernetes [View full logs]  [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 8133b6d4dd7c8ab0dafd74591433290ff47a4869. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.hybridkubernetes.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.hybridkubernetes.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 17, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/hybridkubernetes/armhybridkubernetes https://apiview.dev/Assemblies/Review/297a1aebbabb422e941c29643af139d9
Java azure-resourcemanager-hybridkubernetes https://apiview.dev/Assemblies/Review/d68d071fd0ba4c3bb889b98288b75e4e
.Net Azure.ResourceManager.Kubernetes There is no API change compared with the previous version
Swagger Microsoft.Kubernetes https://apiview.dev/Assemblies/Review/1727a230c4fb4b9da673eafe3dad4956

@atchutbarli atchutbarli added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReview labels Nov 27, 2023
@atchutbarli atchutbarli marked this pull request as ready for review December 5, 2023 20:38
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Dec 5, 2023
@visingla-ms visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Dec 6, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2023
@visingla-ms
Copy link
Contributor

Please get SDK Breaking changes reviewed from SDK Reviewers.

@Alancere Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Dec 7, 2023
@atchutbarli
Copy link
Contributor Author

/pr RequestMerge

@ms-zhenhua ms-zhenhua merged commit 583a497 into main Dec 12, 2023
@ms-zhenhua ms-zhenhua deleted the atchutbarli-hybridkubernetes-Microsoft.Kubernetes-2024-01-01 branch December 12, 2023 00:33
arifibrahim4 pushed a commit that referenced this pull request Feb 26, 2024
…n stable/2024-01-01 (#26765)

* Adds base for updating Microsoft.Kubernetes from version preview/2023-11-01-preview to version 2024-01-01

* Updates readme

* Updates API version in new specs and examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants