Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAD to Microsoft Entra updates #26725

Merged
merged 24 commits into from
Dec 12, 2023
Merged

AAD to Microsoft Entra updates #26725

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
cc40363
AAD to Microsoft Entra updates
stevemunk Nov 10, 2023
f9e21f8
Merge branch 'main' into aad-entra-update
stevemunk Nov 16, 2023
5df2785
Added getitems to ./custom-words.txt as instructed in https://aka.ms/…
stevemunk Nov 17, 2023
4e068b4
Merge branch 'aad-entra-update' of https://github.com/stevemunk/azure…
stevemunk Nov 17, 2023
f687997
Removed the extra space before 'Microsoft Entra ID'.
stevemunk Nov 28, 2023
8d6e0ff
Added two suppressions: 1-INVALID_TYPE 2-RESPONSE_SCHEMA_NOT_IN_SPEC.
stevemunk Nov 30, 2023
3f402cb
Changed API version in examples to address INVALID_REQUEST_PARAMETER …
stevemunk Nov 30, 2023
7d7d749
Changed API version in examples to address INVALID_REQUEST_PARAMETER …
stevemunk Dec 1, 2023
19ac0f1
add suppressions for the errors under specification/maps/data-plane/C…
scbedd Dec 5, 2023
4b5e9d8
add suppression for INVALID_TYPE in specification/maps/data-plane/Ren…
scbedd Dec 5, 2023
97b6cd4
Merge remote-tracking branch 'origin/main' into aad-entra-update
scbedd Dec 6, 2023
e78d007
added suppressions
stevemunk Dec 7, 2023
344502a
Merge branch 'main' of https://github.com/azure/azure-rest-api-specs …
stevemunk Dec 7, 2023
6124f14
removed duplicate section.
stevemunk Dec 7, 2023
bfe7d83
Merge branch 'aad-entra-update' of https://github.com/stevemunk/azure…
stevemunk Dec 7, 2023
33889e0
reverting changes to these files. As near as I can determine, these a…
stevemunk Dec 7, 2023
18c978d
LRO_RESPONSE_HEADER errors
stevemunk Dec 11, 2023
f0f9839
LRO_RESPONSE_HEADER errors
stevemunk Dec 11, 2023
465ac0b
addressing PoliCheck issues.
stevemunk Dec 12, 2023
2cb0a94
addressing PoliCheck issues.
stevemunk Dec 12, 2023
6fdca31
addressing PoliCheck issues.
stevemunk Dec 12, 2023
0ba8c80
addressing LRO_RESPONSE_HEADER errors.
stevemunk Dec 12, 2023
936a8b0
addressing PoliCheck errors.
stevemunk Dec 12, 2023
2314dca
addressing PoliCheck errors.
stevemunk Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions specification/maps/data-plane/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ These are the global settings for MapsClient.
``` yaml
title: MapsClient
openapi-type: data-plane
tag: package-preview-2.0
tag: package-stable-2023-07-01
```

### Suppression
Expand All @@ -42,22 +42,40 @@ directive:
from: search.json
where: $.paths["/providers/Microsoft.Subscription/subscriptionOperations/{operationId}"].get
reason: The reason for this suppression is the API is already released and introducing new LRO properties will not function and are not supported today and will only be developed for the next version of this API.
```

- suppress: INVALID_TYPE
reason: false positive from oav is breaking our example validation. See azure/oav#1020.

- suppress: RESPONSE_SCHEMA_NOT_IN_SPEC
reason: false positive from oav is breaking our example validation. See azure/oav#1021.
```

### Tag: package-stable-2023-07-01

These settings apply only when `--tag=package-stable-2023-07-01` is specified on the command line.

```yaml $(tag) == 'package-stable-2023-07-01'
input-file:
- Common/stable/2023-06-01/common.json
- Microsoft.Maps/Data/preview/2.0/data.json
- DataRegistry/stable/2023-06-01/dataregistry.json
- Geolocation/preview/1.0/geolocation.json
- Render/stable/2022-08-01/render.json
- Route/preview/1.0/route.json
- Search/stable/2023-06-01/search.json
- Spatial/stable/2022-08-01/spatial.json
- Timezone/preview/1.0/timezone.json
- Traffic/preview/1.0/traffic.json
- Weather/stable/1.1/weather.json
```
scbedd marked this conversation as resolved.
Show resolved Hide resolved

### Tag: package-preview-2.0

These settings apply only when `--tag=package-preview-2.0` is specified on the command line.

```yaml $(tag) == 'package-preview-2.0'
input-file:
- Microsoft.Maps/Alias/preview/2.0/alias.json
- Microsoft.Maps/Data/preview/2.0/data.json
- Microsoft.Maps/Dataset/preview/2.0/dataset.json
- Microsoft.Maps/DEM/preview/1.0/elevation.json
- Microsoft.Maps/DwgConversion/preview/2.0/dwgconversion.json
- Microsoft.Maps/FeatureState/preview/2.0/featurestate.json
- Microsoft.Maps/Feedback/preview/1.0/feedback.json
- Microsoft.Maps/Geolocation/preview/1.0/geolocation.json
- Microsoft.Maps/Render/preview/1.0/render.json
- Microsoft.Maps/Render/preview/2.0/render.json
Expand All @@ -68,7 +86,6 @@ input-file:
- Microsoft.Maps/Timezone/preview/1.0/timezone.json
- Microsoft.Maps/Traffic/preview/1.0/traffic.json
- Microsoft.Maps/Weather/preview/1.0/weather.json
- Microsoft.Maps/WFS/preview/2.0/wfs.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this removal is why you're seeing the sudden errors for unreferenced json from readme. the first avocado error specifically. I think it's iffy reporting, but all stemming from the unreferenced wfs.json. I'm betting it's breaking oav's logic when resolving the swagger itself, which is why the examples are also throwing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you make changes to the readme like this, you're going to need to go through the ARM review process as described in the PR body. (the image with labeling instructions etc in the automatically created body of the PR).

```

### Tag: package-1.0-preview
Expand All @@ -78,8 +95,6 @@ These settings apply only when `--tag=package-1.0-preview` is specified on the c
``` yaml $(tag) == 'package-1.0-preview'
input-file:
- Microsoft.Maps/Data/preview/1.0/data.json
- Microsoft.Maps/DEM/preview/1.0/elevation.json
- Microsoft.Maps/Feedback/preview/1.0/feedback.json
- Microsoft.Maps/Geolocation/preview/1.0/geolocation.json
- Microsoft.Maps/Render/preview/1.0/render.json
- Microsoft.Maps/Render/preview/2.0/render.json
Expand Down