[ACS JobRouter][GA] Change discriminators to enum instead of string for all polymorphic base class #26658

sarkar-rajarshi · 2023-11-10T03:49:20Z

Based on reviews from Azure/azure-sdk#6852

It was recommended for the discriminator property used in polymorphic classes to be exposed as extensible enums. This introduces the following enums in the spec which are now used as discriminator type instead of str

This is also the recommended representation of discriminators Teams post (internal)

JobMatchingModeKind (used for JobMatchingMode.kind)
RouterRuleKind (used for RouterRule.kind)
DistributionModeKind (used for DistributionMode.kind)
ExceptionTriggerKind (used for ExceptionTrigger.kind)
ExceptionActionKind (used for ExceptionAction.kind)
QueueSelectorAttachmentKind (used for QueueSelectorAttachment.kind)
WorkerSelectorAttachmentKind (used for WorkerSelectorAttachment.kind)

Other changes:-

Update examples
Correction of config value for typespec-ts Link
Misc. SDK customizations

Previous PR: #25763

Breaking Change: Workitem

openapi-pipeline-app · 2023-11-10T03:49:24Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-11-10T03:49:25Z

Swagger Validation Report

️❌BreakingChange: 94 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
communicationservicejobrouter.json	2023-11-01(524b6f5)	2023-11-01(main)

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3328:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3214:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3970:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3814:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L4652:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L4454:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3984:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3828:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2535:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2535:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2566:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2566:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2781:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2721:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2663:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2633:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2943:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2859:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2957:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2873:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2535:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2535:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2566:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2566:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2663:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2633:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3328:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3214:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L4652:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L4454:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3970:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3814:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3984:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3828:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3970:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3814:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3984:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3828:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3970:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3814:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3984:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3828:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2535:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2535:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2566:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2566:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2663:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2633:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3328:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L3214:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L4652:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L4454:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2943:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2859:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2957:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2873:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2781:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2721:9
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2663:9 Old: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L2633:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-jobrouter-2023-11-01	package-jobrouter-2023-11-01(524b6f5)	package-jobrouter-2023-11-01(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L37
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L85
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L93
⚠️ SchemaTypeAndFormat	Schema with type: string has unrecognized format: eTag Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L104
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L138
⚠️ OperationId	OperationId for patch method should contain both 'Create' and 'Update' Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L139
⚠️ PatchInOperationName	'PATCH' operation 'JobRouterAdministrationOperations_UpsertClassificationPolicy' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L139
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L149
⚠️ SchemaTypeAndFormat	Schema with type: string has unrecognized format: eTag Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L175
⚠️ SchemaTypeAndFormat	Schema with type: string has unrecognized format: eTag Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L192
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L229
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L237
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L270
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L318
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L326
⚠️ SchemaTypeAndFormat	Schema with type: string has unrecognized format: eTag Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L337
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L371
⚠️ OperationId	OperationId for patch method should contain both 'Create' and 'Update' Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L372
⚠️ PatchInOperationName	'PATCH' operation 'JobRouterAdministrationOperations_UpsertDistributionPolicy' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L372
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L382
⚠️ SchemaTypeAndFormat	Schema with type: string has unrecognized format: eTag Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L408
⚠️ SchemaTypeAndFormat	Schema with type: string has unrecognized format: eTag Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L425
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L462
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L470
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L503
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L551
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L559
⚠️ SchemaTypeAndFormat	Schema with type: string has unrecognized format: eTag Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L570
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L604
⚠️ OperationId	OperationId for patch method should contain both 'Create' and 'Update' Location: JobRouter/stable/2023-11-01/communicationservicejobrouter.json#L605

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-10T03:49:26Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 752c7a5. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/communication/data-plane/JobRouter/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to packe sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.Communication.JobRouter [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 752c7a5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/communication/data-plane/JobRouter/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️azure-communication-jobrouter [View full logs] [Release SDK Changes]
- azure_communication_jobrouter-1.0.0-py3-none-any.whl
- azure-communication-jobrouter-1.0.0.zip
```
info	[Changelog] data-plan skip changelog generation temporarily
```

️❌ azure-sdk-for-java failed [Detail]

❌Failed [Logs]Release - Generate from 752c7a5. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
warn		specification/communication/data-plane/JobRouter/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py]  WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/[email protected]',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py]
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 10.2.3
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
cmderr	[generate.py] npm notice Run `npm install -g [email protected]` to update!
cmderr	[generate.py] npm notice

❌azure-communication-jobrouter [View full logs] [Release SDK Changes]
- pom.xml

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 752c7a5. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
warn		specification/communication/data-plane/JobRouter/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Generate changelog failed: ENOENT: no such file or directory, open '/mnt/vss/_work/1/s/azure-sdk-for-js/sdk/communication/communication-job-router-rest/changelog-temp/package/CHANGELOG.md'

️✔️@azure-rest/communication-job-router [View full logs] [Release SDK Changes]
- azure-rest-communication-job-router-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-10T03:49:26Z

Generated ApiView

Language	Package Name	ApiView Link
Python	azure-communication-jobrouter	https://apiview.dev/Assemblies/Review/6040bcd7a00944a384224b73da6d7872
JavaScript	@azure-rest/communication-job-router	https://apiview.dev/Assemblies/Review/16645dedace64536a2d3ab7c5943cea2

…m' of https://github.com/sarkar-rajarshi/azure-rest-api-specs into rsarkar/jobrouter/try-representing-discriminator-as-enum

sarkar-rajarshi · 2023-11-13T18:32:52Z

@jhendrixMSFT this is ready to be merged

weidongxu-microsoft · 2023-11-14T01:54:06Z

Breaking changes approved by Jeffrey. Change to client.tsp verified by the team. Change to example files are expected.

openapi-pipeline-app · 2023-11-14T02:06:50Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

…or all polymorphic base class (#26658) * change discriminators to enum instead of string * Mark list methods as internal * update examples * update typespec-ts option * update examples * Suppress DISCRIMINATOR_NOT_REQUIRED and INVALID_DISCRIMINATOR_TYPE * Update projected list method names for csharp * Revert * add missing package-dir in tspconfig --------- Co-authored-by: williamzhao87 <[email protected]> Co-authored-by: Mike Harder <[email protected]>

change discriminators to enum instead of string

c4458a5

sarkar-rajarshi force-pushed the rsarkar/jobrouter/try-representing-discriminator-as-enum branch from db1f6f8 to c4458a5 Compare November 10, 2023 03:56

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane labels Nov 10, 2023

williamzhao87 and others added 4 commits November 10, 2023 08:10

Mark list methods as internal

c741f51

update examples

44084a4

Merge branch 'rsarkar/jobrouter/try-representing-discriminator-as-enu…

cf5afb8

…m' of https://github.com/sarkar-rajarshi/azure-rest-api-specs into rsarkar/jobrouter/try-representing-discriminator-as-enum

update typespec-ts option

01c07b0

azure-sdk mentioned this pull request Nov 10, 2023

[AutoPR @azure-rest/communication-job-router] [ACS JobRouter][GA] Change discriminators to enum instead of string for all polymorphic base class azure-sdk/azure-sdk-for-js#7636

Closed

update examples

f11b08c

sarkar-rajarshi marked this pull request as ready for review November 10, 2023 18:33

sarkar-rajarshi requested a review from a team as a code owner November 10, 2023 18:33

sarkar-rajarshi requested review from stewartadam and weidongxu-microsoft and removed request for a team November 10, 2023 18:33

openapi-assignment-bot bot assigned jhendrixMSFT Nov 10, 2023

Suppress DISCRIMINATOR_NOT_REQUIRED and INVALID_DISCRIMINATOR_TYPE

587e5f3

AzureRestAPISpecReview added the SuppressionReviewRequired label Nov 11, 2023

mikeharder added the Approved-Suppression label Nov 11, 2023

This was referenced Nov 11, 2023

[Breaking Change] Rule "AddedXmsEnum" treats "string" and "open enum" as incompatible Azure/azure-sdk-tools#7271

Open

[Breaking Change] Rule "ReferenceRedirection" treats "$ref" and equivalent primitive type as incompatible Azure/azure-sdk-tools#7272

Open

williamzhao87 added 2 commits November 13, 2023 09:38

Update projected list method names for csharp

694ae62

Revert

75065f7

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 13, 2023

weidongxu-microsoft approved these changes Nov 14, 2023

View reviewed changes

add missing package-dir in tspconfig

524b6f5

azure-sdk mentioned this pull request Nov 14, 2023

[AutoPR azure-communication-jobrouter] [ACS JobRouter][GA] Change discriminators to enum instead of string for all polymorphic base class azure-sdk/azure-sdk-for-java#8478

Closed

weidongxu-microsoft merged commit 752c7a5 into Azure:main Nov 14, 2023
29 of 31 checks passed

sarkar-rajarshi deleted the rsarkar/jobrouter/try-representing-discriminator-as-enum branch November 14, 2023 02:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ACS JobRouter][GA] Change discriminators to enum instead of string for all polymorphic base class #26658

[ACS JobRouter][GA] Change discriminators to enum instead of string for all polymorphic base class #26658

sarkar-rajarshi commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

sarkar-rajarshi commented Nov 13, 2023

weidongxu-microsoft commented Nov 14, 2023

openapi-pipeline-app bot commented Nov 14, 2023

[ACS JobRouter][GA] Change discriminators to enum instead of string for all polymorphic base class #26658

[ACS JobRouter][GA] Change discriminators to enum instead of string for all polymorphic base class #26658

Conversation

sarkar-rajarshi commented Nov 10, 2023 • edited Loading

openapi-pipeline-app bot commented Nov 10, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Nov 10, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 10, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 10, 2023 • edited Loading

Generated ApiView

sarkar-rajarshi commented Nov 13, 2023

weidongxu-microsoft commented Nov 14, 2023

openapi-pipeline-app bot commented Nov 14, 2023

sarkar-rajarshi commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading