[Hub Generated] Review request for Microsoft.Community to add version stable/2023-11-01 #26571

dshravani · 2023-11-06T16:43:01Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-11-06T16:43:05Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-11-06T16:43:06Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2023-11-01	package-2023-11-01(f98ddbc)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-06T16:43:07Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from fa7d797. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/communitytraining/Community.Management/tspconfig.yaml skipped due to azure-sdk-for-python-track2 not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-communitytraining [View full logs] [Release SDK Changes]
- azure-mgmt-communitytraining-1.0.0b1.zip
- azure_mgmt_communitytraining-1.0.0b1-py3-none-any.whl
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from fa7d797. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-communitytraining [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fa7d797. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
warn		specification/communitytraining/Community.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/communitytraining/armcommunitytraining [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fa7d797. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-communitytraining [View full logs] [Release SDK Changes]
- azure-arm-communitytraining-1.0.0.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from fa7d797. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.3
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️communitytraining [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from fa7d797. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
warn		specification/communitytraining/Community.Management/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.communitytraining.DefaultTag [View full logs]

Az.Community.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.communitytraining.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-06T16:43:08Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/communitytraining/armcommunitytraining	https://apiview.dev/Assemblies/Review/096630f11acc4b2abce631d680fe1d81
Java	azure-resourcemanager-communitytraining	https://apiview.dev/Assemblies/Review/0fe20f4fdfb847fd83f754dd8e0740e9
JavaScript	@azure/arm-communitytraining	https://apiview.dev/Assemblies/Review/66dde3df10dc4fef9acecb9a3760c28f

openapi-workflow-bot · 2023-11-06T16:49:20Z

Hi, @dshravani, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved.
Action Required:

Follow this guidance Naming for new initial management or client libraries (new SDKs) - Overview (azure.com) to create an issue for management client library name arch board review.

Paste the issue link that you created in step 1 in this PR

Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed.

zizw123 · 2023-11-07T19:22:51Z

/azp run

azure-pipelines · 2023-11-07T19:23:08Z

Azure Pipelines successfully started running 3 pipeline(s).

zizw123 · 2023-11-07T20:20:51Z

Please check the lint error https://github.com/Azure/azure-rest-api-specs/pull/26571/checks?check_run_id=18456259259

openapi-workflow-bot · 2023-11-07T20:21:01Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

dshravani · 2023-11-08T10:58:00Z

/azp run

azure-pipelines · 2023-11-08T10:58:15Z

Azure Pipelines successfully started running 3 pipeline(s).

dshravani · 2023-11-09T11:09:40Z

/pr RequestMerge

openapi-pipeline-app · 2023-11-09T17:50:30Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

… stable/2023-11-01 (#26571) * Generate new Service for communitytraining * Adding CommunityTrainings Specification

dshravani and others added 2 commits November 6, 2023 20:33

Generate new Service for communitytraining

da2472e

Adding CommunityTrainings Specification

f98ddbc

AzureRestAPISpecReview added new-api-version new-rp-namespace resource-manager RPaaS labels Nov 6, 2023

dshravani marked this pull request as ready for review November 6, 2023 17:46

dshravani requested review from msyyc, tadelesh, jsntcy and qiaozha as code owners November 6, 2023 17:46

openapi-assignment-bot bot assigned rkmanda Nov 6, 2023

AzureRestAPISpecReview added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 6, 2023

zizw123 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 7, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 7, 2023

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Nov 8, 2023

zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 8, 2023

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 8, 2023

microsoft-github-policy-service bot added the MergeRequested label Nov 9, 2023

zizw123 approved these changes Nov 9, 2023

View reviewed changes

zizw123 merged commit fa7d797 into main Nov 9, 2023
29 of 31 checks passed

zizw123 deleted the dshravani-communitytraining-Microsoft.Community-2023-11-01 branch November 9, 2023 17:50

zman-ms pushed a commit that referenced this pull request Jan 10, 2024

[Hub Generated] Review request for Microsoft.Community to add version…

ec9aa3b

… stable/2023-11-01 (#26571) * Generate new Service for communitytraining * Adding CommunityTrainings Specification

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Community to add version stable/2023-11-01 #26571

[Hub Generated] Review request for Microsoft.Community to add version stable/2023-11-01 #26571

dshravani commented Nov 6, 2023

openapi-pipeline-app bot commented Nov 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 6, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 6, 2023 •

edited

Loading

openapi-workflow-bot bot commented Nov 6, 2023

zizw123 commented Nov 7, 2023

azure-pipelines bot commented Nov 7, 2023

zizw123 commented Nov 7, 2023

openapi-workflow-bot bot commented Nov 7, 2023

dshravani commented Nov 8, 2023

azure-pipelines bot commented Nov 8, 2023

dshravani commented Nov 9, 2023

openapi-pipeline-app bot commented Nov 9, 2023

[Hub Generated] Review request for Microsoft.Community to add version stable/2023-11-01 #26571

[Hub Generated] Review request for Microsoft.Community to add version stable/2023-11-01 #26571

Conversation

dshravani commented Nov 6, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Nov 6, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Nov 6, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Nov 6, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Nov 6, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Nov 6, 2023

zizw123 commented Nov 7, 2023

azure-pipelines bot commented Nov 7, 2023

zizw123 commented Nov 7, 2023

openapi-workflow-bot bot commented Nov 7, 2023

dshravani commented Nov 8, 2023

azure-pipelines bot commented Nov 8, 2023

dshravani commented Nov 9, 2023

openapi-pipeline-app bot commented Nov 9, 2023

openapi-pipeline-app bot commented Nov 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 6, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 6, 2023 •

edited

Loading