Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space of "IPv6 FirewallRule" in Microsoft.SQL 2023-05-01-preview #26511

Merged
merged 1 commit into from
Nov 15, 2023

Remove space char of "IPv6 FirewallRule" in 2023-05-01-preview Micros…

3d58510
Select commit
Loading
Failed to load commit list.
Merged

Remove space of "IPv6 FirewallRule" in Microsoft.SQL 2023-05-01-preview #26511

Remove space char of "IPv6 FirewallRule" in 2023-05-01-preview Micros…
3d58510
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff completed Nov 15, 2023 in 2m 20s

Swagger LintDiff failed

LintDiff: 8 Errors, 6 Warnings
The check status is neutral due to the check was suppressed by label Approved-LintDiff. If you have any question, pls contact [email protected]
View more details.

Details

compared tags (via openapi-validator v2.1.6) new version base version
package-preview-2023-05 package-preview-2023-05(3d58510) package-preview-2023-05(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ RequiredPropertiesMissingInResourceModel Model definition 'IPv6FirewallRule' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L215		 RPC-Get-V1-03, RPC-Put-V1-08


The following errors/warnings exist before current PR submission:

Rule Message
❌ ResourceNameRestriction The resource name parameter 'serverName' should be defined with a 'pattern' restriction.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L19
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L47
❌ ResourceNameRestriction The resource name parameter 'serverName' should be defined with a 'pattern' restriction.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L61
❌ ResourceNameRestriction The resource name parameter 'firewallRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L61
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L96
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L149
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L199
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L26
⚠️ RequiredReadOnlySystemData The response of operation:'IPv6FirewallRules_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L62
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L68
⚠️ RequiredReadOnlySystemData The response of operation:'IPv6FirewallRules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L106
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L112
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Sql/preview/2023-05-01-preview/IPv6FirewallRules.json#L174
View more details on openapi-pipeline-app