Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK breaking change in 2017-10-01 DNS Swagger #2612

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Fix SDK breaking change in 2017-10-01 DNS Swagger #2612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15ee992
Fix SDK breaking change in 2017-10-01 DNS Swagger and add linter erro…
Mar 7, 2018
6fb8afc
Add scoping to error suppressions in 2017-10-01 DNS Swagger
Mar 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion specification/dns/resource-manager/Microsoft.Network/stable/2017-10-01/dns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/Zone"
"$ref": "#/definitions/ZoneUpdate"
},
"description": "Parameters supplied to the Update operation."
},
Expand Down Expand Up @@ -1465,6 +1465,18 @@
],
"description": "Describes a DNS zone."
},
"ZoneUpdate": {
"properties": {
"tags": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "Resource tags."
}
},
"description": "Describes a request to update a DNS zone."
},
"ZoneListResult": {
"properties": {
"value": {
Expand Down Expand Up @@ -1516,6 +1528,9 @@
"description": "Resource tags."
}
},
"required": [
"location"
],
"description": "Common properties of an Azure Resource Manager resource"
},
"SubResource": {
Expand Down
1 change: 0 additions & 1 deletion ...fication/dns/resource-manager/Microsoft.Network/stable/2017-10-01/examples/PatchZone.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"api-version": "2017-10-01",
"subscriptionId": "subid",
"parameters": {
"location": "Global",
"tags": {
"key2": "value2"
}
Expand Down
19 changes: 19 additions & 0 deletions specification/dns/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,25 @@ These settings apply only when `--tag=package-2017-10` is specified on the comma
``` yaml $(tag) == 'package-2017-10'
input-file:
- Microsoft.Network/stable/2017-10-01/dns.json
directive:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directive [](start = 0, length = 9)

Supressions should also include where they should happen.
Take a look here https://github.com/Azure/autorest/blob/master/src/autorest-core/test/variations/suppressions/readme.md

- where:
- $.paths
suppress:
- OperationsAPIImplementation
- where:
- $.definitions.RecordSetProperties.properties.TTL
- $.definitions.RecordSetProperties.properties.ARecords
- $.definitions.RecordSetProperties.properties.AAAARecords
- $.definitions.RecordSetProperties.properties.MXRecords
- $.definitions.RecordSetProperties.properties.NSRecords
- $.definitions.RecordSetProperties.properties.PTRRecords
- $.definitions.RecordSetProperties.properties.SRVRecords
- $.definitions.RecordSetProperties.properties.TXTRecords
- $.definitions.RecordSetProperties.properties.CNAMERecord
- $.definitions.RecordSetProperties.properties.SOARecord
- $.definitions.RecordSetUpdateParameters.properties.RecordSet
suppress:
- DefinitionsPropertiesNamesCamelCase
```

### Tag: package-2017-09
Expand Down