Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typespec-next] React to Azure/typespec-azure#3597 #26023

Merged
merged 2 commits into from
Sep 29, 2023
Merged

[typespec-next] React to Azure/typespec-azure#3597 #26023

merged 2 commits into from
Sep 29, 2023

Conversation

mikeharder
Copy link
Member

  • React to Azure/typespec-azure#3597
  • Suppress because auth scheme is supported by openapi3 and dpg

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 29, 2023 •
edited
Loading

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 29, 2023 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
EventGrid.json 2023-06-01-preview(e649582) 2023-06-01-preview(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.5) new version base version
package-2023-06-01-preview package-2023-06-01-preview(e649582) package-2023-06-01-preview(typespec-next)

The following errors/warnings exist before current PR submission:

Rule Message
⚠️ SecurityDefinitionDescription Security definition should have a description.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L45
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L58
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L67
⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L115
⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L115
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L116
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L122
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L129
⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L184
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L185
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L191
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L198
⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L243
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L244
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L250
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L257
⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L302
⚠️ OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L303
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L309
⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L316
⚠️ SchemaNamesConvention Schema name should be Pascal case.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L403
⚠️ SchemaNamesConvention Schema name should be Pascal case.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L437
⚠️ SchemaNamesConvention Schema name should be Pascal case.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L450
⚠️ PropertyType Property should have a defined type.
Location: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L495
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️❌TypeSpecAPIView: 0 Errors, 1 Warnings failed [Detail]
Rule Message
⚠️ Failed to generate TypeSpec APIView. Please check the detail log and make sure TypeSpec compiler version is the latest. "How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR."
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
Rule Message
❌ INVALID_TYPE Expected type but found type object
Url: Microsoft.EventGrid/preview/2023-06-01-preview/EventGrid.json#L87:22
ExampleUrl: preview/2023-06-01-preview/examples/publish.json#L24:16
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 29, 2023 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking


️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 6f7851be193baf0c732e64a51cbf730eaaedae49. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/eventgrid/Azure.Messaging.EventGrid/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.Messaging.EventGrid [View full logs]  [Preview SDK Changes] 
    info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning [Logs] Generate from 6f7851be193baf0c732e64a51cbf730eaaedae49. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/eventgrid/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh]  New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
  • ️✔️azure-eventgrid [View full logs]  [Preview SDK Changes] 
    info	[Changelog] data-plan skip changelog generation temporarily
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 29, 2023 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Python azure-eventgrid https://apiview.dev/Assemblies/Review/1fc6399cb46f433d92e012eb7a7379bc
.Net Azure.Messaging.EventGrid There is no API change compared with the previous version
Swagger Microsoft.Storage https://apiview.dev/Assemblies/Review/2eecdbd8633a492c9ebc0a8b133422c9

@mikeharder mikeharder requested a review from daviwil September 29, 2023 02:02
This was referenced Sep 29, 2023
Closed
Closed
@mikeharder mikeharder changed the title React to Azure/typespec-azure#3597 [typespec-next] React to Azure/typespec-azure#3597 Sep 29, 2023
@mikeharder mikeharder merged commit 30989f7 into Azure:typespec-next Sep 29, 2023
@mikeharder mikeharder deleted the react-3597 branch September 29, 2023 03:10
@mikeharder mikeharder self-assigned this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@l0lawrence l0lawrence Awaiting requested review from l0lawrence l0lawrence is a code owner

@Kishp01 Kishp01 Awaiting requested review from Kishp01

@ahamad-MS ahamad-MS Awaiting requested review from ahamad-MS

@daviwil daviwil Awaiting requested review from daviwil

Assignees

@mikeharder mikeharder

Labels
data-plane
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeharder @timotheeguerin @AzureRestAPISpecReview