-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenAI] Refactor project structure #25986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
generated.json | 2023-06-01-preview(6925d49) | 2023-06-01-preview(main) |
generated.json | 2023-07-01-preview(6925d49) | 2023-07-01-preview(main) |
generated.json | 2023-08-01-preview(6925d49) | 2023-08-01-preview(main) |
generated.json | 2023-09-01-preview(6925d49) | 2023-09-01-preview(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
release_2023_06_01_preview_autogen | release_2023_06_01_preview_autogen(6925d49) | release_2023_06_01_preview_autogen(main) |
release_2023_07_01_preview_autogen | release_2023_07_01_preview_autogen(6925d49) | release_2023_07_01_preview_autogen(main) |
release_2023_08_01_preview_autogen | release_2023_08_01_preview_autogen(6925d49) | release_2023_08_01_preview_autogen(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 4 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
OBJECT_MISSING_REQUIRED_PROPERTY |
Missing required property: file Url: inference/preview/2023-09-01-preview/generated.json#L1945:39 ExampleUrl: preview/2023-09-01-preview/examples/audio_transcription_object.json |
OBJECT_MISSING_REQUIRED_PROPERTY |
Missing required property: file Url: inference/preview/2023-09-01-preview/generated.json#L2034:37 ExampleUrl: preview/2023-09-01-preview/examples/audio_translation_object.json |
OBJECT_MISSING_REQUIRED_PROPERTY |
Missing required property: file Url: inference/preview/2023-09-01-preview/generated.json#L1945:39 ExampleUrl: preview/2023-09-01-preview/examples/audio_transcription_object.json |
OBJECT_MISSING_REQUIRED_PROPERTY |
Missing required property: file Url: inference/preview/2023-09-01-preview/generated.json#L2034:37 ExampleUrl: preview/2023-09-01-preview/examples/audio_translation_object.json |
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Sep 27, 2023
Closed
jpalvarezl
changed the title
Jpalvarezl/proj structure refactor
[OpenAI] Refactor project structure
Sep 27, 2023
trrwilson
approved these changes
Oct 6, 2023
3 tasks
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Oct 10, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Somehow after compiling the examples are gone * Renamed model files * Re-structured project * Added fix for example directory * Corrected example * Corrected documentation issue * Added new word to custom-word list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring project structure. Originally introduced in this draft PR for Whisper