[Microsoft.Workoads] Adding a new Api-version 2023-10-01-preview #25896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushantyadav-msft
requested review from
msyyc,
tadelesh,
jsntcy and
qiaozha
as code owners
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
Generated ApiView
|
sushantyadav-msft
changed the title
This was referenced Sep 21, 2023
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
|
Hi @sushantyadav-msft! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
This was referenced Sep 21, 2023
...er/Microsoft.Workloads/SAPVirtualInstance/preview/2023-10-01-preview/SAPVirtualInstance.json
Outdated
Show resolved
Hide resolved
sushantyadav-msft
force-pushed
the
sushantyadav-msft-workloads-Microsoft.Workloads-new-2023-10-01-preview
branch
from
51ad193 to
70a364a
Compare
sushantyadav-msft
added
MergeRequested
and removed
DoNotMerge
|
please remove 200 from DELETE to fix lint error in https://github.com/Azure/azure-rest-api-specs/pull/25896/checks?check_run_id=17558768092. Then readd MergeRequest label |
AzureRestAPISpecReview
added
the
ReadyForApiTest
ms-zhenhua
approved these changes
Oct 12, 2023
ms-zhenhua
deleted the
sushantyadav-msft-workloads-Microsoft.Workloads-new-2023-10-01-preview
branch
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Oct 12, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
) * Copying the previous version to the new version folder * Changed the swagger version to the new one * Updating the new version changes * Updated examples for the new versions * Reverting change in the existing version swagger * Fixing the semantic validation error * upgrading to v5 for common file * Adding x-ms-long-running-operation in Patch call * Updated the return code from 201 to 202 for Patch calls * Fixes for model validation * Fixing prettier check * Added patch call schema * Update the patch update sap instance property structure * Update location in examples and object description changes * Removed 200 code for Delete to fix the linter check * Removed 200 code for child instance delete calls
kazrael2119
reviewed
Dec 26, 2023
| "SAPRecommendations" | ||
| ], | ||
| "description": "Get SAP sizing recommendations by providing input SAPS for application tier and memory required for database tier", | ||
| "operationId": "SAPSizingRecommendations", |
There was a problem hiding this comment.
follow https://github.com/Azure/azure-openapi-validator/blob/main/docs/operation-id.md#output-message,
I don't think this operation ID is valid here
same issue in L99, L155 and L205
There was a problem hiding this comment.
The operationId seems wired to me, but it is released in previous version. @weidongxu-microsoft how do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
This is to add a new api version 2023-10-01-preview for Microsoft.workloads/sapvirtualinstances resource type. This is already present in the private repo.
Couldn't use the Open API hub tool because we're moving to a new folder structure where each RT under the RP will have their own versioning.
The linter check getting failed is a false positive and seems like a bug in the spec validation automation.
Requesting to review the changes in the PR.
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.