[Hub Generated] Review request for Microsoft.AzureStackHCI to add version stable/2023-08-01 #25859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| arcSettings.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| arcSettings.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
| clusters.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| clusters.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
| extensions.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| extensions.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
| offers.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| offers.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
| operations.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| operations.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
| publishers.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| publishers.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
| skus.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| skus.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
| updateRuns.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| updateRuns.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
| updateSummaries.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| updateSummaries.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
| updates.json | 2023-08-01(a8f6409) | 2023-06-01(main) |
| updates.json | 2023-08-01(a8f6409) | 2022-12-15-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-2023-08 | package-2023-08(a8f6409) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/stable/2023-08-01/extensions.json#L489 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L37 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L79 |
|
The resource name parameter 'arcSettingName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L79 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L120 |
|
The property 'tags' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L189 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L218 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L242 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L266 |
|
The resource name parameter 'arcSettingName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L266 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L311 |
|
The resource name parameter 'arcSettingName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L311 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L351 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L363 |
|
The resource name parameter 'arcSettingName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L363 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L408 |
|
The resource name parameter 'arcSettingName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L408 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L409 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L441 |
|
Missing identifier id in array item property Location: Microsoft.AzureStackHCI/stable/2023-08-01/arcSettings.json#L607 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L118 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L159 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L257 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L286 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L302 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L338 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L354 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L387 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L403 |
|
A 202 response should include an Location response header. Location: Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json#L445 |
|
The resource name parameter 'clusterName' should be defined with a 'pattern' restriction. Location: Microsoft.AzureStackHCI/stable/2023-08-01/extensions.json#L37 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=390023&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Unable to load the service index for source https://apidrop.pkgs.visualstudio.com/_packaging/ReferenceAutomationTool/nuget/v3/index.json." |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/azurestackhci/armazurestackhci - Approved - 2.0.0+ Function `*ExtensionsClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, string, Extension, *ExtensionsClientBeginUpdateOptions)` to `(context.Context, string, string, string, string, ExtensionPatch, *ExtensionsClientBeginUpdateOptions)`
❌azure-sdk-for-js - @azure/arm-azurestackhci - Approved - 4.0.0+ Operation Extensions.beginUpdate has a new signature + Operation Extensions.beginUpdateAndWait has a new signature
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-azurestackhci [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation ArcSettingsOperations.begin_initialize_disable_process info [Changelog] - Added operation ArcSettingsOperations.consent_and_install_default_extensions info [Changelog] - Added operation ClustersOperations.begin_extend_software_assurance_benefit info [Changelog] - Added operation ExtensionsOperations.begin_upgrade info [Changelog] - Added operation group OffersOperations info [Changelog] - Added operation group PublishersOperations info [Changelog] - Added operation group SkusOperations info [Changelog] - Added operation group UpdateRunsOperations info [Changelog] - Added operation group UpdateSummariesOperations info [Changelog] - Added operation group UpdatesOperations info [Changelog] - Model ArcConnectivityProperties has a new parameter service_configurations info [Changelog] - Model ArcSetting has a new parameter default_extensions info [Changelog] - Model ArcSetting has a new parameter system_data info [Changelog] - Model Cluster has a new parameter connectivity_status info [Changelog] - Model Cluster has a new parameter isolated_vm_attestation_configuration info [Changelog] - Model Cluster has a new parameter principal_id info [Changelog] - Model Cluster has a new parameter resource_provider_object_id info [Changelog] - Model Cluster has a new parameter software_assurance_properties info [Changelog] - Model Cluster has a new parameter system_data info [Changelog] - Model Cluster has a new parameter tenant_id info [Changelog] - Model Cluster has a new parameter type_identity_type info [Changelog] - Model Cluster has a new parameter user_assigned_identities info [Changelog] - Model ClusterNode has a new parameter ehc_resource_id info [Changelog] - Model ClusterNode has a new parameter last_licensing_timestamp info [Changelog] - Model ClusterNode has a new parameter node_type info [Changelog] - Model ClusterNode has a new parameter oem_activation info [Changelog] - Model ClusterNode has a new parameter os_display_version info [Changelog] - Model ClusterPatch has a new parameter principal_id info [Changelog] - Model ClusterPatch has a new parameter tenant_id info [Changelog] - Model ClusterPatch has a new parameter type info [Changelog] - Model ClusterPatch has a new parameter user_assigned_identities info [Changelog] - Model ClusterReportedProperties has a new parameter cluster_type info [Changelog] - Model ClusterReportedProperties has a new parameter manufacturer info [Changelog] - Model ClusterReportedProperties has a new parameter oem_activation info [Changelog] - Model ClusterReportedProperties has a new parameter supported_capabilities info [Changelog] - Model Extension has a new parameter enable_automatic_upgrade info [Changelog] - Model Extension has a new parameter managed_by info [Changelog] - Model Extension has a new parameter system_data info [Changelog] - Model PerNodeExtensionState has a new parameter instance_view info [Changelog] - Model PerNodeExtensionState has a new parameter type_handler_version info [Changelog] - Model ProxyResource has a new parameter system_data info [Changelog] - Model Resource has a new parameter system_data info [Changelog] - Model TrackedResource has a new parameter system_data info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model ArcSetting no longer has parameter created_at info [Changelog] - Model ArcSetting no longer has parameter created_by info [Changelog] - Model ArcSetting no longer has parameter created_by_type info [Changelog] - Model ArcSetting no longer has parameter last_modified_at info [Changelog] - Model ArcSetting no longer has parameter last_modified_by info [Changelog] - Model ArcSetting no longer has parameter last_modified_by_type info [Changelog] - Model Cluster no longer has parameter created_at info [Changelog] - Model Cluster no longer has parameter created_by info [Changelog] - Model Cluster no longer has parameter created_by_type info [Changelog] - Model Cluster no longer has parameter last_modified_at info [Changelog] - Model Cluster no longer has parameter last_modified_by info [Changelog] - Model Cluster no longer has parameter last_modified_by_type info [Changelog] - Model Extension no longer has parameter created_at info [Changelog] - Model Extension no longer has parameter created_by info [Changelog] - Model Extension no longer has parameter created_by_type info [Changelog] - Model Extension no longer has parameter last_modified_at info [Changelog] - Model Extension no longer has parameter last_modified_by info [Changelog] - Model Extension no longer has parameter last_modified_by_type
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-azurestackhci [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/azurestackhci/armazurestackhci [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Function `*ExtensionsClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, string, Extension, *ExtensionsClientBeginUpdateOptions)` to `(context.Context, string, string, string, string, ExtensionPatch, *ExtensionsClientBeginUpdateOptions)` info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New value `ArcSettingAggregateStateAccepted`, `ArcSettingAggregateStateDisableInProgress`, `ArcSettingAggregateStateProvisioning` added to enum type `ArcSettingAggregateState` info [Changelog] - New value `ExtensionAggregateStateAccepted`, `ExtensionAggregateStateProvisioning`, `ExtensionAggregateStateUpgradeFailedRollbackSucceeded` added to enum type `ExtensionAggregateState` info [Changelog] - New value `NodeArcStateAccepted`, `NodeArcStateDisableInProgress`, `NodeArcStateInProgress`, `NodeArcStatePartiallyConnected`, `NodeArcStatePartiallySucceeded`, `NodeArcStateProvisioning` added to enum type `NodeArcState` info [Changelog] - New value `NodeExtensionStateAccepted`, `NodeExtensionStateInProgress`, `NodeExtensionStatePartiallyConnected`, `NodeExtensionStatePartiallySucceeded`, `NodeExtensionStateProvisioning` added to enum type `NodeExtensionState` info [Changelog] - New value `ProvisioningStateConnected`, `ProvisioningStateCreating`, `ProvisioningStateDeleted`, `ProvisioningStateDeleting`, `ProvisioningStateDisableInProgress`, `ProvisioningStateDisconnected`, `ProvisioningStateError`, `ProvisioningStateInProgress`, `ProvisioningStateMoving`, `ProvisioningStateNotSpecified`, `ProvisioningStatePartiallyConnected`, `ProvisioningStatePartiallySucceeded`, `ProvisioningStateUpdating` added to enum type `ProvisioningState` info [Changelog] - New value `StatusFailed`, `StatusInProgress`, `StatusNotSpecified`, `StatusSucceeded` added to enum type `Status` info [Changelog] - New enum type `AvailabilityType` with values `AvailabilityTypeLocal`, `AvailabilityTypeNotify`, `AvailabilityTypeOnline` info [Changelog] - New enum type `ClusterNodeType` with values `ClusterNodeTypeFirstParty`, `ClusterNodeTypeThirdParty` info [Changelog] - New enum type `ConnectivityStatus` with values `ConnectivityStatusConnected`, `ConnectivityStatusDisconnected`, `ConnectivityStatusNotConnectedRecently`, `ConnectivityStatusNotSpecified`, `ConnectivityStatusNotYetRegistered`, `ConnectivityStatusPartiallyConnected` info [Changelog] - New enum type `ExtensionManagedBy` with values `ExtensionManagedByAzure`, `ExtensionManagedByUser` info [Changelog] - New enum type `HealthState` with values `HealthStateError`, `HealthStateFailure`, `HealthStateInProgress`, `HealthStateSuccess`, `HealthStateUnknown`, `HealthStateWarning` info [Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned` info [Changelog] - New enum type `OemActivation` with values `OemActivationDisabled`, `OemActivationEnabled` info [Changelog] - New enum type `RebootRequirement` with values `RebootRequirementFalse`, `RebootRequirementTrue`, `RebootRequirementUnknown` info [Changelog] - New enum type `ServiceName` with values `ServiceNameWAC` info [Changelog] - New enum type `Severity` with values `SeverityCritical`, `SeverityHidden`, `SeverityInformational`, `SeverityWarning` info [Changelog] - New enum type `SoftwareAssuranceIntent` with values `SoftwareAssuranceIntentDisable`, `SoftwareAssuranceIntentEnable` info [Changelog] - New enum type `SoftwareAssuranceStatus` with values `SoftwareAssuranceStatusDisabled`, `SoftwareAssuranceStatusEnabled` info [Changelog] - New enum type `State` with values `StateDownloadFailed`, `StateDownloading`, `StateHasPrerequisite`, `StateHealthCheckFailed`, `StateHealthChecking`, `StateInstallationFailed`, `StateInstalled`, `StateInstalling`, `StateInvalid`, `StateNotApplicableBecauseAnotherUpdateIsInProgress`, `StateObsolete`, `StatePreparationFailed`, `StatePreparing`, `StateReady`, `StateReadyToInstall`, `StateRecalled`, `StateScanFailed`, `StateScanInProgress` info [Changelog] - New enum type `StatusLevelTypes` with values `StatusLevelTypesError`, `StatusLevelTypesInfo`, `StatusLevelTypesWarning` info [Changelog] - New enum type `UpdateRunPropertiesState` with values `UpdateRunPropertiesStateFailed`, `UpdateRunPropertiesStateInProgress`, `UpdateRunPropertiesStateSucceeded`, `UpdateRunPropertiesStateUnknown` info [Changelog] - New enum type `UpdateSummariesPropertiesState` with values `UpdateSummariesPropertiesStateAppliedSuccessfully`, `UpdateSummariesPropertiesStateNeedsAttention`, `UpdateSummariesPropertiesStatePreparationFailed`, `UpdateSummariesPropertiesStatePreparationInProgress`, `UpdateSummariesPropertiesStateUnknown`, `UpdateSummariesPropertiesStateUpdateAvailable`, `UpdateSummariesPropertiesStateUpdateFailed`, `UpdateSummariesPropertiesStateUpdateInProgress` info [Changelog] - New function `*ArcSettingsClient.ConsentAndInstallDefaultExtensions(context.Context, string, string, string, *ArcSettingsClientConsentAndInstallDefaultExtensionsOptions) (ArcSettingsClientConsentAndInstallDefaultExtensionsResponse, error)` info [Changelog] - New function `*ArcSettingsClient.BeginInitializeDisableProcess(context.Context, string, string, string, *ArcSettingsClientBeginInitializeDisableProcessOptions) (*runtime.Poller[ArcSettingsClientInitializeDisableProcessResponse], error)` info [Changelog] - New function `*ClientFactory.NewOffersClient() *OffersClient` info [Changelog] - New function `*ClientFactory.NewPublishersClient() *PublishersClient` info [Changelog] - New function `*ClientFactory.NewSKUsClient() *SKUsClient` info [Changelog] - New function `*ClientFactory.NewUpdateRunsClient() *UpdateRunsClient` info [Changelog] - New function `*ClientFactory.NewUpdateSummariesClient() *UpdateSummariesClient` info [Changelog] - New function `*ClientFactory.NewUpdatesClient() *UpdatesClient` info [Changelog] - New function `*ClustersClient.BeginExtendSoftwareAssuranceBenefit(context.Context, string, string, SoftwareAssuranceChangeRequest, *ClustersClientBeginExtendSoftwareAssuranceBenefitOptions) (*runtime.Poller[ClustersClientExtendSoftwareAssuranceBenefitResponse], error)` info [Changelog] - New function `*ExtensionsClient.BeginUpgrade(context.Context, string, string, string, string, ExtensionUpgradeParameters, *ExtensionsClientBeginUpgradeOptions) (*runtime.Poller[ExtensionsClientUpgradeResponse], error)` info [Changelog] - New function `NewOffersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*OffersClient, error)` info [Changelog] - New function `*OffersClient.Get(context.Context, string, string, string, string, *OffersClientGetOptions) (OffersClientGetResponse, error)` info [Changelog] - New function `*OffersClient.NewListByClusterPager(string, string, *OffersClientListByClusterOptions) *runtime.Pager[OffersClientListByClusterResponse]` info [Changelog] - New function `*OffersClient.NewListByPublisherPager(string, string, string, *OffersClientListByPublisherOptions) *runtime.Pager[OffersClientListByPublisherResponse]` info [Changelog] - New function `NewPublishersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PublishersClient, error)` info [Changelog] - New function `*PublishersClient.Get(context.Context, string, string, string, *PublishersClientGetOptions) (PublishersClientGetResponse, error)` info [Changelog] - New function `*PublishersClient.NewListByClusterPager(string, string, *PublishersClientListByClusterOptions) *runtime.Pager[PublishersClientListByClusterResponse]` info [Changelog] - New function `NewSKUsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SKUsClient, error)` info [Changelog] - New function `*SKUsClient.Get(context.Context, string, string, string, string, string, *SKUsClientGetOptions) (SKUsClientGetResponse, error)` info [Changelog] - New function `*SKUsClient.NewListByOfferPager(string, string, string, string, *SKUsClientListByOfferOptions) *runtime.Pager[SKUsClientListByOfferResponse]` info [Changelog] - New function `NewUpdateRunsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpdateRunsClient, error)` info [Changelog] - New function `*UpdateRunsClient.BeginDelete(context.Context, string, string, string, string, *UpdateRunsClientBeginDeleteOptions) (*runtime.Poller[UpdateRunsClientDeleteResponse], error)` info [Changelog] - New function `*UpdateRunsClient.Get(context.Context, string, string, string, string, *UpdateRunsClientGetOptions) (UpdateRunsClientGetResponse, error)` info [Changelog] - New function `*UpdateRunsClient.NewListPager(string, string, string, *UpdateRunsClientListOptions) *runtime.Pager[UpdateRunsClientListResponse]` info [Changelog] - New function `*UpdateRunsClient.Put(context.Context, string, string, string, string, UpdateRun, *UpdateRunsClientPutOptions) (UpdateRunsClientPutResponse, error)` info [Changelog] - New function `NewUpdateSummariesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpdateSummariesClient, error)` info [Changelog] - New function `*UpdateSummariesClient.BeginDelete(context.Context, string, string, *UpdateSummariesClientBeginDeleteOptions) (*runtime.Poller[UpdateSummariesClientDeleteResponse], error)` info [Changelog] - New function `*UpdateSummariesClient.Get(context.Context, string, string, *UpdateSummariesClientGetOptions) (UpdateSummariesClientGetResponse, error)` info [Changelog] - New function `*UpdateSummariesClient.NewListPager(string, string, *UpdateSummariesClientListOptions) *runtime.Pager[UpdateSummariesClientListResponse]` info [Changelog] - New function `*UpdateSummariesClient.Put(context.Context, string, string, UpdateSummaries, *UpdateSummariesClientPutOptions) (UpdateSummariesClientPutResponse, error)` info [Changelog] - New function `NewUpdatesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpdatesClient, error)` info [Changelog] - New function `*UpdatesClient.BeginDelete(context.Context, string, string, string, *UpdatesClientBeginDeleteOptions) (*runtime.Poller[UpdatesClientDeleteResponse], error)` info [Changelog] - New function `*UpdatesClient.Get(context.Context, string, string, string, *UpdatesClientGetOptions) (UpdatesClientGetResponse, error)` info [Changelog] - New function `*UpdatesClient.NewListPager(string, string, *UpdatesClientListOptions) *runtime.Pager[UpdatesClientListResponse]` info [Changelog] - New function `*UpdatesClient.BeginPost(context.Context, string, string, string, *UpdatesClientBeginPostOptions) (*runtime.Poller[UpdatesClientPostResponse], error)` info [Changelog] - New function `*UpdatesClient.Put(context.Context, string, string, string, Update, *UpdatesClientPutOptions) (UpdatesClientPutResponse, error)` info [Changelog] - New struct `DefaultExtensionDetails` info [Changelog] - New struct `ExtensionInstanceView` info [Changelog] - New struct `ExtensionInstanceViewStatus` info [Changelog] - New struct `ExtensionPatch` info [Changelog] - New struct `ExtensionPatchParameters` info [Changelog] - New struct `ExtensionPatchProperties` info [Changelog] - New struct `ExtensionUpgradeParameters` info [Changelog] - New struct `IsolatedVMAttestationConfiguration` info [Changelog] - New struct `ManagedServiceIdentity` info [Changelog] - New struct `Offer` info [Changelog] - New struct `OfferList` info [Changelog] - New struct `OfferProperties` info [Changelog] - New struct `PackageVersionInfo` info [Changelog] - New struct `PrecheckResult` info [Changelog] - New struct `PrecheckResultTags` info [Changelog] - New struct `Publisher` info [Changelog] - New struct `PublisherList` info [Changelog] - New struct `PublisherProperties` info [Changelog] - New struct `SKU` info [Changelog] - New struct `SKUList` info [Changelog] - New struct `SKUMappings` info [Changelog] - New struct `SKUProperties` info [Changelog] - New struct `ServiceConfiguration` info [Changelog] - New struct `SoftwareAssuranceChangeRequest` info [Changelog] - New struct `SoftwareAssuranceChangeRequestProperties` info [Changelog] - New struct `SoftwareAssuranceProperties` info [Changelog] - New struct `Step` info [Changelog] - New struct `Update` info [Changelog] - New struct `UpdateList` info [Changelog] - New struct `UpdatePrerequisite` info [Changelog] - New struct `UpdateProperties` info [Changelog] - New struct `UpdateRun` info [Changelog] - New struct `UpdateRunList` info [Changelog] - New struct `UpdateRunProperties` info [Changelog] - New struct `UpdateStateProperties` info [Changelog] - New struct `UpdateSummaries` info [Changelog] - New struct `UpdateSummariesList` info [Changelog] - New struct `UpdateSummariesProperties` info [Changelog] - New struct `UserAssignedIdentity` info [Changelog] - New field `ServiceConfigurations` in struct `ArcConnectivityProperties` info [Changelog] - New field `DefaultExtensions` in struct `ArcSettingProperties` info [Changelog] - New field `Identity` in struct `Cluster` info [Changelog] - New field `EhcResourceID`, `LastLicensingTimestamp`, `NodeType`, `OSDisplayVersion`, `OemActivation` in struct `ClusterNode` info [Changelog] - New field `Identity` in struct `ClusterPatch` info [Changelog] - New field `ConnectivityStatus`, `IsolatedVMAttestationConfiguration`, `ResourceProviderObjectID`, `SoftwareAssuranceProperties` in struct `ClusterProperties` info [Changelog] - New field `ClusterType`, `Manufacturer`, `OemActivation`, `SupportedCapabilities` in struct `ClusterReportedProperties` info [Changelog] - New field `EnableAutomaticUpgrade` in struct `ExtensionParameters` info [Changelog] - New field `ManagedBy` in struct `ExtensionProperties` info [Changelog] - New field `InstanceView`, `TypeHandlerVersion` in struct `PerNodeExtensionState` info [Changelog] - New field `SystemData` in struct `ProxyResource` info [Changelog] - New field `SystemData` in struct `Resource` info [Changelog] - New field `SystemData` in struct `TrackedResource` info [Changelog] info [Changelog] Total 1 breaking change(s), 247 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️@azure/arm-azurestackhci [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - Added Type Alias SkusListByOfferResponse info [Changelog] - Added Type Alias SoftwareAssuranceIntent info [Changelog] - Added Type Alias SoftwareAssuranceStatus info [Changelog] - Added Type Alias State info [Changelog] - Added Type Alias StatusLevelTypes info [Changelog] - Added Type Alias UpdateRunPropertiesState info [Changelog] - Added Type Alias UpdateRunsGetResponse info [Changelog] - Added Type Alias UpdateRunsListNextResponse info [Changelog] - Added Type Alias UpdateRunsListResponse info [Changelog] - Added Type Alias UpdateRunsPutResponse info [Changelog] - Added Type Alias UpdatesGetResponse info [Changelog] - Added Type Alias UpdatesListNextResponse info [Changelog] - Added Type Alias UpdatesListResponse info [Changelog] - Added Type Alias UpdatesPutResponse info [Changelog] - Added Type Alias UpdateSummariesGetResponse info [Changelog] - Added Type Alias UpdateSummariesListNextResponse info [Changelog] - Added Type Alias UpdateSummariesListResponse info [Changelog] - Added Type Alias UpdateSummariesPropertiesState info [Changelog] - Added Type Alias UpdateSummariesPutResponse info [Changelog] - Interface ArcConnectivityProperties has a new optional parameter serviceConfigurations info [Changelog] - Interface ArcSetting has a new optional parameter defaultExtensions info [Changelog] - Interface Cluster has a new optional parameter connectivityStatus info [Changelog] - Interface Cluster has a new optional parameter isolatedVmAttestationConfiguration info [Changelog] - Interface Cluster has a new optional parameter principalId info [Changelog] - Interface Cluster has a new optional parameter resourceProviderObjectId info [Changelog] - Interface Cluster has a new optional parameter softwareAssuranceProperties info [Changelog] - Interface Cluster has a new optional parameter tenantId info [Changelog] - Interface Cluster has a new optional parameter typeIdentityType info [Changelog] - Interface Cluster has a new optional parameter userAssignedIdentities info [Changelog] - Interface ClusterNode has a new optional parameter ehcResourceId info [Changelog] - Interface ClusterNode has a new optional parameter lastLicensingTimestamp info [Changelog] - Interface ClusterNode has a new optional parameter nodeType info [Changelog] - Interface ClusterNode has a new optional parameter oemActivation info [Changelog] - Interface ClusterNode has a new optional parameter osDisplayVersion info [Changelog] - Interface ClusterPatch has a new optional parameter principalId info [Changelog] - Interface ClusterPatch has a new optional parameter tenantId info [Changelog] - Interface ClusterPatch has a new optional parameter type info [Changelog] - Interface ClusterPatch has a new optional parameter userAssignedIdentities info [Changelog] - Interface ClusterReportedProperties has a new optional parameter clusterType info [Changelog] - Interface ClusterReportedProperties has a new optional parameter manufacturer info [Changelog] - Interface ClusterReportedProperties has a new optional parameter oemActivation info [Changelog] - Interface ClusterReportedProperties has a new optional parameter supportedCapabilities info [Changelog] - Interface Extension has a new optional parameter enableAutomaticUpgrade info [Changelog] - Interface Extension has a new optional parameter managedBy info [Changelog] - Interface PerNodeExtensionState has a new optional parameter instanceView info [Changelog] - Interface PerNodeExtensionState has a new optional parameter typeHandlerVersion info [Changelog] - Interface Resource has a new optional parameter systemData info [Changelog] - Added Enum KnownAvailabilityType info [Changelog] - Added Enum KnownClusterNodeType info [Changelog] - Added Enum KnownConnectivityStatus info [Changelog] - Added Enum KnownExtensionManagedBy info [Changelog] - Added Enum KnownHealthState info [Changelog] - Added Enum KnownManagedServiceIdentityType info [Changelog] - Added Enum KnownOemActivation info [Changelog] - Added Enum KnownRebootRequirement info [Changelog] - Added Enum KnownServiceName info [Changelog] - Added Enum KnownSeverity info [Changelog] - Added Enum KnownSoftwareAssuranceIntent info [Changelog] - Added Enum KnownSoftwareAssuranceStatus info [Changelog] - Added Enum KnownState info [Changelog] - Added Enum KnownStatusLevelTypes info [Changelog] - Added Enum KnownUpdateRunPropertiesState info [Changelog] - Added Enum KnownUpdateSummariesPropertiesState info [Changelog] - Enum KnownArcSettingAggregateState has a new value Accepted info [Changelog] - Enum KnownArcSettingAggregateState has a new value DisableInProgress info [Changelog] - Enum KnownArcSettingAggregateState has a new value Provisioning info [Changelog] - Enum KnownExtensionAggregateState has a new value Accepted info [Changelog] - Enum KnownExtensionAggregateState has a new value Provisioning info [Changelog] - Enum KnownExtensionAggregateState has a new value UpgradeFailedRollbackSucceeded info [Changelog] - Enum KnownNodeArcState has a new value Accepted info [Changelog] - Enum KnownNodeArcState has a new value DisableInProgress info [Changelog] - Enum KnownNodeArcState has a new value InProgress info [Changelog] - Enum KnownNodeArcState has a new value PartiallyConnected info [Changelog] - Enum KnownNodeArcState has a new value PartiallySucceeded info [Changelog] - Enum KnownNodeArcState has a new value Provisioning info [Changelog] - Enum KnownNodeExtensionState has a new value Accepted info [Changelog] - Enum KnownNodeExtensionState has a new value InProgress info [Changelog] - Enum KnownNodeExtensionState has a new value PartiallyConnected info [Changelog] - Enum KnownNodeExtensionState has a new value PartiallySucceeded info [Changelog] - Enum KnownNodeExtensionState has a new value Provisioning info [Changelog] - Enum KnownProvisioningState has a new value Connected info [Changelog] - Enum KnownProvisioningState has a new value Creating info [Changelog] - Enum KnownProvisioningState has a new value Deleted info [Changelog] - Enum KnownProvisioningState has a new value Deleting info [Changelog] - Enum KnownProvisioningState has a new value DisableInProgress info [Changelog] - Enum KnownProvisioningState has a new value Disconnected info [Changelog] - Enum KnownProvisioningState has a new value Error info [Changelog] - Enum KnownProvisioningState has a new value InProgress info [Changelog] - Enum KnownProvisioningState has a new value Moving info [Changelog] - Enum KnownProvisioningState has a new value NotSpecified info [Changelog] - Enum KnownProvisioningState has a new value PartiallyConnected info [Changelog] - Enum KnownProvisioningState has a new value PartiallySucceeded info [Changelog] - Enum KnownProvisioningState has a new value Updating info [Changelog] - Enum KnownStatus has a new value Failed info [Changelog] - Enum KnownStatus has a new value InProgress info [Changelog] - Enum KnownStatus has a new value NotSpecified info [Changelog] - Enum KnownStatus has a new value Succeeded info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Operation Extensions.beginUpdate has a new signature info [Changelog] - Operation Extensions.beginUpdateAndWait has a new signature info [Changelog] - Interface ArcSetting no longer has parameter createdAt info [Changelog] - Interface ArcSetting no longer has parameter createdBy info [Changelog] - Interface ArcSetting no longer has parameter createdByType info [Changelog] - Interface ArcSetting no longer has parameter lastModifiedAt info [Changelog] - Interface ArcSetting no longer has parameter lastModifiedBy info [Changelog] - Interface ArcSetting no longer has parameter lastModifiedByType info [Changelog] - Interface Cluster no longer has parameter createdAt info [Changelog] - Interface Cluster no longer has parameter createdBy info [Changelog] - Interface Cluster no longer has parameter createdByType info [Changelog] - Interface Cluster no longer has parameter lastModifiedAt info [Changelog] - Interface Cluster no longer has parameter lastModifiedBy info [Changelog] - Interface Cluster no longer has parameter lastModifiedByType info [Changelog] - Interface Extension no longer has parameter createdAt info [Changelog] - Interface Extension no longer has parameter createdBy info [Changelog] - Interface Extension no longer has parameter createdByType info [Changelog] - Interface Extension no longer has parameter lastModifiedAt info [Changelog] - Interface Extension no longer has parameter lastModifiedBy info [Changelog] - Interface Extension no longer has parameter lastModifiedByType
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
️❌ azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
️✔️Az.azurestackhci.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.azurestackhci.DefaultTag
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
|
For breaking change: https://msazure.visualstudio.com/One/_workitems/edit/25215223 |
|
Changes have been reviewed and merged in RPSaaSMaster: |
|
Changes previously reviewed and approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/14126 |
priyjain358
added
the
WaitForARMFeedback
openapi-workflow-bot
bot
removed
the
ARMSignedOff
|
Hi @raosuhas , LintDiff is failing for existing properties. ExtensionPatch properties are just a subset of the properties that are there for PUT. Hence, we can't change the definition for those. |
sjanamma
reviewed
Oct 5, 2023
...ation/azurestackhci/resource-manager/Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json
Show resolved
Hide resolved
sjanamma
reviewed
Oct 5, 2023
...ion/azurestackhci/resource-manager/Microsoft.AzureStackHCI/stable/2023-08-01/extensions.json
Show resolved
Hide resolved
sjanamma
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
priyjain358
added
the
EP-Edge-ARMSignedOff
...ation/azurestackhci/resource-manager/Microsoft.AzureStackHCI/stable/2023-08-01/clusters.json
Outdated
Show resolved
Hide resolved
|
/pr RequestMerge |
ms-zhenhua
approved these changes
Oct 9, 2023
ms-zhenhua
deleted the
priyjain358-azurestackhci-Microsoft.AzureStackHCI-2023-08-01
branch
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This was referenced Oct 9, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…sion stable/2023-08-01 (#25859) * Adds base for updating Microsoft.AzureStackHCI from version stable/2023-06-01 to version 2023-08-01 * Updates readme * Updates API version in new specs and examples * exsting api changes * adding TVM properties * update tvm and add connectivity status * prettier fix * reslving comments * lint fix * revert change * suppressing lint * fix x-ms-arm0id scope * pretty fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.