Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed Instance swagger to support Authentication Metadata #25795

Merged
merged 9 commits into from
Oct 6, 2023

missing character

e965020
Select commit
Loading
Failed to load commit list.
Merged

Managed Instance swagger to support Authentication Metadata #25795

missing character
e965020
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded Sep 25, 2023 in 6m 39s

Swagger LintDiff succeeded

LintDiff
View more details.

Details

compared tags (via openapi-validator v2.1.5) new version base version
package-preview-2023-05 package-preview-2023-05(e965020) package-preview-2023-05(release-sql-Microsoft.Sql-2023-05-01-preview)

The following errors/warnings exist before current PR submission:

Rule Message
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L48
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L104
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L153
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L205
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L257
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L304
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L357
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L422
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L465
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L556
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L602
❌ DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L728
❌ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L1652
⚠️ RequiredReadOnlySystemData The response of operation:'ManagedInstances_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L171
⚠️ RequiredReadOnlySystemData The response of operation:'ManagedInstances_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L221
⚠️ RequiredReadOnlySystemData The response of operation:'ManagedInstances_Update' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L321
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'refreshexternalgovernancestatus' in:'ManagedInstances_RefreshStatus'. Consider updating the operationId
Location: Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json#L485
View more details on openapi-pipeline-app