Use format: arm-id in Redis and RedisEnterprise where appropriate #25517

matthchr · 2023-08-24T18:14:46Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-08-24T18:14:49Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-08-24T18:14:50Z

Swagger Validation Report

️❌BreakingChange: 7 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
redis.json	2023-04-01(63933c0)	2023-04-01(main)
redisenterprise.json	2023-07-01(63933c0)	2023-07-01(main)

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2023-04-01/redis.json#L2043:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L2043:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2023-04-01/redis.json#L2612:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L2601:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2023-04-01/redis.json#L2043:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L2043:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2023-04-01/redis.json#L2677:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L2658:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2023-04-01/redis.json#L2677:9 Old: Microsoft.Cache/stable/2023-04-01/redis.json#L2658:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1701:9 Old: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1701:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1843:11 Old: Microsoft.Cache/stable/2023-07-01/redisenterprise.json#L1835:11

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-2023-04	package-2023-04(63933c0)	package-2023-04(main)
package-2023-07	package-2023-07(63933c0)	package-2023-07(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2023-04-01/redis.json#L73
`❌` MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L1856
`❌` MissingTypeObject	The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L1896
`❌` MissingTypeObject	The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2037
`❌` MissingTypeObject	The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2080
`❌` MissingTypeObject	The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2095
`❌` MissingTypeObject	The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2178
`❌` MissingTypeObject	The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2218
`❌` MissingTypeObject	The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2239
`❌` MissingTypeObject	The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2254
`❌` MissingTypeObject	The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2280
`❌` MissingTypeObject	The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2297
`❌` MissingTypeObject	The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2314
`❌` MissingTypeObject	The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2343
`❌` MissingTypeObject	The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2381
`❌` MissingTypeObject	The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2398
`❌` MissingTypeObject	The schema 'RedisRebootParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2418
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2440
`❌` MissingTypeObject	The schema 'ExportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2448
`❌` MissingTypeObject	The schema 'ImportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2477
`❌` MissingTypeObject	The schema 'ScheduleEntry' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2504
`❌` MissingTypeObject	The schema 'ScheduleEntries' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2542
`❌` MissingTypeObject	The schema 'RedisPatchSchedule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2559
`❌` TrackedResourcePatchOperation	Tracked resource 'RedisPatchSchedule' must have patch operation that at least supports the update of tags. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2559
`❌` MissingTypeObject	The schema 'RedisPatchScheduleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2582
`❌` MissingTypeObject	The schema 'RedisForceRebootResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2599
`❌` MissingTypeObject	The schema 'RedisLinkedServer' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2609
`❌` MissingTypeObject	The schema 'RedisLinkedServerWithProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2627
`❌` MissingTypeObject	The schema 'RedisLinkedServerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2642
`❌` MissingTypeObject	The schema 'RedisLinkedServerWithPropertiesList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-04-01/redis.json#L2657

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-24T18:14:51Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/redisenterprise/armredisenterprise - 2.0.0

+	Operation `*PrivateEndpointConnectionsClient.Delete` has been changed to LRO, use `*PrivateEndpointConnectionsClient.BeginDelete` instead.

❌azure-sdk-for-python-track2 - track2_azure-mgmt-redisenterprise - 2.0.0

+	Renamed operation PrivateEndpointConnectionsOperations.delete to PrivateEndpointConnectionsOperations.begin_delete

❌azure-sdk-for-js - @azure/arm-redisenterprisecache - 3.0.0

+	Removed operation PrivateEndpointConnections.delete

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from e9029be. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Redis [View full logs] [Release SDK Changes]
```
info	[Changelog]
```
️✔️Azure.ResourceManager.RedisEnterprise [View full logs] [Release SDK Changes]
- Azure.ResourceManager.RedisEnterprise.1.1.0-alpha.20230913.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from e9029be. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh]  New major version of npm available! 9.6.7 -> 10.1.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-redis [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation RedisOperations.begin_flush_cache
info	[Changelog]   - Added operation group AccessPolicyAssignmentOperations
info	[Changelog]   - Added operation group AccessPolicyOperations
info	[Changelog]   - Model RedisCommonProperties has a new parameter update_channel
info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter aad_enabled
info	[Changelog]   - Model RedisCreateParameters has a new parameter update_channel
info	[Changelog]   - Model RedisCreateProperties has a new parameter update_channel
info	[Changelog]   - Model RedisProperties has a new parameter update_channel
info	[Changelog]   - Model RedisResource has a new parameter update_channel
info	[Changelog]   - Model RedisUpdateParameters has a new parameter update_channel
info	[Changelog]   - Model RedisUpdateProperties has a new parameter update_channel

️✔️track2_azure-mgmt-redisenterprise [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation RedisEnterpriseOperations.check_name_availability
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Renamed operation PrivateEndpointConnectionsOperations.delete to PrivateEndpointConnectionsOperations.begin_delete

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from e9029be. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-redis-generated [View full logs] [Release SDK Changes]
️✔️azure-resourcemanager-redisenterprise [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e9029be. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/redis/armredis [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `OperationStatus.Error` has been changed from `*ErrorDetailAutoGenerated` to `*ErrorDetail`
info	[Changelog] - Type of `OperationStatusResult.Error` has been changed from `*ErrorDetailAutoGenerated` to `*ErrorDetail`
info	[Changelog] - Struct `ErrorDetailAutoGenerated` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ProvisioningStateConfiguringAAD` added to enum type `ProvisioningState`
info	[Changelog] - New enum type `AccessPolicyAssignmentProvisioningState` with values `AccessPolicyAssignmentProvisioningStateCanceled`, `AccessPolicyAssignmentProvisioningStateDeleted`, `AccessPolicyAssignmentProvisioningStateDeleting`, `AccessPolicyAssignmentProvisioningStateFailed`, `AccessPolicyAssignmentProvisioningStateSucceeded`, `AccessPolicyAssignmentProvisioningStateUpdating`
info	[Changelog] - New enum type `AccessPolicyProvisioningState` with values `AccessPolicyProvisioningStateCanceled`, `AccessPolicyProvisioningStateDeleted`, `AccessPolicyProvisioningStateDeleting`, `AccessPolicyProvisioningStateFailed`, `AccessPolicyProvisioningStateSucceeded`, `AccessPolicyProvisioningStateUpdating`
info	[Changelog] - New enum type `AccessPolicyType` with values `AccessPolicyTypeBuiltIn`, `AccessPolicyTypeCustom`
info	[Changelog] - New enum type `UpdateChannel` with values `UpdateChannelPreview`, `UpdateChannelStable`
info	[Changelog] - New function `NewAccessPolicyAssignmentClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AccessPolicyAssignmentClient, error)`
info	[Changelog] - New function `*AccessPolicyAssignmentClient.BeginCreateUpdate(context.Context, string, string, string, CacheAccessPolicyAssignment, *AccessPolicyAssignmentClientBeginCreateUpdateOptions) (*runtime.Poller[AccessPolicyAssignmentClientCreateUpdateResponse], error)`
info	[Changelog] - New function `*AccessPolicyAssignmentClient.BeginDelete(context.Context, string, string, string, *AccessPolicyAssignmentClientBeginDeleteOptions) (*runtime.Poller[AccessPolicyAssignmentClientDeleteResponse], error)`
info	[Changelog] - New function `*AccessPolicyAssignmentClient.Get(context.Context, string, string, string, *AccessPolicyAssignmentClientGetOptions) (AccessPolicyAssignmentClientGetResponse, error)`
info	[Changelog] - New function `*AccessPolicyAssignmentClient.NewListPager(string, string, *AccessPolicyAssignmentClientListOptions) *runtime.Pager[AccessPolicyAssignmentClientListResponse]`
info	[Changelog] - New function `NewAccessPolicyClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AccessPolicyClient, error)`
info	[Changelog] - New function `*AccessPolicyClient.BeginCreateUpdate(context.Context, string, string, string, CacheAccessPolicy, *AccessPolicyClientBeginCreateUpdateOptions) (*runtime.Poller[AccessPolicyClientCreateUpdateResponse], error)`
info	[Changelog] - New function `*AccessPolicyClient.BeginDelete(context.Context, string, string, string, *AccessPolicyClientBeginDeleteOptions) (*runtime.Poller[AccessPolicyClientDeleteResponse], error)`
info	[Changelog] - New function `*AccessPolicyClient.Get(context.Context, string, string, string, *AccessPolicyClientGetOptions) (AccessPolicyClientGetResponse, error)`
info	[Changelog] - New function `*AccessPolicyClient.NewListPager(string, string, *AccessPolicyClientListOptions) *runtime.Pager[AccessPolicyClientListResponse]`
info	[Changelog] - New function `*Client.BeginFlushCache(context.Context, string, string, *ClientBeginFlushCacheOptions) (*runtime.Poller[ClientFlushCacheResponse], error)`
info	[Changelog] - New function `*ClientFactory.NewAccessPolicyAssignmentClient() *AccessPolicyAssignmentClient`
info	[Changelog] - New function `*ClientFactory.NewAccessPolicyClient() *AccessPolicyClient`
info	[Changelog] - New struct `CacheAccessPolicy`
info	[Changelog] - New struct `CacheAccessPolicyAssignment`
info	[Changelog] - New struct `CacheAccessPolicyAssignmentList`
info	[Changelog] - New struct `CacheAccessPolicyAssignmentProperties`
info	[Changelog] - New struct `CacheAccessPolicyList`
info	[Changelog] - New struct `CacheAccessPolicyProperties`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New field `AADEnabled` in struct `CommonPropertiesRedisConfiguration`
info	[Changelog] - New field `UpdateChannel` in struct `CreateProperties`
info	[Changelog] - New field `UpdateChannel` in struct `Properties`
info	[Changelog] - New field `UpdateChannel` in struct `UpdateProperties`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 52 additive change(s).

️✔️sdk/resourcemanager/redisenterprise/armredisenterprise [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Operation `*PrivateEndpointConnectionsClient.Delete` has been changed to LRO, use `*PrivateEndpointConnectionsClient.BeginDelete` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ResourceStateScaling`, `ResourceStateScalingFailed` added to enum type `ResourceState`
info	[Changelog] - New enum type `CmkIdentityType` with values `CmkIdentityTypeSystemAssignedIdentity`, `CmkIdentityTypeUserAssignedIdentity`
info	[Changelog] - New enum type `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
info	[Changelog] - New function `*Client.CheckNameAvailability(context.Context, CheckNameAvailabilityParameters, *ClientCheckNameAvailabilityOptions) (ClientCheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `*ClientFactory.NewSKUsClient() *SKUsClient`
info	[Changelog] - New function `*DatabasesClient.BeginFlush(context.Context, string, string, string, FlushParameters, *DatabasesClientBeginFlushOptions) (*runtime.Poller[DatabasesClientFlushResponse], error)`
info	[Changelog] - New function `NewSKUsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SKUsClient, error)`
info	[Changelog] - New function `*SKUsClient.NewListPager(string, *SKUsClientListOptions) *runtime.Pager[SKUsClientListResponse]`
info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
info	[Changelog] - New struct `Capability`
info	[Changelog] - New struct `CheckNameAvailabilityParameters`
info	[Changelog] - New struct `ClusterPropertiesEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryption`
info	[Changelog] - New struct `ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity`
info	[Changelog] - New struct `FlushParameters`
info	[Changelog] - New struct `LocationInfo`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `RegionSKUDetail`
info	[Changelog] - New struct `RegionSKUDetails`
info	[Changelog] - New struct `SKUDetail`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New field `Identity`, `SystemData` in struct `Cluster`
info	[Changelog] - New field `Encryption` in struct `ClusterProperties`
info	[Changelog] - New field `Identity` in struct `ClusterUpdate`
info	[Changelog] - New field `SystemData` in struct `Database`
info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `SystemData` in struct `PrivateLinkResource`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 58 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e9029be. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-rediscache [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-rediscache-8.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group AccessPolicy
info	[Changelog]   - Added operation group AccessPolicyAssignment
info	[Changelog]   - Added operation Redis.beginFlushCache
info	[Changelog]   - Added operation Redis.beginFlushCacheAndWait
info	[Changelog]   - Added Interface AccessPolicyAssignmentCreateUpdateOptionalParams
info	[Changelog]   - Added Interface AccessPolicyAssignmentDeleteHeaders
info	[Changelog]   - Added Interface AccessPolicyAssignmentDeleteOptionalParams
info	[Changelog]   - Added Interface AccessPolicyAssignmentGetOptionalParams
info	[Changelog]   - Added Interface AccessPolicyAssignmentListNextOptionalParams
info	[Changelog]   - Added Interface AccessPolicyAssignmentListOptionalParams
info	[Changelog]   - Added Interface AccessPolicyCreateUpdateOptionalParams
info	[Changelog]   - Added Interface AccessPolicyDeleteHeaders
info	[Changelog]   - Added Interface AccessPolicyDeleteOptionalParams
info	[Changelog]   - Added Interface AccessPolicyGetOptionalParams
info	[Changelog]   - Added Interface AccessPolicyListNextOptionalParams
info	[Changelog]   - Added Interface AccessPolicyListOptionalParams
info	[Changelog]   - Added Interface LinkedServerDeleteHeaders
info	[Changelog]   - Added Interface RedisCacheAccessPolicy
info	[Changelog]   - Added Interface RedisCacheAccessPolicyAssignment
info	[Changelog]   - Added Interface RedisCacheAccessPolicyAssignmentList
info	[Changelog]   - Added Interface RedisCacheAccessPolicyList
info	[Changelog]   - Added Interface RedisFlushCacheHeaders
info	[Changelog]   - Added Interface RedisFlushCacheOptionalParams
info	[Changelog]   - Added Type Alias AccessPolicyAssignmentCreateUpdateResponse
info	[Changelog]   - Added Type Alias AccessPolicyAssignmentGetResponse
info	[Changelog]   - Added Type Alias AccessPolicyAssignmentListNextResponse
info	[Changelog]   - Added Type Alias AccessPolicyAssignmentListResponse
info	[Changelog]   - Added Type Alias AccessPolicyAssignmentProvisioningState
info	[Changelog]   - Added Type Alias AccessPolicyCreateUpdateResponse
info	[Changelog]   - Added Type Alias AccessPolicyGetResponse
info	[Changelog]   - Added Type Alias AccessPolicyListNextResponse
info	[Changelog]   - Added Type Alias AccessPolicyListResponse
info	[Changelog]   - Added Type Alias AccessPolicyProvisioningState
info	[Changelog]   - Added Type Alias AccessPolicyType
info	[Changelog]   - Added Type Alias RedisFlushCacheResponse
info	[Changelog]   - Added Type Alias UpdateChannel
info	[Changelog]   - Interface RedisCommonProperties has a new optional parameter updateChannel
info	[Changelog]   - Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter aadEnabled
info	[Changelog]   - Interface RedisCreateParameters has a new optional parameter updateChannel
info	[Changelog]   - Interface RedisResource has a new optional parameter updateChannel
info	[Changelog]   - Interface RedisUpdateParameters has a new optional parameter updateChannel
info	[Changelog]   - Added Enum KnownAccessPolicyAssignmentProvisioningState
info	[Changelog]   - Added Enum KnownAccessPolicyProvisioningState
info	[Changelog]   - Added Enum KnownAccessPolicyType
info	[Changelog]   - Added Enum KnownUpdateChannel
info	[Changelog]   - Enum KnownProvisioningState has a new value ConfiguringAAD
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter error of interface OperationStatusResult is changed from ErrorDetailAutoGenerated to ErrorDetail

️✔️@azure/arm-redisenterprisecache [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-redisenterprisecache-3.0.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group Skus
info	[Changelog]   - Added operation Databases.beginFlush
info	[Changelog]   - Added operation Databases.beginFlushAndWait
info	[Changelog]   - Added operation PrivateEndpointConnections.beginDelete
info	[Changelog]   - Added operation PrivateEndpointConnections.beginDeleteAndWait
info	[Changelog]   - Added operation RedisEnterprise.checkNameAvailability
info	[Changelog]   - Added Interface Capability
info	[Changelog]   - Added Interface CheckNameAvailabilityParameters
info	[Changelog]   - Added Interface ClusterPropertiesEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryption
info	[Changelog]   - Added Interface ClusterPropertiesEncryptionCustomerManagedKeyEncryptionKeyIdentity
info	[Changelog]   - Added Interface DatabasesFlushHeaders
info	[Changelog]   - Added Interface DatabasesFlushOptionalParams
info	[Changelog]   - Added Interface FlushParameters
info	[Changelog]   - Added Interface LocationInfo
info	[Changelog]   - Added Interface ManagedServiceIdentity
info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
info	[Changelog]   - Added Interface RedisEnterpriseCheckNameAvailabilityOptionalParams
info	[Changelog]   - Added Interface RegionSkuDetail
info	[Changelog]   - Added Interface RegionSkuDetails
info	[Changelog]   - Added Interface SkuDetail
info	[Changelog]   - Added Interface SkusListOptionalParams
info	[Changelog]   - Added Interface SystemData
info	[Changelog]   - Added Interface UserAssignedIdentity
info	[Changelog]   - Added Type Alias CmkIdentityType
info	[Changelog]   - Added Type Alias CreatedByType
info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
info	[Changelog]   - Added Type Alias SkusListResponse
info	[Changelog]   - Interface Cluster has a new optional parameter encryption
info	[Changelog]   - Interface Cluster has a new optional parameter identity
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter encryption
info	[Changelog]   - Interface ClusterUpdate has a new optional parameter identity
info	[Changelog]   - Interface PrivateEndpointConnectionsDeleteOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface PrivateEndpointConnectionsDeleteOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Added Enum KnownCmkIdentityType
info	[Changelog]   - Added Enum KnownCreatedByType
info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
info	[Changelog]   - Enum KnownResourceState has a new value Scaling
info	[Changelog]   - Enum KnownResourceState has a new value ScalingFailed
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation PrivateEndpointConnections.delete

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from e9029be. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️redis [View full logs] [Release Schema Changes]
️✔️redisenterprise [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from e9029be. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.redis.DefaultTag [View full logs]

Az.Redis.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.redis.DefaultTag
error		Az.redisenterprise.DefaultTag

⚠️Az.redisenterprise.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-24T18:14:52Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/redis/armredis	https://apiview.dev/Assemblies/Review/1ca06c848b254031a1fb8791eef93dca
Go	sdk/resourcemanager/redisenterprise/armredisenterprise	https://apiview.dev/Assemblies/Review/bb86d040a1034d808ce30b5238ac50df
.Net	Azure.ResourceManager.RedisEnterprise	https://apiview.dev/Assemblies/Review/8cad78a06cb64e77871e558c53d486ca
Java	azure-resourcemanager-redis-generated	https://apiview.dev/Assemblies/Review/d24ee1074563486b999736d197f6a6b3
Java	azure-resourcemanager-redisenterprise	https://apiview.dev/Assemblies/Review/18e2f53c1e1c472b918491b5321bd499
JavaScript	@azure/arm-rediscache	https://apiview.dev/Assemblies/Review/90f1ebb4463047c6b80a8fa333befdf4
JavaScript	@azure/arm-redisenterprisecache	https://apiview.dev/Assemblies/Review/a58630b2010046b5a770228d585501a0

openapi-workflow-bot · 2023-08-24T18:35:44Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

priyankarking · 2023-08-28T14:08:24Z

...tion/redisenterprise/resource-manager/Microsoft.Cache/stable/2023-07-01/redisenterprise.json

@@ -1700,6 +1700,7 @@
      "properties": {
        "id": {
          "type": "string",
+          "format": "arm-id",


I think we need to also add make changes in "ForceUnlinkParameters" properties, since it also have array of redis databases

We should I think add this attribute whenever we use arm-id for databases ARM ID.
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.Cache/redisEnterprise/databases"
}
]
}

Added the x-ms-arm-id-details here w/ entry "Microsoft.Cache/redisEnterprise/databases" and also added for ForceUnlinkParameters.

priyankarking

Pls make changes to use arm-id format wherever we use data base resource ID

matthchr · 2023-09-05T15:16:10Z

I've updated the definitions.RedisLinkedServer.properties.id as well.

sanar-microsoft

matthchr · 2023-09-13T17:43:34Z

/pr RequestMerge

TimLovellSmith · 2023-09-13T21:22:15Z

specification/redis/resource-manager/Microsoft.Cache/stable/2023-04-01/redis.json

+                "type": "Microsoft.Network/virtualNetworks/subnets"
+              },
+              {
+                "type": "Microsoft.ClassicNetwork/virtualNetworks/subnets"


nonblocking question since from conservatism point of view its fine...
Is ClassicNetwork still supported? I think the plan is to deprecate it soon?

I'm not sure, but I don't think it hurts to have it here as all this is really saying is that "we would accept ClassicNetwork if you give it to us" - even if you can't make new ones maybe legacy existing ones are still allowed for a while?

Agree that it might be nice to be able to remove this once it really is deprecated, though not sure how to actually accomplish that in practice when the time comes.

openapi-pipeline-app · 2023-09-13T21:23:32Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

…5517) LGTM merging

matthchr requested a review from TimLovellSmith as a code owner August 24, 2023 18:14

openapi-workflow-bot bot added the FixS360 label Aug 24, 2023

openapi-assignment-bot bot assigned rkmanda Aug 24, 2023

priyankarking reviewed Aug 28, 2023

View reviewed changes

priyankarking requested changes Aug 28, 2023

View reviewed changes

matthchr force-pushed the feature/redis-update-again branch from 35f8372 to af446d2 Compare August 28, 2023 16:31

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 29, 2023

matthchr removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 29, 2023

Use format: arm-id in Redis and RedisEnterprise where appropriate

63933c0

matthchr force-pushed the feature/redis-update-again branch from af446d2 to 63933c0 Compare September 5, 2023 15:15

sanar-microsoft approved these changes Sep 6, 2023

View reviewed changes

priyankarking approved these changes Sep 6, 2023

View reviewed changes

mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 7, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 7, 2023

gorandom approved these changes Sep 7, 2023

View reviewed changes

github-actions bot added the MergeRequested label Sep 13, 2023

TimLovellSmith reviewed Sep 13, 2023

View reviewed changes

TimLovellSmith merged commit e9029be into Azure:main Sep 13, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Go label Sep 13, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Sep 13, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Sep 13, 2023

azure-sdk mentioned this pull request Sep 13, 2023

[ReleasePR azure-resourcemanager-redisenterprise] Stabilize identity, encryption, and scaling status in Redis Enterprise version: 2023-11-01 Azure/azure-sdk-for-java#30294

Closed

matthchr deleted the feature/redis-update-again branch September 13, 2023 21:43

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023

Use format: arm-id in Redis and RedisEnterprise where appropriate (#2…

1cf6bc8

…5517) LGTM merging

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use format: arm-id in Redis and RedisEnterprise where appropriate #25517

Use format: arm-id in Redis and RedisEnterprise where appropriate #25517

matthchr commented Aug 24, 2023

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-workflow-bot bot commented Aug 24, 2023

priyankarking Aug 28, 2023

priyankarking Aug 28, 2023

matthchr Aug 28, 2023

priyankarking left a comment

matthchr commented Sep 5, 2023

sanar-microsoft left a comment

matthchr commented Sep 13, 2023

TimLovellSmith Sep 13, 2023 •

edited

Loading

matthchr Sep 13, 2023

openapi-pipeline-app bot commented Sep 13, 2023

Use format: arm-id in Redis and RedisEnterprise where appropriate #25517

Use format: arm-id in Redis and RedisEnterprise where appropriate #25517

Conversation

matthchr commented Aug 24, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 24, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Aug 24, 2023

priyankarking Aug 28, 2023

Choose a reason for hiding this comment

priyankarking Aug 28, 2023

Choose a reason for hiding this comment

matthchr Aug 28, 2023

Choose a reason for hiding this comment

priyankarking left a comment

Choose a reason for hiding this comment

matthchr commented Sep 5, 2023

sanar-microsoft left a comment

Choose a reason for hiding this comment

matthchr commented Sep 13, 2023

TimLovellSmith Sep 13, 2023 • edited Loading

Choose a reason for hiding this comment

matthchr Sep 13, 2023

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Sep 13, 2023

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2023 •

edited

Loading

TimLovellSmith Sep 13, 2023 •

edited

Loading