[Hub Generated] Review request for Microsoft.PlaywrightTesting to add version preview/2023-10-01-preview #25445
Conversation
…eview api-version 2023-10-01-preview
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi @mjmadhu This PR was flagged for introducing a new RP namespace that is not being onboarded with RPaaS. Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please use RPaaS to onboard the new RP. |
|
Hi, @mjmadhu, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
|
This PR is for public preview due in September 2023 of an RPaaS RP - Microsoft.AzurePlaywrightService We're intending to move towards better folder and namespace naming convention as discussed with API Stewardship Board and recommended for SDK as well by dropping unnecessary terms from the names like Azure and Service, hence keeping it only as "playwrighttesting". Though we'd like to stick to the current RP Namespace "Microsoft.AzurePlaywrightService" for now since our Public preview is due this September and seems like renaming RP Namespace would need sheer updates and re-visits for sign-offs as it seems to be a reset as mentioned here. Please let us know if there's any concern with the approach, else we'll fallback to the previous convention of "azureplaywrightservice" for folder structure as well for now. Update - |
|
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
|
https://github.com/Azure/azure-rest-api-specs/pull/25445/checks?check_run_id=16114493478 |
|
Pushing for review by the time the swagger model validation issue is getting fixed for early feedback. |
mjmadhu
requested review from
msyyc,
tadelesh,
jsntcy and
qiaozha
as code owners
AzureRestAPISpecReview
added
ARMReview
WaitForARMFeedback
mjmadhu
removed
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
It's not required the properties be in the PUT payload, but it's required that they be allowed in the payload. Hence, they are required in the swagger. |
mentat9
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/pr RequestMerge |
There was a problem hiding this comment.
The OBJECT_MISSING_REQUIRED_PROPERTY errors are a kafka-trap. If Madhuri fixes them, she'll immediately end up with READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST, which is caused by an outstanding issue with oav.
When the bug in OAV is fixed, the READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST with this PR will disappear. Additional work will be necessary to update the OBJECT_MISSING_REQUIRED_PROPERTY issues.
openapi-pipeline-app
bot
added
CI-NewRPNamespaceWithoutRPaaS
and removed
CI-NewRPNamespaceWithoutRPaaS
labels
|
/pr RequestMerge |
rkmanda
deleted the
mjmadhu-playwrighttesting-Microsoft.AzurePlaywrightService-2023-10-01-preview
branch
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
specification/playwrighttesting/PlaywrightTesting.Management/examples/Quotas_Get.json
Show resolved
Hide resolved
… version preview/2023-10-01-preview (#25445) * Generate new Service for playwrighttesting * Adding Management APIs for Microsoft.AzurePlaywrightService public preview api-version 2023-10-01-preview * CI failures Fix * Removed description form properties as it's not required * Added new resource type * Spell check fix * Renamed quota resource type * Rectifying the typespec issue for location based resource * Renamed enum value * Review comments addressed * Swagger build errors resolution * Swagger model validation error fix for example * Added dashboard URI in examples * Revert "Added dashboard URI in examples" This reverts commit 8b1a7cb. * Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview data plane (#25681) * Renamed entity from access-key to access-token * Added subscription state to handle appropriate action for clients * Added account state as a property * Updated regex for names * Updated example * Added readonly properties in PUT request examples
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.