Fuming zhang containerservice microsoft.container service 2023 07 02 preview #25433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushmak295
requested review from
palma21,
weinong,
alvinli222,
matthchr and
circy9
as code owners
|
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| managedClusters.json | 2023-07-02-preview(100d52b) | 2023-07-01(main) |
| managedClusters.json | 2023-07-02-preview(100d52b) | 2023-06-02-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-preview-2023-07 | package-preview-2023-07(100d52b) | package-preview-2023-07(FumingZhang-containerservice-Microsoft.ContainerService-2023-07-02-preview) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: aks/preview/2023-07-02-preview/managedClusters.json#L2153 |
| Based on the response model schema, operation 'ManagedClusters_ListKubernetesVersions' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-07-02-preview/managedClusters.json#L116 |
|
| OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId Location: aks/preview/2023-07-02-preview/managedClusters.json#L284 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-07-02-preview/managedClusters.json#L367 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-07-02-preview/managedClusters.json#L415 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-07-02-preview/managedClusters.json#L460 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster Location: aks/preview/2023-07-02-preview/managedClusters.json#L502 |
|
| The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1072 |
|
| The response of operation:'AgentPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1115 |
|
| The response of operation:'Machines_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1385 |
|
| Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1869 |
|
| The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1912 |
|
| The response of operation:'PrivateEndpointConnections_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-07-02-preview/managedClusters.json#L1960 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: aks/preview/2023-07-02-preview/managedClusters.json#L2131 |
|
| OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId Location: aks/preview/2023-07-02-preview/managedClusters.json#L2178 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution sushmak295! We will review the pull request and get back to you soon. |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
This was referenced Aug 22, 2023
This was referenced Aug 22, 2023
|
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
FumingZhang
reviewed
Aug 22, 2023
...ource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json
Outdated
Show resolved
Hide resolved
|
Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
FumingZhang
approved these changes
Aug 22, 2023
FumingZhang
merged commit 8ed8c3a
into
Azure:FumingZhang-containerservice-Microsoft.ContainerService-2023-07-02-preview
ms-henglu
pushed a commit
that referenced
this pull request
Aug 22, 2023
…add version preview/2023-07-02-preview (#25254) * Adds base for updating Microsoft.ContainerService/aks from version preview/2023-06-02-preview to version 2023-07-02-preview * Updates readme * Updates API version in new specs and examples * update readmes (#25049) * add new field resourceUID to managed cluster properties (#25069) * add new field resourceUID to managed cluster properties https://msazure.visualstudio.com/CloudNativeCompute/_git/aks-rp/pullrequest/8416789 * update description * Mark guardrailsProfile Version as not required (#25081) * Mark guardrailsProfile Version as not required * Run prettier --------- Co-authored-by: Nick Keller <[email protected]> * Swagger Changes for Multiple DNS Zones for Web App Routing (#25064) * added web app routing changes for multiple dns zones * modified examples * Changes for unified azuremonitorprofile in Microsoft.ContainerService (#25063) * Changes for unified azuremonitorprofile * Update prettier changes * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json Co-authored-by: FumingZhang <[email protected]> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json Co-authored-by: FumingZhang <[email protected]> --------- Co-authored-by: Janvi Jatakia (from Dev Box) <[email protected]> Co-authored-by: FumingZhang <[email protected]> * Add cost analysis to AKS preview Swagger (#25082) * update preview API to follow GA api - use one forceupgrade boolean in… (#25099) * update preview API to follow GA api - use one forceupgrade boolean instead of multiple overrides * update msg --------- Co-authored-by: Wenjun Gao <[email protected]> * Mark trusted access role binding PUT and DELETE operation as async (#25112) * Mark trusted access role binding PUT and DELETE operation as async * fix CI: update TA oepration's error to common type error * Swagger for Machine API (#25180) * Swagger for Machine List, Get API Related work items: #24759018 * Update managedClusters.json * Update managedClusters.json * Update MachineGet.json adding new line * Update MachineList.json * Update managedClusters.json * Update managedClusters.json * Update managedClusters.json * swagger: machine api * swagger: machine api * swagger:machine api * swagger: machine api * swagger: machine api * swagger: machine api * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-07-02-preview/managedClusters.json Co-authored-by: FumingZhang <[email protected]> * swagger: machine api * swagger: machine api * swagger: machine api * swagger:machine api * swagger:machine api * swagger:machine api --------- Co-authored-by: FumingZhang <[email protected]> * Adding Guardrails version to public swagger (#25085) * Adding Guardrails version to public swagger * renamed GetGuardrailsVersions.json * Applied GetCollectionResponseSchema rule * Ran prettier fix * Minor change * moving parametre into managedClusters.json * GuardrailsAvailableVersion model change * Updated version param reference * Swagger SemanticValidation fix * model changes * prettier fix * Added version in list response * Changed to resource in GET and added descriptions where needed * Removed identifier in GuardrailsAvailableVersionsList --------- Co-authored-by: Sindhuja Salla <[email protected]> * Remove overlay vpa unused properties (#25242) * remove unused properties * only remove from required section * remove the whole properties --------- Co-authored-by: zhifanhui <[email protected]> * asm: update examples to use asm- prefix for revisions (#25247) * Revert "Mark trusted access role binding PUT and DELETE operation as async (#25112)" (#25233) This reverts commit db24ef8. * fix AgentPoolNameParameter location * Fuming zhang containerservice microsoft.container service 2023 07 02 preview (#25433) * adding requested properties. * adding requested properties * prettier check * removing read-only constraint --------- Co-authored-by: daru__ <[email protected]> Co-authored-by: Nick Keller <[email protected]> Co-authored-by: Nick Keller <[email protected]> Co-authored-by: Jaiveer Katariya <[email protected]> Co-authored-by: Janvi Jatakia <[email protected]> Co-authored-by: Janvi Jatakia (from Dev Box) <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: Wenjun Gao <[email protected]> Co-authored-by: Wenjun Gao <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: sushmak295 <[email protected]> Co-authored-by: sallasindhuja <[email protected]> Co-authored-by: Sindhuja Salla <[email protected]> Co-authored-by: huizhifan <[email protected]> Co-authored-by: zhifanhui <[email protected]> Co-authored-by: Sanya Kochhar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.