-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds UpdateChannel property to Redis-API #25379
Adds UpdateChannel property to Redis-API #25379
Conversation
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
redis.json | 2023-08-01(0857262) | 2023-04-01(main) |
redis.json | 2023-08-01(0857262) | 2023-05-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
package-2023-08 | package-2023-08(0857262) | package-2023-08(dev-redis-Microsoft.Cache-2023-08-01) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2023-08-01/redis.json#L73 |
MissingTypeObject |
The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2195 |
MissingTypeObject |
The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2235 |
MissingTypeObject |
The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2392 |
MissingTypeObject |
The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2424 |
MissingTypeObject |
The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2439 |
MissingTypeObject |
The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2523 |
MissingTypeObject |
The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2563 |
MissingTypeObject |
The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2584 |
MissingTypeObject |
The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2599 |
MissingTypeObject |
The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2625 |
MissingTypeObject |
The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2642 |
MissingTypeObject |
The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2659 |
MissingTypeObject |
The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2688 |
MissingTypeObject |
The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2726 |
MissingTypeObject |
The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2743 |
MissingTypeObject |
The schema 'RedisRebootParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2763 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2785 |
MissingTypeObject |
The schema 'ExportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2793 |
MissingTypeObject |
The schema 'ImportRDBParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2822 |
MissingTypeObject |
The schema 'ScheduleEntry' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2849 |
MissingTypeObject |
The schema 'ScheduleEntries' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2887 |
MissingTypeObject |
The schema 'RedisPatchSchedule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2904 |
TrackedResourcePatchOperation |
Tracked resource 'RedisPatchSchedule' must have patch operation that at least supports the update of tags. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2904 |
MissingTypeObject |
The schema 'RedisPatchScheduleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2927 |
MissingTypeObject |
The schema 'RedisForceRebootResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2944 |
MissingTypeObject |
The schema 'RedisLinkedServer' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2954 |
MissingTypeObject |
The schema 'RedisLinkedServerWithProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2964 |
MissingTypeObject |
The schema 'RedisLinkedServerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2979 |
MissingTypeObject |
The schema 'RedisLinkedServerWithPropertiesList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2023-08-01/redis.json#L2994 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Thank you for your contribution Darfeikus! We will review the pull request and get back to you soon. |
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
specification/redis/resource-manager/Microsoft.Cache/stable/2023-08-01/redis.json
Outdated
Show resolved
Hide resolved
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
/azp run |
Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Azure Pipelines successfully started running 2 pipeline(s). |
…ble/2023-08-01 (#25215) * Adds base for updating Microsoft.Cache from version preview/2023-05-01-preview to version 2023-08-01 * Updates readme * Updates API version in new specs and examples * Add flush operation to 2023-08-01 Redis API version (#25298) * add flush operation to 2023-08-01 redis api version * Add "x-ms-long-running-operation-options" and "headers" properties * remove OperationStatusResult * remove 200 response code * Revert "remove 200 response code" This reverts commit 1f9c78f. * empty body for 200 response * add schema ref * use CacheNameParameter * "name" -> "cacheName" * add cacheName to flush example --------- Co-authored-by: Austin Tolani <[email protected]> * Adds UpdateChannel property to Redis-API (#25379) Adds UpdateChannel property to Redis-API * use v3 for OperationStatusResult * remove lenient-model-deduplication in readme.go.md * Update ErrorResponse to v3 --------- Co-authored-by: Austin Tolani <[email protected]> Co-authored-by: Austin Tolani <[email protected]> Co-authored-by: Oscar Barbosa Aquino <[email protected]>
…ble/2023-08-01 (#25215) * Adds base for updating Microsoft.Cache from version preview/2023-05-01-preview to version 2023-08-01 * Updates readme * Updates API version in new specs and examples * Add flush operation to 2023-08-01 Redis API version (#25298) * add flush operation to 2023-08-01 redis api version * Add "x-ms-long-running-operation-options" and "headers" properties * remove OperationStatusResult * remove 200 response code * Revert "remove 200 response code" This reverts commit 1f9c78f. * empty body for 200 response * add schema ref * use CacheNameParameter * "name" -> "cacheName" * add cacheName to flush example --------- Co-authored-by: Austin Tolani <[email protected]> * Adds UpdateChannel property to Redis-API (#25379) Adds UpdateChannel property to Redis-API * use v3 for OperationStatusResult * remove lenient-model-deduplication in readme.go.md * Update ErrorResponse to v3 --------- Co-authored-by: Austin Tolani <[email protected]> Co-authored-by: Austin Tolani <[email protected]> Co-authored-by: Oscar Barbosa Aquino <[email protected]>
Adds the updateChannel property to the OpenAPI spec for Redis in the 2023-08-01 API version.
This PR is into a dev branch, so does not need to be reviewed by ARM reviewers.