Release sql microsoft.sql 2023 02 01 preview

[jeremyfrosti]

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

• New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
• Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
• Update existing version to fix swagger quality issues in S360.
• Other, please clarify:
  • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

• I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
• I have reviewed following Resource Provider guidelines, including
  ARM resource provider contract and
  REST guidelines (estimated time: 4 hours).
  I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

• If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
  you must follow the breaking changes process.
  IMPORTANT This applies even if:
  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

• If this PR is in purview of ARM review then automation will add the ARMReview label.
• If you want to force ARM review, add the label yourself.
• Proceed according to the diagram at the top of this comment.

Getting help

• For general PR approval workflow, see the diagram at the top of this comment.
• For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
  and https://aka.ms/ci-fix.
• If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

[openapi-workflow-bot]

Hi, @jeremyfrosti! Thank you for your pull request. To help get your PR merged:

Ensure you reviewed the checklists in the PR description.

Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 46 Errors, 51 Warnings failed [Detail]

Only 0 items are rendered, please refer to log for more details.

The following breaking changes are detected by comparison with the latest stable version:

Only -1 items are listed, please refer to log for more details.

Rule	Message

The following breaking changes are detected by comparison with the latest preview version:

Only -1 items are listed, please refer to log for more details.

Rule	Message

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 302 Errors, 0 Warnings failed [Detail]

Only -1 items are listed, please refer to log for more details.

Rule	Message

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌SDK Breaking Change Tracking failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-java warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-powershell failed [Detail]

Only 0 items are rendered, please refer to log for more details.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/sql/armsql	https://apiview.dev/Assemblies/Review/0dc0ec48f356435780ce485fb29ddb64
JavaScript	@azure/arm-sql	https://apiview.dev/Assemblies/Review/0dcb8ffe723b4850ae864c9c1d658f4c

[jeremyfrosti]

These commits have been approved during merging to the feature branch. Relevant commits: main...release-sql-Microsoft.Sql-2023-02-01-preview

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[jeremyfrosti]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[jeremyfrosti]

@TimLovellSmith The 'name' being writable has been used in previous versions, although the reliance on it has been removed in IPv6FirewallRules.json after version 2021-11-01-preview. We still can not simply update the ResourceWithWritableName to mark the property as readonly though, this same model is used in other files such as FirewallRules.json, and making it different in IPv6FirewallRules would cause us to have two different definitions with the same name, and we can't do that. It is also used for internal functions that rely on the name being writable.

Theoretically, we can change ProxyResourceWithWritableName to ProxyResource here:

azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/IPv6FirewallRules.json

Line 220 in 643b6da

"$ref": "#/definitions/ProxyResourceWithWritableName"

But that may be a breaking change for downstream client generation. If its not, the change may be possible.

Again though, does this need to be done for us to release our next version? This is not new to this version, and that api has had no changes in this version. It has existed for many versions before, so why are we blocking this one? This will cause a delay to our release, and that will cause us to miss deadlines on features that have been promised to our customers. If this must be blocked, we need to schedule a meeting to discuss this and understand why this is worth blocking our release and how we can expedite the change ASAP.

[TimLovellSmith]

@jeremyfrosti you're right it shouldn't really need to block feature development, I'm just trying to understand why we have these linter errors, and whether its the kind of API quality thing we can/should fix. In particular I'm puzzled about whether you are deliberately allowing the behavior today, maybe you could explain more about what 'reliance' or lack of it means, while I sign this off...

[TimLovellSmith]

Looks like you still need to suppress the LintDiff errors if you're not fixing them before merge.
https://github.com/Azure/azure-rest-api-specs/pull/25293/checks?check_run_id=15958574056
https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/ci-fix.md#lintdiff-validation

[kazrael2119]

this js sdk breaking is caused by this pr

[openapi-pipeline-app]

Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

[ms-henglu]

I will approve and unblock this for a couple contributing reasons.

1. The previous PR was approved and released with 320 errors. This PR actually narrows those errors from 320 to 302!
2. All errors in this PR are this INVALID_TYPE error. As far as I can tell, I believe this is an oav analysis issue. Specifically, I have filed a new issue against Azure/oav to cover a resolution on analysis side.

Given the above situation, I'm going to approve failing ModelValidation check here.

According to this comment, I'll help adding the Approved-ModelValidation label.

[ms-henglu]

The one new lint diff error detected actually exists in previous version.

[jeremyfrosti]

/pr RequestMerge

[openapi-pipeline-app]

Swagger pipeline restarted successfully, please wait for status update in this comment.