Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve flatten issue #24797

Merged
merged 3 commits into from
Oct 24, 2023

Merge branch 'Azure:main' into main

6a182b8
Select commit
Loading
Failed to load commit list.
Merged

resolve flatten issue #24797

Merge branch 'Azure:main' into main
6a182b8
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff failed Oct 23, 2023 in 3m 44s

~[NotRequired_Staging] Swagger LintDiff failed

ppe/LintDiff: 4 Errors, 4 Warnings
View more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-2022-12 package-2022-12(6a182b8) package-2022-12(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2022-12-27/privateLinkScopes.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 2: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 3: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 4: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 5: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 6: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 7: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 8: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined')
Location: azure-rest-api-specs/blob/6a182b8432f7aa18da26adac2f08b59aca11be65/#L1
FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 2: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 3: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 4: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 5: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 6: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 7: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 8: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 9: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 10: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined')
Location: azure-rest-api-specs/blob/6a182b8432f7aa18da26adac2f08b59aca11be65/#L1


The following errors/warnings exist before current PR submission:

Rule Message
ArmResourcePropertiesBag Top level property names should not be repeated inside the properties bag for ARM resource 'MachineExtension'. Properties [properties.type] conflict with ARM top level properties. Please rename these.
Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1711
BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'Machine' has extra properties ['resources'].
Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1632
⚠️ PageableOperation Based on the response model schema, operation 'NetworkProfile_Get' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L1047
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create or Update a Machine Extension
Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L618
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Machines by resource group
Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L465
⚠️ PageableOperation Based on the response model schema, operation 'Machines_Get' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.HybridCompute/stable/2022-12-27/HybridCompute.json#L197